You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Yao Li <be...@126.com> on 2018/01/18 10:08:44 UTC
Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector
for Gaian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/
-----------------------------------------------------------
(Updated Jan. 18, 2018, 10:08 a.m.)
Review request for atlas and Mandy Chessell.
Repository: atlas
Description
-------
this is the JDBC Connector code for Connector to Gaian. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
Diffs
-----
jdbc/README.md PRE-CREATION
jdbc/connectors/JDBCConnection.java PRE-CREATION
jdbc/connectors/JDBCConnector.java PRE-CREATION
jdbc/connectors/JDBCConnectorBase.java PRE-CREATION
jdbc/connectors/JDBCConnectorProviderBase.java PRE-CREATION
jdbc/connectors/gaian/GaianJDBCConnector.java PRE-CREATION
jdbc/connectors/gaian/GaianJDBCConnectorProvider.java PRE-CREATION
jdbc/ffdc/ConnectionCheckedException.java PRE-CREATION
jdbc/ffdc/ExecutionCheckedException.java PRE-CREATION
jdbc/ffdc/JDBCConnectorCheckedExceptionBase.java PRE-CREATION
jdbc/ffdc/JDBCConnectorErrorCode.java PRE-CREATION
jdbc/ffdc/JDBCConnectorRuntimeException.java PRE-CREATION
jdbc/pom.xml PRE-CREATION
Diff: https://reviews.apache.org/r/65123/diff/1/
Testing
-------
create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
Thanks,
Yao Li
Re: Review Request 65123: ATLAS-2298 - Review of OCF Database
Connector
Posted by Yao Li <be...@126.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/
-----------------------------------------------------------
(Updated Jan. 31, 2018, 12:08 p.m.)
Review request for atlas and Mandy Chessell.
Changes
-------
discard this review request
Repository: atlas
Description (updated)
-------
Because some issues with uploading the patch, the new review will be shown on [https://reviews.apache.org/r/65435/](https://reviews.apache.org/r/65435/), and this page will not be updated anymore.
The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data.
Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
Diffs
-----
ocfdb/README.md
ocfdb/pom.xml
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDataProvider.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnection.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnector.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnectorProviderBase.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnector.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnectorProvider.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/DatabaseAccessCheckedException.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseCheckedExceptionBase.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorErrorCode.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorRuntimeException.java
Diff: https://reviews.apache.org/r/65123/diff/5/
Testing
-------
create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
File Attachments
----------------
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/425dded1-e882-4f5b-902b-acea0acec74d__ATLAS-2298-update-patch-based-on-reviews.patch
ATLAS-2298-update-the-patch-29-1.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/4c6d596c-dd34-4cf6-8fe0-33258e9965a6__ATLAS-2298-update-the-patch-29-1.patch
ATLAS-2298-update-the-patch-29-1.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/db1c4085-05c8-41d7-9367-274e5dadfa1c__ATLAS-2298-update-the-patch-29-1.patch
ATLAS-2298-30-Jan-review-verision.patch
https://reviews.apache.org/media/uploaded/files/2018/01/30/b4282020-0ef5-41bc-82d2-a0e0d64d592b__ATLAS-2298-30-Jan-review-verision.patch
Thanks,
Yao Li
Re: Review Request 65123: ATLAS-2298 - Review of OCF Database
Connector
Posted by Yao Li <be...@126.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/
-----------------------------------------------------------
(Updated Jan. 30, 2018, 3:29 p.m.)
Review request for atlas and Mandy Chessell.
Changes
-------
update after 30-01 review
Repository: atlas
Description
-------
The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data.
Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
Diffs
-----
ocfdb/README.md
ocfdb/pom.xml
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDataProvider.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnection.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnector.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnectorProviderBase.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnector.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnectorProvider.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/DatabaseAccessCheckedException.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseCheckedExceptionBase.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorErrorCode.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorRuntimeException.java
Diff: https://reviews.apache.org/r/65123/diff/5/
Testing
-------
create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
File Attachments (updated)
----------------
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/425dded1-e882-4f5b-902b-acea0acec74d__ATLAS-2298-update-patch-based-on-reviews.patch
ATLAS-2298-update-the-patch-29-1.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/4c6d596c-dd34-4cf6-8fe0-33258e9965a6__ATLAS-2298-update-the-patch-29-1.patch
ATLAS-2298-update-the-patch-29-1.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/db1c4085-05c8-41d7-9367-274e5dadfa1c__ATLAS-2298-update-the-patch-29-1.patch
ATLAS-2298-30-Jan-review-verision.patch
https://reviews.apache.org/media/uploaded/files/2018/01/30/b4282020-0ef5-41bc-82d2-a0e0d64d592b__ATLAS-2298-30-Jan-review-verision.patch
Thanks,
Yao Li
Re: Review Request 65123: ATLAS-2298 - Review of OCF Database
Connector
Posted by Yao Li <be...@126.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/
-----------------------------------------------------------
(Updated Jan. 29, 2018, 3:58 p.m.)
Review request for atlas and Mandy Chessell.
Repository: atlas
Description
-------
The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data.
Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
Diffs (updated)
-----
ocfdb/README.md
ocfdb/pom.xml
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDataProvider.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnection.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnector.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnectorProviderBase.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnector.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnectorProvider.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/DatabaseAccessCheckedException.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseCheckedExceptionBase.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorErrorCode.java
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorRuntimeException.java
Diff: https://reviews.apache.org/r/65123/diff/5/
Changes: https://reviews.apache.org/r/65123/diff/4-5/
Testing
-------
create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
File Attachments
----------------
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/425dded1-e882-4f5b-902b-acea0acec74d__ATLAS-2298-update-patch-based-on-reviews.patch
ATLAS-2298-update-the-patch-29-1.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/4c6d596c-dd34-4cf6-8fe0-33258e9965a6__ATLAS-2298-update-the-patch-29-1.patch
ATLAS-2298-update-the-patch-29-1.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/db1c4085-05c8-41d7-9367-274e5dadfa1c__ATLAS-2298-update-the-patch-29-1.patch
Thanks,
Yao Li
Re: Review Request 65123: ATLAS-2298 - Review of OCF Database
Connector
Posted by Yao Li <be...@126.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/
-----------------------------------------------------------
(Updated Jan. 29, 2018, 3:53 p.m.)
Review request for atlas and Mandy Chessell.
Repository: atlas
Description
-------
The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data.
Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
Diffs
-----
ocfdb/src/main/java/org/apache/atlas/ocf/Connector.java 89ebbba8
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBase.java cb0a9b5c
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java a8691d6c
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 020b79c9
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java f6b3bbc6
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java 6313c244
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java d45e944d
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java bf0e2c27
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java e6fad574
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 3d662717
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java f78eba99
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/README.md 40e4d123
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java 3af5a9ad
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotation.java fce22241
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java a6715941
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotations.java c9a4abb3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 405604c7
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 4cedd13c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java d1ca1593
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyIteratorBase.java a23b5df8
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java e8f45d4b
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java c9d5e69c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certification.java 5bc6475d
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 59529236
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classification.java 095ce274
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 663c6dc5
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comment.java cb1b04d1
ocfdb/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 6c071450
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comments.java 1991ca8e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java 909499e3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connection.java 5f11e2c2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connections.java 8a0c910c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 7cf8c6ad
ocfdb/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java 9f5057f4
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 19119d51
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementOrigin.java caf482c3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementType.java c942d85f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java 15f056ce
ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java 65b2265f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java e072b893
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifier.java 4d86134e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifiers.java a14113f2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReference.java 93706ad5
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReferences.java f293433e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Feedback.java 9e057840
ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java bed68242
ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTags.java 09e9f987
ocfdb/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java ce6dae17
ocfdb/src/main/java/org/apache/atlas/ocf/properties/License.java 2f29fe9c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Licenses.java e651ffd6
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Like.java 49684974
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Likes.java 5783f897
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Lineage.java 704a86dc
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Location.java fed3cda8
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Locations.java a4584a91
ocfdb/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java cedb5046
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meaning.java 47de9f9d
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meanings.java ce053961
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Note.java 0a81cb6d
ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLog.java 93ab414e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLogs.java 81f07766
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Notes.java 392aad3b
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PagingIterator.java b2bc1f6c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PrimitiveSchemaElement.java cd398704
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PropertyBase.java 124ac596
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Rating.java 12c1c511
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Ratings.java 0935ae9f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Referenceable.java ff93c60f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAsset.java 3d4ec3e3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssetProperties.java 2ed017e1
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssets.java ba7a4d72
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReference.java 8da295d8
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReferences.java 35d503b2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaType.java 0b71d463
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaUsage.java b106e16a
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Schema.java d3ce1912
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java 0d9e91a2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttributes.java dd570f8a
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaElement.java cd832fdd
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQueries.java d3f182aa
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQuery.java 5c2ac582
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLink.java 1a3b8d97
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLinks.java 77e597e3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaType.java 8b11a44b
ocfdb/src/main/java/org/apache/atlas/ocf/properties/StarRating.java 68ba7818
ocfdb/src/main/java/org/apache/atlas/ocf/properties/VirtualConnection.java ed94deed
ocfdb/src/test/java/AB.java ac21ec5c
ocfdb/src/test/java/Parent.java 70115fac
ocfdb/src/test/java/testPagingIterator.java 4b77cf12
Diff: https://reviews.apache.org/r/65123/diff/4/
Testing
-------
create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
File Attachments (updated)
----------------
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/425dded1-e882-4f5b-902b-acea0acec74d__ATLAS-2298-update-patch-based-on-reviews.patch
ATLAS-2298-update-the-patch-29-1.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/4c6d596c-dd34-4cf6-8fe0-33258e9965a6__ATLAS-2298-update-the-patch-29-1.patch
ATLAS-2298-update-the-patch-29-1.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/db1c4085-05c8-41d7-9367-274e5dadfa1c__ATLAS-2298-update-the-patch-29-1.patch
Thanks,
Yao Li
Re: Review Request 65123: ATLAS-2298 - Review of OCF Database
Connector
Posted by Yao Li <be...@126.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/
-----------------------------------------------------------
(Updated Jan. 29, 2018, 3:47 p.m.)
Review request for atlas and Mandy Chessell.
Repository: atlas
Description
-------
The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data.
Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
Diffs
-----
ocfdb/src/main/java/org/apache/atlas/ocf/Connector.java 89ebbba8
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBase.java cb0a9b5c
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java a8691d6c
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 020b79c9
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java f6b3bbc6
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java 6313c244
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java d45e944d
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java bf0e2c27
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java e6fad574
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 3d662717
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java f78eba99
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/README.md 40e4d123
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java 3af5a9ad
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotation.java fce22241
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java a6715941
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotations.java c9a4abb3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 405604c7
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 4cedd13c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java d1ca1593
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyIteratorBase.java a23b5df8
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java e8f45d4b
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java c9d5e69c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certification.java 5bc6475d
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 59529236
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classification.java 095ce274
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 663c6dc5
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comment.java cb1b04d1
ocfdb/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 6c071450
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comments.java 1991ca8e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java 909499e3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connection.java 5f11e2c2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connections.java 8a0c910c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 7cf8c6ad
ocfdb/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java 9f5057f4
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 19119d51
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementOrigin.java caf482c3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementType.java c942d85f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java 15f056ce
ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java 65b2265f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java e072b893
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifier.java 4d86134e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifiers.java a14113f2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReference.java 93706ad5
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReferences.java f293433e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Feedback.java 9e057840
ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java bed68242
ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTags.java 09e9f987
ocfdb/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java ce6dae17
ocfdb/src/main/java/org/apache/atlas/ocf/properties/License.java 2f29fe9c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Licenses.java e651ffd6
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Like.java 49684974
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Likes.java 5783f897
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Lineage.java 704a86dc
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Location.java fed3cda8
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Locations.java a4584a91
ocfdb/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java cedb5046
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meaning.java 47de9f9d
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meanings.java ce053961
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Note.java 0a81cb6d
ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLog.java 93ab414e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLogs.java 81f07766
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Notes.java 392aad3b
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PagingIterator.java b2bc1f6c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PrimitiveSchemaElement.java cd398704
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PropertyBase.java 124ac596
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Rating.java 12c1c511
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Ratings.java 0935ae9f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Referenceable.java ff93c60f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAsset.java 3d4ec3e3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssetProperties.java 2ed017e1
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssets.java ba7a4d72
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReference.java 8da295d8
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReferences.java 35d503b2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaType.java 0b71d463
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaUsage.java b106e16a
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Schema.java d3ce1912
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java 0d9e91a2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttributes.java dd570f8a
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaElement.java cd832fdd
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQueries.java d3f182aa
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQuery.java 5c2ac582
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLink.java 1a3b8d97
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLinks.java 77e597e3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaType.java 8b11a44b
ocfdb/src/main/java/org/apache/atlas/ocf/properties/StarRating.java 68ba7818
ocfdb/src/main/java/org/apache/atlas/ocf/properties/VirtualConnection.java ed94deed
ocfdb/src/test/java/AB.java ac21ec5c
ocfdb/src/test/java/Parent.java 70115fac
ocfdb/src/test/java/testPagingIterator.java 4b77cf12
Diff: https://reviews.apache.org/r/65123/diff/4/
Testing
-------
create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
File Attachments (updated)
----------------
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/425dded1-e882-4f5b-902b-acea0acec74d__ATLAS-2298-update-patch-based-on-reviews.patch
Thanks,
Yao Li
Re: Review Request 65123: ATLAS-2298 - Review of OCF Database
Connector
Posted by Yao Li <be...@126.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/
-----------------------------------------------------------
(Updated Jan. 29, 2018, 3:45 p.m.)
Review request for atlas and Mandy Chessell.
Changes
-------
update the correct patch
Repository: atlas
Description
-------
The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data.
Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
Diffs (updated)
-----
ocfdb/src/main/java/org/apache/atlas/ocf/Connector.java 89ebbba8
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBase.java cb0a9b5c
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java a8691d6c
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 020b79c9
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java f6b3bbc6
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java 6313c244
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java d45e944d
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java bf0e2c27
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java e6fad574
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 3d662717
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java f78eba99
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/README.md 40e4d123
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java 3af5a9ad
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotation.java fce22241
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java a6715941
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotations.java c9a4abb3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 405604c7
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 4cedd13c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java d1ca1593
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyIteratorBase.java a23b5df8
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java e8f45d4b
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java c9d5e69c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certification.java 5bc6475d
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 59529236
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classification.java 095ce274
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 663c6dc5
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comment.java cb1b04d1
ocfdb/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 6c071450
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comments.java 1991ca8e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java 909499e3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connection.java 5f11e2c2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connections.java 8a0c910c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 7cf8c6ad
ocfdb/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java 9f5057f4
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 19119d51
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementOrigin.java caf482c3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementType.java c942d85f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java 15f056ce
ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java 65b2265f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java e072b893
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifier.java 4d86134e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifiers.java a14113f2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReference.java 93706ad5
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReferences.java f293433e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Feedback.java 9e057840
ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java bed68242
ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTags.java 09e9f987
ocfdb/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java ce6dae17
ocfdb/src/main/java/org/apache/atlas/ocf/properties/License.java 2f29fe9c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Licenses.java e651ffd6
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Like.java 49684974
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Likes.java 5783f897
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Lineage.java 704a86dc
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Location.java fed3cda8
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Locations.java a4584a91
ocfdb/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java cedb5046
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meaning.java 47de9f9d
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meanings.java ce053961
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Note.java 0a81cb6d
ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLog.java 93ab414e
ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLogs.java 81f07766
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Notes.java 392aad3b
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PagingIterator.java b2bc1f6c
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PrimitiveSchemaElement.java cd398704
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PropertyBase.java 124ac596
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Rating.java 12c1c511
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Ratings.java 0935ae9f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Referenceable.java ff93c60f
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAsset.java 3d4ec3e3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssetProperties.java 2ed017e1
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssets.java ba7a4d72
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReference.java 8da295d8
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReferences.java 35d503b2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaType.java 0b71d463
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaUsage.java b106e16a
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Schema.java d3ce1912
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java 0d9e91a2
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttributes.java dd570f8a
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaElement.java cd832fdd
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQueries.java d3f182aa
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQuery.java 5c2ac582
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLink.java 1a3b8d97
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLinks.java 77e597e3
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaType.java 8b11a44b
ocfdb/src/main/java/org/apache/atlas/ocf/properties/StarRating.java 68ba7818
ocfdb/src/main/java/org/apache/atlas/ocf/properties/VirtualConnection.java ed94deed
ocfdb/src/test/java/AB.java ac21ec5c
ocfdb/src/test/java/Parent.java 70115fac
ocfdb/src/test/java/testPagingIterator.java 4b77cf12
Diff: https://reviews.apache.org/r/65123/diff/4/
Changes: https://reviews.apache.org/r/65123/diff/3-4/
Testing
-------
create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
File Attachments
----------------
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch
Thanks,
Yao Li
Re: Review Request 65123: ATLAS-2298 - Review of OCF Database
Connector
Posted by Yao Li <be...@126.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/
-----------------------------------------------------------
(Updated Jan. 29, 2018, 3:40 p.m.)
Review request for atlas and Mandy Chessell.
Changes
-------
update the patch based on the reviews
Summary (updated)
-----------------
ATLAS-2298 - Review of OCF Database Connector
Repository: atlas
Description (updated)
-------
The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data.
Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
Diffs (updated)
-----
ocfdb/README.md PRE-CREATION
ocfdb/pom.xml PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBase.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotation.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotations.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyIteratorBase.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certification.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certifications.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classification.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classifications.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comment.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/CommentType.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comments.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connection.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connections.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementOrigin.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementType.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifier.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifiers.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReference.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReferences.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Feedback.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTags.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/License.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Licenses.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Like.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Likes.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Lineage.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Location.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Locations.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meaning.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meanings.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Note.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLog.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLogs.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Notes.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PagingIterator.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PrimitiveSchemaElement.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/PropertyBase.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Rating.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Ratings.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Referenceable.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAsset.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssetProperties.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssets.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReference.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReferences.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaType.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaUsage.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/Schema.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttributes.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaElement.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQueries.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQuery.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLink.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLinks.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaType.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/StarRating.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocf/properties/VirtualConnection.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDataProvider.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnection.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnector.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnectorProviderBase.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnector.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnectorProvider.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/DatabaseAccessCheckedException.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseCheckedExceptionBase.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorErrorCode.java PRE-CREATION
ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorRuntimeException.java PRE-CREATION
ocfdb/src/test/java/AB.java PRE-CREATION
ocfdb/src/test/java/Parent.java PRE-CREATION
ocfdb/src/test/java/testPagingIterator.java PRE-CREATION
Diff: https://reviews.apache.org/r/65123/diff/3/
Changes: https://reviews.apache.org/r/65123/diff/2-3/
Testing
-------
create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
File Attachments (updated)
----------------
ATLAS-2298-update-patch-based-on-reviews.patch
https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch
Thanks,
Yao Li
Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector
for Gaian
Posted by Yao Li <be...@126.com>.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/JDBCConnection.java
> > Lines 10 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941456#file1941456line10>
> >
> > OMRSConnection --> JDBCConnection
yes fixed, and also change the class name to OCFDatabaseConnection
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/JDBCConnection.java
> > Lines 21 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941456#file1941456line21>
> >
> > OMRSConnection --> JDBCConnection
yes fixed, and also change the class name to OCFDatabaseConnection
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/JDBCConnection.java
> > Lines 84 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941456#file1941456line84>
> >
> > Is it deliberate that we are testing the super-class attribute?
will fix this during the workshop. and this part also show in OMRS Connection.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/JDBCConnection.java
> > Lines 90 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941456#file1941456line90>
> >
> > Do we need to go to the super class here?
will fix this during the workshop and this part also show in OMRS Connection
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/JDBCConnectorBase.java
> > Lines 32 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941458#file1941458line32>
> >
> > Can the connect() be called multiple times to generate multiple connections? e.g. with a call to one of the setters between calls to connect(). I'm just wondering how we'd intend to use the 'conn' member if that is the case.
the initial design is every time the application wants to execute the query, this conn will be get again.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/JDBCConnectorProviderBase.java
> > Lines 8 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941459#file1941459line8>
> >
> > Should this be an abstract class to force the subclass to implement this?
yes, fixed this, thanks
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 21 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line21>
> >
> > I would think that host, port, database name, user and password should all be configurable.
do you mean there should be a seperate configuration file?
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 51 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line51>
> >
> > Beware literal forward-slash characters - they may not work on Windows. However, this is not always the case - things like the java classloaders take the forward-slash path separators even on Windows, so it depends on the specific sub-system we are providing the path/URI to.
> > It seems that REST URIs and resource file paths (which we will pass to classloaders) are OK with '/' separators. I am not sure what will work for the DB connection.
i tested on windows and it works properly. I will keep this issue in mind.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 63 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line63>
> >
> > You could use the string utils isEmpty() method - or a similar method - to test for null-ness or emptiness.
use isEmpty() now and in apache commons it offers isNullorEmpty() for String. this is also used by Manndy's code, we will talk about this during the workshop
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 82 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line82>
> >
> > Nigel needs to be configurable :-)
haha, fixed. changed it to normal parameter "userId"
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 87 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line87>
> >
> > We shouldn't include System.out.println, but should use log4j (actually this is a very general comment - lots of logging would be a really nice addition to this connector generally).
deleted this and add log4j for logging.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 130 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line130>
> >
> > I think you already renamed ConnectionCheckedException elsewhere? May want to update the comment
rename the class and updated the comment.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 137 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line137>
> >
> > Should we be throwing the JDBC specific exception class here?
here if we receive the SQL exception, we will throw our own ocf database exception. I want to wrap it to our own exception.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 186 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line186>
> >
> > There are ways to dynamically get the name of the enclosing method - but they may have drawbacks (e.g. creation of inner class or additional runtime object) - but someone much more expert than me may have a suggestion :-)
will talk about this through the workshop. thanks
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnectorProvider.java
> > Lines 16 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941461#file1941461line16>
> >
> > Should this be extending the JDBC specific base class?
the old nameing here is very confusing. for new patch I changed all names to OCFDatabaseXXXX, here this class changed to GaianOCFConnectorProvider.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/ffdc/ConnectionCheckedException.java
> > Lines 10 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941462#file1941462line10>
> >
> > I thought I saw an earlier review comment where it suggested renaming this to JDBCxxx. I might have imagined it, but it does seem that it would be better to make this class JDBC specific.
the old nameing here is very confusing. for new patch I changed all names to OCFDatabaseXXXX. the most import concept here is it is an OCF complaint connector.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/ffdc/ExecutionCheckedException.java
> > Lines 14 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941463#file1941463line14>
> >
> > Should this class also be called something JDBC specific?
the old nameing here is very confusing. for new patch I changed all names to OCFDatabaseXXXX. this module is an OCF connector but expecially for database.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/pom.xml
> > Lines 6 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941467#file1941467line6>
> >
> > There should be a parent POM reference, which (depending on how nested this module is) should look something like this:
> > <parent>
> > <artifactId>apache-atlas</artifactId>
> > <groupId>org.apache.atlas</groupId>
> > <version>1.0.0-SNAPSHOT</version>
> > </parent>
> > But check whether Mandy wants this nested under
> > <artifactId>om-fwk-ocf</artifactId>
will fix this during the workshop on 30-01. thanks!
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/pom.xml
> > Lines 7 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941467#file1941467line7>
> >
> > The group should probably be "org.apache"
yes, fixed.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/pom.xml
> > Lines 8 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941467#file1941467line8>
> >
> > I suspect artifactId should be something like
> > <artifactId>atlas-ocf-jdbc</artifactId>
> > depending on nesting of modules.
change it to:
<parent>
<artifactId>apache-atlas</artifactId>
<groupId>org.apache.atlas</groupId>
<version>1.0.0-SNAPSHOT</version>
</parent>
<artifactId>atlas-ocf-database</artifactId>
<name>OCF Database Connector</name>
<description>OCF Database Connector provides the interfaces and implementation of Connectors for retrieving data from databases.</description>
<packaging>jar</packaging>
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/pom.xml
> > Lines 9 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941467#file1941467line9>
> >
> > I think version should be 1.0.0-SNAPSHOT
yes, fixed, thanks
- Yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/#review195710
-----------------------------------------------------------
On Jan. 18, 2018, 10:09 a.m., Yao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65123/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 10:09 a.m.)
>
>
> Review request for atlas and Mandy Chessell.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> this is the JDBC Connector code for Connector to Gaian. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
>
>
> Diffs
> -----
>
> jdbc/README.md PRE-CREATION
> jdbc/connectors/JDBCConnection.java PRE-CREATION
> jdbc/connectors/JDBCConnector.java PRE-CREATION
> jdbc/connectors/JDBCConnectorBase.java PRE-CREATION
> jdbc/connectors/JDBCConnectorProviderBase.java PRE-CREATION
> jdbc/connectors/gaian/GaianJDBCConnector.java PRE-CREATION
> jdbc/connectors/gaian/GaianJDBCConnectorProvider.java PRE-CREATION
> jdbc/ffdc/ConnectionCheckedException.java PRE-CREATION
> jdbc/ffdc/ExecutionCheckedException.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorCheckedExceptionBase.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorErrorCode.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorRuntimeException.java PRE-CREATION
> jdbc/pom.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65123/diff/2/
>
>
> Testing
> -------
>
> create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
>
>
> Thanks,
>
> Yao Li
>
>
Re: Review Request 65123: ATLAS-2298 - Review of OCF Database
Connector
Posted by Yao Li <be...@126.com>.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 21 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line21>
> >
> > I would think that host, port, database name, user and password should all be configurable.
>
> Yao Li wrote:
> do you mean there should be a seperate configuration file?
already put all these settings into a properties file
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 51 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line51>
> >
> > Beware literal forward-slash characters - they may not work on Windows. However, this is not always the case - things like the java classloaders take the forward-slash path separators even on Windows, so it depends on the specific sub-system we are providing the path/URI to.
> > It seems that REST URIs and resource file paths (which we will pass to classloaders) are OK with '/' separators. I am not sure what will work for the DB connection.
>
> Yao Li wrote:
> i tested on windows and it works properly. I will keep this issue in mind.
it is only used to form a jdbc url, will to send to Gaian.so it should not be a problem.
- Yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/#review195710
-----------------------------------------------------------
On Jan. 31, 2018, 12:08 p.m., Yao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65123/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 12:08 p.m.)
>
>
> Review request for atlas and Mandy Chessell.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Because some issues with uploading the patch, the new review will be shown on [https://reviews.apache.org/r/65435/](https://reviews.apache.org/r/65435/), and this page will not be updated anymore.
>
> The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data.
> Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
>
>
> Diffs
> -----
>
> ocfdb/README.md
> ocfdb/pom.xml
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDataProvider.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnection.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnector.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnectorProviderBase.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnector.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnectorProvider.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/DatabaseAccessCheckedException.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseCheckedExceptionBase.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorErrorCode.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorRuntimeException.java
>
>
> Diff: https://reviews.apache.org/r/65123/diff/5/
>
>
> Testing
> -------
>
> create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
>
>
> File Attachments
> ----------------
>
> ATLAS-2298-update-patch-based-on-reviews.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch
> ATLAS-2298-update-patch-based-on-reviews.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/425dded1-e882-4f5b-902b-acea0acec74d__ATLAS-2298-update-patch-based-on-reviews.patch
> ATLAS-2298-update-the-patch-29-1.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/4c6d596c-dd34-4cf6-8fe0-33258e9965a6__ATLAS-2298-update-the-patch-29-1.patch
> ATLAS-2298-update-the-patch-29-1.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/db1c4085-05c8-41d7-9367-274e5dadfa1c__ATLAS-2298-update-the-patch-29-1.patch
> ATLAS-2298-30-Jan-review-verision.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/30/b4282020-0ef5-41bc-82d2-a0e0d64d592b__ATLAS-2298-30-Jan-review-verision.patch
>
>
> Thanks,
>
> Yao Li
>
>
Re: Review Request 65123: ATLAS-2298 - Review of OCF Database
Connector
Posted by Yao Li <be...@126.com>.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/JDBCConnection.java
> > Lines 84 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941456#file1941456line84>
> >
> > Is it deliberate that we are testing the super-class attribute?
>
> Yao Li wrote:
> will fix this during the workshop. and this part also show in OMRS Connection.
this function is deleted now and we can get the securedProperties from OCFDatabaseConnector. thanks.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/JDBCConnection.java
> > Lines 90 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941456#file1941456line90>
> >
> > Do we need to go to the super class here?
>
> Yao Li wrote:
> will fix this during the workshop and this part also show in OMRS Connection
this function is deleted now and we can get the securedProperties from OCFDatabaseConnector. thanks.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/JDBCConnectorBase.java
> > Lines 32 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941458#file1941458line32>
> >
> > Can the connect() be called multiple times to generate multiple connections? e.g. with a call to one of the setters between calls to connect(). I'm just wondering how we'd intend to use the 'conn' member if that is the case.
>
> Yao Li wrote:
> the initial design is every time the application wants to execute the query, this conn will be get again.
I will keep this one and discuss this with the front-end, how exactly will it use this.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 63 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line63>
> >
> > You could use the string utils isEmpty() method - or a similar method - to test for null-ness or emptiness.
>
> Yao Li wrote:
> use isEmpty() now and in apache commons it offers isNullorEmpty() for String. this is also used by Manndy's code, we will talk about this during the workshop
we change the code to if("".equals(query))
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 186 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line186>
> >
> > There are ways to dynamically get the name of the enclosing method - but they may have drawbacks (e.g. creation of inner class or additional runtime object) - but someone much more expert than me may have a suggestion :-)
>
> Yao Li wrote:
> will talk about this through the workshop. thanks
because Atlas is trying to get rid of the stack traces, for now we will use simple method name. but maybe in the Unit Test to test whether the methond name is correct.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/pom.xml
> > Lines 6 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941467#file1941467line6>
> >
> > There should be a parent POM reference, which (depending on how nested this module is) should look something like this:
> > <parent>
> > <artifactId>apache-atlas</artifactId>
> > <groupId>org.apache.atlas</groupId>
> > <version>1.0.0-SNAPSHOT</version>
> > </parent>
> > But check whether Mandy wants this nested under
> > <artifactId>om-fwk-ocf</artifactId>
>
> Yao Li wrote:
> will fix this during the workshop on 30-01. thanks!
this will be an seperate module for now. Maybe later will be added toghther with other connectors.but in the pom.xml we will add ocf as a denpendency
- Yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/#review195710
-----------------------------------------------------------
On Jan. 29, 2018, 3:58 p.m., Yao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65123/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 3:58 p.m.)
>
>
> Review request for atlas and Mandy Chessell.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data.
> Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
>
>
> Diffs
> -----
>
> ocfdb/README.md
> ocfdb/pom.xml
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDataProvider.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnection.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnector.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnectorProviderBase.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnector.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnectorProvider.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/DatabaseAccessCheckedException.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseCheckedExceptionBase.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorErrorCode.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorRuntimeException.java
>
>
> Diff: https://reviews.apache.org/r/65123/diff/5/
>
>
> Testing
> -------
>
> create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
>
>
> File Attachments
> ----------------
>
> ATLAS-2298-update-patch-based-on-reviews.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch
> ATLAS-2298-update-patch-based-on-reviews.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/425dded1-e882-4f5b-902b-acea0acec74d__ATLAS-2298-update-patch-based-on-reviews.patch
> ATLAS-2298-update-the-patch-29-1.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/4c6d596c-dd34-4cf6-8fe0-33258e9965a6__ATLAS-2298-update-the-patch-29-1.patch
> ATLAS-2298-update-the-patch-29-1.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/db1c4085-05c8-41d7-9367-274e5dadfa1c__ATLAS-2298-update-the-patch-29-1.patch
>
>
> Thanks,
>
> Yao Li
>
>
Re: Review Request 65123: ATLAS-2298 - Review of OCF Database
Connector
Posted by Yao Li <be...@126.com>.
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote:
> > jdbc/connectors/gaian/GaianJDBCConnector.java
> > Lines 186 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941460#file1941460line186>
> >
> > There are ways to dynamically get the name of the enclosing method - but they may have drawbacks (e.g. creation of inner class or additional runtime object) - but someone much more expert than me may have a suggestion :-)
>
> Yao Li wrote:
> will talk about this through the workshop. thanks
>
> Yao Li wrote:
> because Atlas is trying to get rid of the stack traces, for now we will use simple method name. but maybe in the Unit Test to test whether the methond name is correct.
also add final to the string
- Yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/#review195710
-----------------------------------------------------------
On Jan. 29, 2018, 3:58 p.m., Yao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65123/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 3:58 p.m.)
>
>
> Review request for atlas and Mandy Chessell.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data.
> Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
>
>
> Diffs
> -----
>
> ocfdb/README.md
> ocfdb/pom.xml
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDataProvider.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnection.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnector.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnectorProviderBase.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnector.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnectorProvider.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/DatabaseAccessCheckedException.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseCheckedExceptionBase.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorErrorCode.java
> ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorRuntimeException.java
>
>
> Diff: https://reviews.apache.org/r/65123/diff/5/
>
>
> Testing
> -------
>
> create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
>
>
> File Attachments
> ----------------
>
> ATLAS-2298-update-patch-based-on-reviews.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch
> ATLAS-2298-update-patch-based-on-reviews.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/425dded1-e882-4f5b-902b-acea0acec74d__ATLAS-2298-update-patch-based-on-reviews.patch
> ATLAS-2298-update-the-patch-29-1.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/4c6d596c-dd34-4cf6-8fe0-33258e9965a6__ATLAS-2298-update-the-patch-29-1.patch
> ATLAS-2298-update-the-patch-29-1.patch
> https://reviews.apache.org/media/uploaded/files/2018/01/29/db1c4085-05c8-41d7-9367-274e5dadfa1c__ATLAS-2298-update-the-patch-29-1.patch
>
>
> Thanks,
>
> Yao Li
>
>
Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector
for Gaian
Posted by Graham Wallis <gr...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/#review195710
-----------------------------------------------------------
jdbc/connectors/JDBCConnection.java
Lines 10 (patched)
<https://reviews.apache.org/r/65123/#comment274976>
OMRSConnection --> JDBCConnection
jdbc/connectors/JDBCConnection.java
Lines 21 (patched)
<https://reviews.apache.org/r/65123/#comment274977>
OMRSConnection --> JDBCConnection
jdbc/connectors/JDBCConnection.java
Lines 84 (patched)
<https://reviews.apache.org/r/65123/#comment274978>
Is it deliberate that we are testing the super-class attribute?
jdbc/connectors/JDBCConnection.java
Lines 90 (patched)
<https://reviews.apache.org/r/65123/#comment274979>
Do we need to go to the super class here?
jdbc/connectors/JDBCConnectorBase.java
Lines 32 (patched)
<https://reviews.apache.org/r/65123/#comment274981>
Can the connect() be called multiple times to generate multiple connections? e.g. with a call to one of the setters between calls to connect(). I'm just wondering how we'd intend to use the 'conn' member if that is the case.
jdbc/connectors/JDBCConnectorProviderBase.java
Lines 8 (patched)
<https://reviews.apache.org/r/65123/#comment274982>
Should this be an abstract class to force the subclass to implement this?
jdbc/connectors/gaian/GaianJDBCConnector.java
Lines 21 (patched)
<https://reviews.apache.org/r/65123/#comment274983>
I would think that host, port, database name, user and password should all be configurable.
jdbc/connectors/gaian/GaianJDBCConnector.java
Lines 51 (patched)
<https://reviews.apache.org/r/65123/#comment274985>
Beware literal forward-slash characters - they may not work on Windows. However, this is not always the case - things like the java classloaders take the forward-slash path separators even on Windows, so it depends on the specific sub-system we are providing the path/URI to.
It seems that REST URIs and resource file paths (which we will pass to classloaders) are OK with '/' separators. I am not sure what will work for the DB connection.
jdbc/connectors/gaian/GaianJDBCConnector.java
Lines 63 (patched)
<https://reviews.apache.org/r/65123/#comment274986>
You could use the string utils isEmpty() method - or a similar method - to test for null-ness or emptiness.
jdbc/connectors/gaian/GaianJDBCConnector.java
Lines 82 (patched)
<https://reviews.apache.org/r/65123/#comment274984>
Nigel needs to be configurable :-)
jdbc/connectors/gaian/GaianJDBCConnector.java
Lines 87 (patched)
<https://reviews.apache.org/r/65123/#comment274987>
We shouldn't include System.out.println, but should use log4j (actually this is a very general comment - lots of logging would be a really nice addition to this connector generally).
jdbc/connectors/gaian/GaianJDBCConnector.java
Lines 130 (patched)
<https://reviews.apache.org/r/65123/#comment274988>
I think you already renamed ConnectionCheckedException elsewhere? May want to update the comment
jdbc/connectors/gaian/GaianJDBCConnector.java
Lines 137 (patched)
<https://reviews.apache.org/r/65123/#comment274989>
Should we be throwing the JDBC specific exception class here?
jdbc/connectors/gaian/GaianJDBCConnector.java
Lines 186 (patched)
<https://reviews.apache.org/r/65123/#comment274991>
There are ways to dynamically get the name of the enclosing method - but they may have drawbacks (e.g. creation of inner class or additional runtime object) - but someone much more expert than me may have a suggestion :-)
jdbc/connectors/gaian/GaianJDBCConnectorProvider.java
Lines 16 (patched)
<https://reviews.apache.org/r/65123/#comment275002>
Should this be extending the JDBC specific base class?
jdbc/ffdc/ConnectionCheckedException.java
Lines 10 (patched)
<https://reviews.apache.org/r/65123/#comment275003>
I thought I saw an earlier review comment where it suggested renaming this to JDBCxxx. I might have imagined it, but it does seem that it would be better to make this class JDBC specific.
jdbc/ffdc/ExecutionCheckedException.java
Lines 14 (patched)
<https://reviews.apache.org/r/65123/#comment275004>
Should this class also be called something JDBC specific?
jdbc/pom.xml
Lines 6 (patched)
<https://reviews.apache.org/r/65123/#comment274974>
There should be a parent POM reference, which (depending on how nested this module is) should look something like this:
<parent>
<artifactId>apache-atlas</artifactId>
<groupId>org.apache.atlas</groupId>
<version>1.0.0-SNAPSHOT</version>
</parent>
But check whether Mandy wants this nested under
<artifactId>om-fwk-ocf</artifactId>
jdbc/pom.xml
Lines 7 (patched)
<https://reviews.apache.org/r/65123/#comment274973>
The group should probably be "org.apache"
jdbc/pom.xml
Lines 8 (patched)
<https://reviews.apache.org/r/65123/#comment274975>
I suspect artifactId should be something like
<artifactId>atlas-ocf-jdbc</artifactId>
depending on nesting of modules.
jdbc/pom.xml
Lines 9 (patched)
<https://reviews.apache.org/r/65123/#comment274980>
I think version should be 1.0.0-SNAPSHOT
- Graham Wallis
On Jan. 18, 2018, 10:09 a.m., Yao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65123/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 10:09 a.m.)
>
>
> Review request for atlas and Mandy Chessell.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> this is the JDBC Connector code for Connector to Gaian. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
>
>
> Diffs
> -----
>
> jdbc/README.md PRE-CREATION
> jdbc/connectors/JDBCConnection.java PRE-CREATION
> jdbc/connectors/JDBCConnector.java PRE-CREATION
> jdbc/connectors/JDBCConnectorBase.java PRE-CREATION
> jdbc/connectors/JDBCConnectorProviderBase.java PRE-CREATION
> jdbc/connectors/gaian/GaianJDBCConnector.java PRE-CREATION
> jdbc/connectors/gaian/GaianJDBCConnectorProvider.java PRE-CREATION
> jdbc/ffdc/ConnectionCheckedException.java PRE-CREATION
> jdbc/ffdc/ExecutionCheckedException.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorCheckedExceptionBase.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorErrorCode.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorRuntimeException.java PRE-CREATION
> jdbc/pom.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65123/diff/2/
>
>
> Testing
> -------
>
> create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
>
>
> Thanks,
>
> Yao Li
>
>
Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector
for Gaian
Posted by Yao Li <be...@126.com>.
> On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote:
> > jdbc/README.md
> > Lines 8 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941455#file1941455line8>
> >
> > should be "... subclass of an OCF Connector"?
yes, fixed, thanks
> On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote:
> > jdbc/README.md
> > Lines 9 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941455#file1941455line9>
> >
> > databases
yes, fixed, thanks
> On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote:
> > jdbc/README.md
> > Lines 11 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941455#file1941455line11>
> >
> > Need to exmplain the relationship between this JDBC Connector and the standard JDBC Connector that people are familiar with.
change the name to OCF Database Connector, it will be more clear for people to know it is an OCF and for database connection
> On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote:
> > jdbc/README.md
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941455#file1941455line17>
> >
> > Capitial letter at the start of a sentence. Also need more context. For example, what is Gaian?
add introduction to Gaian and purpose for the GaianJDBCConnector
> On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote:
> > jdbc/connectors/JDBCConnection.java
> > Lines 8 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941456#file1941456line8>
> >
> > This class name is going to be confusing to people who are familiar with the JDBC standard. I think It should have a different name. Eg OCFDatabaseConnection
yes, it was confusing when i wrote the code. and now the whole module called OCF Database Connector. this class will name as OCFDatabaseConnection
> On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote:
> > jdbc/connectors/JDBCConnector.java
> > Lines 10 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941457#file1941457line10>
> >
> > The name of this class is confusing because it is not a JDBCConnector. JDBC is a standard and this connector does not implement the standard. So I would suggest naming it something like OCFDatabaseConnector.
yes, agree with you. now the whole module called OCF Database Connector. this class will name as OCFDatabaseConnector
> On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote:
> > jdbc/ffdc/ConnectionCheckedException.java
> > Lines 10 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941462#file1941462line10>
> >
> > This is confusing to create a new exception that has the same name as one of the OCF exceptions. It should have a different name.
change it to
DatabaseAccessCheckedException extends OCFDatabaseCheckedExceptionBase
> On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote:
> > jdbc/ffdc/ExecutionCheckedException.java
> > Lines 14 (patched)
> > <https://reviews.apache.org/r/65123/diff/2/?file=1941463#file1941463line14>
> >
> > Should this extend JDBCConnectorCheckedExceptionBase?
deleted this one and directly use ConnectorCheckedException from ocf module
- Yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/#review195714
-----------------------------------------------------------
On Jan. 18, 2018, 10:09 a.m., Yao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65123/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 10:09 a.m.)
>
>
> Review request for atlas and Mandy Chessell.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> this is the JDBC Connector code for Connector to Gaian. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
>
>
> Diffs
> -----
>
> jdbc/README.md PRE-CREATION
> jdbc/connectors/JDBCConnection.java PRE-CREATION
> jdbc/connectors/JDBCConnector.java PRE-CREATION
> jdbc/connectors/JDBCConnectorBase.java PRE-CREATION
> jdbc/connectors/JDBCConnectorProviderBase.java PRE-CREATION
> jdbc/connectors/gaian/GaianJDBCConnector.java PRE-CREATION
> jdbc/connectors/gaian/GaianJDBCConnectorProvider.java PRE-CREATION
> jdbc/ffdc/ConnectionCheckedException.java PRE-CREATION
> jdbc/ffdc/ExecutionCheckedException.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorCheckedExceptionBase.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorErrorCode.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorRuntimeException.java PRE-CREATION
> jdbc/pom.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65123/diff/2/
>
>
> Testing
> -------
>
> create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
>
>
> Thanks,
>
> Yao Li
>
>
Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector
for Gaian
Posted by Mandy Chessell <ma...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/#review195714
-----------------------------------------------------------
jdbc/README.md
Lines 8 (patched)
<https://reviews.apache.org/r/65123/#comment274993>
should be "... subclass of an OCF Connector"?
jdbc/README.md
Lines 9 (patched)
<https://reviews.apache.org/r/65123/#comment274995>
databases
jdbc/README.md
Lines 11 (patched)
<https://reviews.apache.org/r/65123/#comment274996>
Need to exmplain the relationship between this JDBC Connector and the standard JDBC Connector that people are familiar with.
jdbc/README.md
Lines 17 (patched)
<https://reviews.apache.org/r/65123/#comment274994>
Capitial letter at the start of a sentence. Also need more context. For example, what is Gaian?
jdbc/connectors/JDBCConnection.java
Lines 8 (patched)
<https://reviews.apache.org/r/65123/#comment274997>
This class name is going to be confusing to people who are familiar with the JDBC standard. I think It should have a different name. Eg OCFDatabaseConnection
jdbc/connectors/JDBCConnector.java
Lines 10 (patched)
<https://reviews.apache.org/r/65123/#comment274998>
The name of this class is confusing because it is not a JDBCConnector. JDBC is a standard and this connector does not implement the standard. So I would suggest naming it something like OCFDatabaseConnector.
jdbc/ffdc/ConnectionCheckedException.java
Lines 10 (patched)
<https://reviews.apache.org/r/65123/#comment274999>
This is confusing to create a new exception that has the same name as one of the OCF exceptions. It should have a different name.
jdbc/ffdc/ExecutionCheckedException.java
Lines 14 (patched)
<https://reviews.apache.org/r/65123/#comment275001>
Should this extend JDBCConnectorCheckedExceptionBase?
- Mandy Chessell
On Jan. 18, 2018, 10:09 a.m., Yao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65123/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 10:09 a.m.)
>
>
> Review request for atlas and Mandy Chessell.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> this is the JDBC Connector code for Connector to Gaian. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
>
>
> Diffs
> -----
>
> jdbc/README.md PRE-CREATION
> jdbc/connectors/JDBCConnection.java PRE-CREATION
> jdbc/connectors/JDBCConnector.java PRE-CREATION
> jdbc/connectors/JDBCConnectorBase.java PRE-CREATION
> jdbc/connectors/JDBCConnectorProviderBase.java PRE-CREATION
> jdbc/connectors/gaian/GaianJDBCConnector.java PRE-CREATION
> jdbc/connectors/gaian/GaianJDBCConnectorProvider.java PRE-CREATION
> jdbc/ffdc/ConnectionCheckedException.java PRE-CREATION
> jdbc/ffdc/ExecutionCheckedException.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorCheckedExceptionBase.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorErrorCode.java PRE-CREATION
> jdbc/ffdc/JDBCConnectorRuntimeException.java PRE-CREATION
> jdbc/pom.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65123/diff/2/
>
>
> Testing
> -------
>
> create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
>
>
> Thanks,
>
> Yao Li
>
>
Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector
for Gaian
Posted by Yao Li <be...@126.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65123/
-----------------------------------------------------------
(Updated Jan. 18, 2018, 10:09 a.m.)
Review request for atlas and Mandy Chessell.
Changes
-------
update the code
Repository: atlas
Description
-------
this is the JDBC Connector code for Connector to Gaian. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
Diffs (updated)
-----
jdbc/README.md PRE-CREATION
jdbc/connectors/JDBCConnection.java PRE-CREATION
jdbc/connectors/JDBCConnector.java PRE-CREATION
jdbc/connectors/JDBCConnectorBase.java PRE-CREATION
jdbc/connectors/JDBCConnectorProviderBase.java PRE-CREATION
jdbc/connectors/gaian/GaianJDBCConnector.java PRE-CREATION
jdbc/connectors/gaian/GaianJDBCConnectorProvider.java PRE-CREATION
jdbc/ffdc/ConnectionCheckedException.java PRE-CREATION
jdbc/ffdc/ExecutionCheckedException.java PRE-CREATION
jdbc/ffdc/JDBCConnectorCheckedExceptionBase.java PRE-CREATION
jdbc/ffdc/JDBCConnectorErrorCode.java PRE-CREATION
jdbc/ffdc/JDBCConnectorRuntimeException.java PRE-CREATION
jdbc/pom.xml PRE-CREATION
Diff: https://reviews.apache.org/r/65123/diff/2/
Changes: https://reviews.apache.org/r/65123/diff/1-2/
Testing
-------
create an instance of the Connector and use getData() function. Gaian has to be set up in advance.
Thanks,
Yao Li