[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27643: [SPARK-30886][SQL] Deprecate two-parameter TRIM/LTRIM/RTRIM functions

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #27643: [SPARK-30886][SQL] Deprecate two-parameter TRIM/LTRIM/RTRIM functions
URL: https://github.com/apache/spark/pull/27643#discussion_r388702995
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
 ##########
 @@ -768,4 +769,54 @@ class AnalysisSuite extends AnalysisTest with Matchers {
     assert(message.startsWith(s"Max iterations ($maxIterations) reached for batch Resolution, " +
       s"please set '${SQLConf.ANALYZER_MAX_ITERATIONS.key}' to a larger value."))
   }
+
+  test("SPARK-30886 Deprecate two-parameter TRIM/LTRIM/RTRIM") {
+    Seq("trim", "ltrim", "rtrim").foreach { f =>
+      val logAppender = new LogAppender("deprecated two-parameter TRIM/LTRIM/RTRIM functions")
+      def check(count: Int, message: String): Unit = {
 
 Review comment:
   You're right. Let me fix that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org