[GitHub] [spark] srielau commented on a diff in pull request #36635: [SPARK-39255][SQL] Improve error messages

[GitBox <gi...@apache.org>]

srielau commented on code in PR #36635:
URL: https://github.com/apache/spark/pull/36635#discussion_r879757479


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -48,13 +48,13 @@
   "FAILED_EXECUTE_UDF" : {
     "message" : [ "Failed to execute user defined function (<functionName>: (<signature>) => <result>)" ]
   },
+  "FAILED_PERMISSION_RESET_ORIGINAL" : {

Review Comment:
   Yeah, it's hard to come up with a pattern that really works.
   Some thought:
   
   - The error class is typically followed by the message. No need for a sentence.. That's what the message does.
   - Short is beautiful
   - Try to avoid stating that an error is an error in the name.. provides no new information. It's an error class! ;-)
   
   How about 
   RESET_PERMISSION_TO_ORIGINAL
   (again we KNOW it's failed)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org