You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mintsweet (via GitHub)" <gi...@apache.org> on 2023/02/15 07:54:55 UTC

[GitHub] [incubator-devlake] mintsweet opened a new pull request, #4423: fix(config-ui): somethings for connections

mintsweet opened a new pull request, #4423:
URL: https://github.com/apache/incubator-devlake/pull/4423

   ### Summary
   1. fixed github token valid error.
   2. remove old connection fields from plugin base.
   3. integrate plugin config type.
   4. add sort for plugin config.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] likyh commented on pull request #4423: fix(config-ui): somethings for connections

Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh commented on PR #4423:
URL: https://github.com/apache/incubator-devlake/pull/4423#issuecomment-1432375055

   which is valid in github token?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] mintsweet commented on pull request #4423: fix(config-ui): somethings for connections

Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on PR #4423:
URL: https://github.com/apache/incubator-devlake/pull/4423#issuecomment-1432678682

   > > > which is valid in github token?
   > > 
   > > 
   > > [fix(config-ui): github token valid error](https://github.com/apache/incubator-devlake/pull/4423/commits/81cdfe5efef1c7d85e75859b3506c11d50ac6eaf)
   > 
   > Github test has never succeeded after prev refactor?
   
   tests that only affect the input.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] likyh commented on pull request #4423: fix(config-ui): somethings for connections

Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh commented on PR #4423:
URL: https://github.com/apache/incubator-devlake/pull/4423#issuecomment-1432409960

   > > which is valid in github token?
   > 
   > [fix(config-ui): github token valid error](https://github.com/apache/incubator-devlake/pull/4423/commits/81cdfe5efef1c7d85e75859b3506c11d50ac6eaf)
   
   Github test has never succeeded after prev refactor?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] likyh merged pull request #4423: fix(config-ui): somethings for connections

Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh merged PR #4423:
URL: https://github.com/apache/incubator-devlake/pull/4423


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] mintsweet commented on pull request #4423: fix(config-ui): somethings for connections

Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on PR #4423:
URL: https://github.com/apache/incubator-devlake/pull/4423#issuecomment-1432396766

   > which is valid in github token?
   
   [fix(config-ui): github token valid error](https://github.com/apache/incubator-devlake/pull/4423/commits/81cdfe5efef1c7d85e75859b3506c11d50ac6eaf)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org