[GitHub] [pulsar] lhotari commented on a change in pull request #13810: Remove --illegal-access errors resulting from Google Guice (upgrade to 5.0.1 and JClouds to 2.4.0)

[GitBox <gi...@apache.org>]

lhotari commented on a change in pull request #13810:
URL: https://github.com/apache/pulsar/pull/13810#discussion_r807002025



##########
File path: pulsar-io/data-generator/pom.xml
##########
@@ -49,6 +49,18 @@
             <artifactId>jfairy</artifactId>
             <version>0.5.9</version>
         </dependency>
+        <dependency>
+            <groupId>com.google.inject</groupId>
+            <artifactId>guice</artifactId>
+            <version>${guice.version}</version>
+            <scope>provided</scope>
+        </dependency>
+        <dependency>
+            <groupId>com.google.inject.extensions</groupId>
+            <artifactId>guice-assistedinject</artifactId>
+            <version>${guice.version}</version>
+            <scope>provided</scope>
+        </dependency>

Review comment:
       Would it be useful to add these to the root parent pom.xml's dependencyManagement / dependencies so that the correct versions get picked in all locations?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org