You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/22 18:13:13 UTC
[GitHub] [spark] linzebing opened a new pull request #31931: [SPARK-34706] Code-gen broadcast nested loop join (left outer/right outer)
linzebing opened a new pull request #31931:
URL: https://github.com/apache/spark/pull/31931
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR is to add code-gen support for left outer (build right) and right outer (build left). Reference: `BroadcastNestedLoopJoinExec.codegenInner()` and `BroadcastNestedLoopJoinExec.outerJoin()`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Improve query CPU performance.
Tested with a simple query:
```scala
val N = 20 << 20
val M = 1 << 4
val dim = broadcast(spark.range(M).selectExpr("id as k2"))
codegenBenchmark("left outer broadcast nested loop join", N) {
val df = spark.range(N).selectExpr(s"id as k1").join(
dim, col("k1") + 1 <= col("k2"), "left_outer")
assert(df.queryExecution.sparkPlan.find(
_.isInstanceOf[BroadcastNestedLoopJoinExec]).isDefined)
df.noop()
}
```
Seeing 2x run time improvement:
```
Java HotSpot(TM) 64-Bit Server VM 1.8.0_181-b13 on Mac OS X 10.15.7
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
left outer broadcast nested loop join: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------------------
left outer broadcast nested loop join wholestage off 3024 3698 953 6.9 144.2 1.0X
left outer broadcast nested loop join wholestage on 1512 1659 172 13.9 72.1 2.0X
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Changed existing unit tests in `OuterJoinSuite` to cover codegen use cases.
Added unit test in WholeStageCodegenSuite.scala to make sure code-gen for broadcast nested loop join is taking effect, and test for multiple join case as well.
Example query:
```scala
val df1 = spark.range(4).select($"id".as("k1"))
val df2 = spark.range(3).select($"id".as("k2"))
df1.join(df2, $"k1" + 1 <= $"k2", "left_outer").explain("codegen")
```
Example generated code (`bnlj_doConsume_0` method):
```java
== Subtree 2 / 2 (maxMethodCodeSize:282; maxConstantPoolSize:210(0.32% used); numInnerClasses:0) ==
*(2) BroadcastNestedLoopJoin BuildRight, LeftOuter, ((k1#2L + 1) <= k2#6L)
:- *(2) Project [id#0L AS k1#2L]
: +- *(2) Range (0, 4, step=1, splits=16)
+- BroadcastExchange IdentityBroadcastMode, [id=#22]
+- *(1) Project [id#4L AS k2#6L]
+- *(1) Range (0, 3, step=1, splits=16)
Generated code:
/* 001 */ public Object generate(Object[] references) {
/* 002 */ return new GeneratedIteratorForCodegenStage2(references);
/* 003 */ }
/* 004 */
/* 005 */ // codegenStageId=2
/* 006 */ final class GeneratedIteratorForCodegenStage2 extends org.apache.spark.sql.execution.BufferedRowIterator {
/* 007 */ private Object[] references;
/* 008 */ private scala.collection.Iterator[] inputs;
/* 009 */ private boolean range_initRange_0;
/* 010 */ private long range_nextIndex_0;
/* 011 */ private TaskContext range_taskContext_0;
/* 012 */ private InputMetrics range_inputMetrics_0;
/* 013 */ private long range_batchEnd_0;
/* 014 */ private long range_numElementsTodo_0;
/* 015 */ private InternalRow[] bnlj_buildRowArray_0;
/* 016 */ private org.apache.spark.sql.catalyst.expressions.codegen.UnsafeRowWriter[] range_mutableStateArray_0 = new org.apache.spark.sql.catalyst.expressions.codegen.UnsafeRowWriter[4];
/* 017 */
/* 018 */ public GeneratedIteratorForCodegenStage2(Object[] references) {
/* 019 */ this.references = references;
/* 020 */ }
/* 021 */
/* 022 */ public void init(int index, scala.collection.Iterator[] inputs) {
/* 023 */ partitionIndex = index;
/* 024 */ this.inputs = inputs;
/* 025 */
/* 026 */ range_taskContext_0 = TaskContext.get();
/* 027 */ range_inputMetrics_0 = range_taskContext_0.taskMetrics().inputMetrics();
/* 028 */ range_mutableStateArray_0[0] = new org.apache.spark.sql.catalyst.expressions.codegen.UnsafeRowWriter(1, 0);
/* 029 */ range_mutableStateArray_0[1] = new org.apache.spark.sql.catalyst.expressions.codegen.UnsafeRowWriter(1, 0);
/* 030 */ range_mutableStateArray_0[2] = new org.apache.spark.sql.catalyst.expressions.codegen.UnsafeRowWriter(1, 0);
/* 031 */ bnlj_buildRowArray_0 = (InternalRow[]) ((org.apache.spark.broadcast.TorrentBroadcast) references[1] /* broadcastTerm */).value();
/* 032 */ range_mutableStateArray_0[3] = new org.apache.spark.sql.catalyst.expressions.codegen.UnsafeRowWriter(2, 0);
/* 033 */
/* 034 */ }
/* 035 */
/* 036 */ private void bnlj_doConsume_0(long bnlj_expr_0_0) throws java.io.IOException {
/* 037 */ boolean bnlj_foundMatch_0 = false;
/* 038 */ for (int bnlj_arrayIndex_0 = 0; bnlj_arrayIndex_0 < bnlj_buildRowArray_0.length; bnlj_arrayIndex_0++) {
/* 039 */ UnsafeRow bnlj_buildRow_0 = (UnsafeRow) bnlj_buildRowArray_0[bnlj_arrayIndex_0];
/* 040 */ boolean bnlj_shouldOutputRow_0 = false;
/* 041 */
/* 042 */ boolean bnlj_isNull_2 = true;
/* 043 */ long bnlj_value_2 = -1L;
/* 044 */ if (bnlj_buildRow_0 != null) {
/* 045 */ long bnlj_value_1 = bnlj_buildRow_0.getLong(0);
/* 046 */ bnlj_isNull_2 = false;
/* 047 */ bnlj_value_2 = bnlj_value_1;
/* 048 */ }
/* 049 */
/* 050 */ long bnlj_value_4 = -1L;
/* 051 */
/* 052 */ bnlj_value_4 = bnlj_expr_0_0 + 1L;
/* 053 */
/* 054 */ boolean bnlj_value_3 = false;
/* 055 */ bnlj_value_3 = bnlj_value_4 <= bnlj_value_2;
/* 056 */ if (!(false || !bnlj_value_3))
/* 057 */ {
/* 058 */ bnlj_shouldOutputRow_0 = true;
/* 059 */ bnlj_foundMatch_0 = true;
/* 060 */ }
/* 061 */ if (bnlj_arrayIndex_0 == bnlj_buildRowArray_0.length - 1 && !bnlj_foundMatch_0) {
/* 062 */ bnlj_buildRow_0 = null;
/* 063 */ bnlj_shouldOutputRow_0 = true;
/* 064 */ }
/* 065 */ if (bnlj_shouldOutputRow_0) {
/* 066 */ ((org.apache.spark.sql.execution.metric.SQLMetric) references[2] /* numOutputRows */).add(1);
/* 067 */
/* 068 */ boolean bnlj_isNull_9 = true;
/* 069 */ long bnlj_value_9 = -1L;
/* 070 */ if (bnlj_buildRow_0 != null) {
/* 071 */ long bnlj_value_8 = bnlj_buildRow_0.getLong(0);
/* 072 */ bnlj_isNull_9 = false;
/* 073 */ bnlj_value_9 = bnlj_value_8;
/* 074 */ }
/* 075 */ range_mutableStateArray_0[3].reset();
/* 076 */
/* 077 */ range_mutableStateArray_0[3].zeroOutNullBytes();
/* 078 */
/* 079 */ range_mutableStateArray_0[3].write(0, bnlj_expr_0_0);
/* 080 */
/* 081 */ if (bnlj_isNull_9) {
/* 082 */ range_mutableStateArray_0[3].setNullAt(1);
/* 083 */ } else {
/* 084 */ range_mutableStateArray_0[3].write(1, bnlj_value_9);
/* 085 */ }
/* 086 */ append((range_mutableStateArray_0[3].getRow()).copy());
/* 087 */
/* 088 */ }
/* 089 */ }
/* 090 */
/* 091 */ }
/* 092 */
/* 093 */ private void initRange(int idx) {
/* 094 */ java.math.BigInteger index = java.math.BigInteger.valueOf(idx);
/* 095 */ java.math.BigInteger numSlice = java.math.BigInteger.valueOf(16L);
/* 096 */ java.math.BigInteger numElement = java.math.BigInteger.valueOf(4L);
/* 097 */ java.math.BigInteger step = java.math.BigInteger.valueOf(1L);
/* 098 */ java.math.BigInteger start = java.math.BigInteger.valueOf(0L);
/* 099 */ long partitionEnd;
/* 100 */
/* 101 */ java.math.BigInteger st = index.multiply(numElement).divide(numSlice).multiply(step).add(start);
/* 102 */ if (st.compareTo(java.math.BigInteger.valueOf(Long.MAX_VALUE)) > 0) {
/* 103 */ range_nextIndex_0 = Long.MAX_VALUE;
/* 104 */ } else if (st.compareTo(java.math.BigInteger.valueOf(Long.MIN_VALUE)) < 0) {
/* 105 */ range_nextIndex_0 = Long.MIN_VALUE;
/* 106 */ } else {
/* 107 */ range_nextIndex_0 = st.longValue();
/* 108 */ }
/* 109 */ range_batchEnd_0 = range_nextIndex_0;
/* 110 */
/* 111 */ java.math.BigInteger end = index.add(java.math.BigInteger.ONE).multiply(numElement).divide(numSlice)
/* 112 */ .multiply(step).add(start);
/* 113 */ if (end.compareTo(java.math.BigInteger.valueOf(Long.MAX_VALUE)) > 0) {
/* 114 */ partitionEnd = Long.MAX_VALUE;
/* 115 */ } else if (end.compareTo(java.math.BigInteger.valueOf(Long.MIN_VALUE)) < 0) {
/* 116 */ partitionEnd = Long.MIN_VALUE;
/* 117 */ } else {
/* 118 */ partitionEnd = end.longValue();
/* 119 */ }
/* 120 */
/* 121 */ java.math.BigInteger startToEnd = java.math.BigInteger.valueOf(partitionEnd).subtract(
/* 122 */ java.math.BigInteger.valueOf(range_nextIndex_0));
/* 123 */ range_numElementsTodo_0 = startToEnd.divide(step).longValue();
/* 124 */ if (range_numElementsTodo_0 < 0) {
/* 125 */ range_numElementsTodo_0 = 0;
/* 126 */ } else if (startToEnd.remainder(step).compareTo(java.math.BigInteger.valueOf(0L)) != 0) {
/* 127 */ range_numElementsTodo_0++;
/* 128 */ }
/* 129 */ }
/* 130 */
/* 131 */ protected void processNext() throws java.io.IOException {
/* 132 */ // initialize Range
/* 133 */ if (!range_initRange_0) {
/* 134 */ range_initRange_0 = true;
/* 135 */ initRange(partitionIndex);
/* 136 */ }
/* 137 */
/* 138 */ while (true) {
/* 139 */ if (range_nextIndex_0 == range_batchEnd_0) {
/* 140 */ long range_nextBatchTodo_0;
/* 141 */ if (range_numElementsTodo_0 > 1000L) {
/* 142 */ range_nextBatchTodo_0 = 1000L;
/* 143 */ range_numElementsTodo_0 -= 1000L;
/* 144 */ } else {
/* 145 */ range_nextBatchTodo_0 = range_numElementsTodo_0;
/* 146 */ range_numElementsTodo_0 = 0;
/* 147 */ if (range_nextBatchTodo_0 == 0) break;
/* 148 */ }
/* 149 */ range_batchEnd_0 += range_nextBatchTodo_0 * 1L;
/* 150 */ }
/* 151 */
/* 152 */ int range_localEnd_0 = (int)((range_batchEnd_0 - range_nextIndex_0) / 1L);
/* 153 */ for (int range_localIdx_0 = 0; range_localIdx_0 < range_localEnd_0; range_localIdx_0++) {
/* 154 */ long range_value_0 = ((long)range_localIdx_0 * 1L) + range_nextIndex_0;
/* 155 */
/* 156 */ // common sub-expressions
/* 157 */
/* 158 */ bnlj_doConsume_0(range_value_0);
/* 159 */
/* 160 */ if (shouldStop()) {
/* 161 */ range_nextIndex_0 = range_value_0 + 1L;
/* 162 */ ((org.apache.spark.sql.execution.metric.SQLMetric) references[0] /* numOutputRows */).add(range_localIdx_0 + 1);
/* 163 */ range_inputMetrics_0.incRecordsRead(range_localIdx_0 + 1);
/* 164 */ return;
/* 165 */ }
/* 166 */
/* 167 */ }
/* 168 */ range_nextIndex_0 = range_batchEnd_0;
/* 169 */ ((org.apache.spark.sql.execution.metric.SQLMetric) references[0] /* numOutputRows */).add(range_localEnd_0);
/* 170 */ range_inputMetrics_0.incRecordsRead(range_localEnd_0);
/* 171 */ range_taskContext_0.killTaskIfInterrupted();
/* 172 */ }
/* 173 */ }
/* 174 */
/* 175 */ }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804529467
**[Test build #136374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136374/testReport)** for PR 31931 at commit [`8ee7536`](https://github.com/apache/spark/commit/8ee75369cb66abf85ecf6f7bde98cbdd3f1287b9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804601485
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136367/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804548658
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40957/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] linzebing commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
linzebing commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804441782
One unit test in SQLMetricsSuite failed. Let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804485108
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40951/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804546177
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40957/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804601485
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136367/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804529467
**[Test build #136374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136374/testReport)** for PR 31931 at commit [`8ee7536`](https://github.com/apache/spark/commit/8ee75369cb66abf85ecf6f7bde98cbdd3f1287b9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804500392
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40951/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31931:
URL: https://github.com/apache/spark/pull/31931#discussion_r599128682
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
##########
@@ -458,6 +460,41 @@ case class BroadcastNestedLoopJoinExec(
""".stripMargin
}
+ private def codegenOuter(ctx: CodegenContext, input: Seq[ExprCode]): String = {
+ val (_, buildRowArrayTerm) = prepareBroadcast(ctx)
+ val (buildRow, checkCondition, _) = getJoinCondition(ctx, input, streamed, broadcast)
+ val buildVars = genBuildSideVars(ctx, buildRow, broadcast)
+
+ val resultVars = buildSide match {
+ case BuildLeft => buildVars ++ input
+ case BuildRight => input ++ buildVars
+ }
+ val arrayIndex = ctx.freshName("arrayIndex")
+ val shouldOutputRow = ctx.freshName("shouldOutputRow")
+ val foundMatch = ctx.freshName("foundMatch")
+ val numOutput = metricTerm(ctx, "numOutputRows")
+
+ s"""
+ |boolean $foundMatch = false;
+ |for (int $arrayIndex = 0; $arrayIndex < $buildRowArrayTerm.length; $arrayIndex++) {
Review comment:
What about the broadcast side to be empty? It seems not right here because we still need to output one row for streamed side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804672805
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136374/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804454409
**[Test build #136367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136367/testReport)** for PR 31931 at commit [`08e47d2`](https://github.com/apache/spark/commit/08e47d2fc538838892bfabad3a1a93d85ec5228b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804594750
**[Test build #136367 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136367/testReport)** for PR 31931 at commit [`08e47d2`](https://github.com/apache/spark/commit/08e47d2fc538838892bfabad3a1a93d85ec5228b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804444865
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804923006
late lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804508168
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40951/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31931:
URL: https://github.com/apache/spark/pull/31931#discussion_r599131106
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
##########
@@ -211,6 +211,44 @@ class WholeStageCodegenSuite extends QueryTest with SharedSparkSession
}
}
+ test("Left/Right outer BroadcastNestedLoopJoinExec should be included in WholeStageCodegen") {
+ val df1 = spark.range(4).select($"id".as("k1"))
+ val df2 = spark.range(3).select($"id".as("k2"))
+ val df3 = spark.range(2).select($"id".as("k3"))
+
+ Seq(true, false).foreach { codegenEnabled =>
+ withSQLConf(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> codegenEnabled.toString) {
+ // test left outer join
Review comment:
how about adding an extra test case for broadcast side being empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804445258
I'll check it later, too. Thanks for your work, @linzebing !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804508168
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40951/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31931: [SPARK-34706] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804336146
Also the JIRA should be `SPARK-34707`, not `SPARK-34706`. https://issues.apache.org/jira/browse/SPARK-34706 is the umbrella task for all BNLJ improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31931:
URL: https://github.com/apache/spark/pull/31931#discussion_r599129435
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
##########
@@ -211,6 +211,44 @@ class WholeStageCodegenSuite extends QueryTest with SharedSparkSession
}
}
+ test("Left/Right outer BroadcastNestedLoopJoinExec should be included in WholeStageCodegen") {
+ val df1 = spark.range(4).select($"id".as("k1"))
+ val df2 = spark.range(3).select($"id".as("k2"))
+ val df3 = spark.range(2).select($"id".as("k3"))
+
+ Seq(true, false).foreach { codegenEnabled =>
+ withSQLConf(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> codegenEnabled.toString) {
+ // test left outer join
+ val leftOuterJoinDF = df1.join(df2, $"k1" > $"k2", "left_outer")
+ var hasJoinInCodegen = leftOuterJoinDF.queryExecution.executedPlan.collect {
+ case WholeStageCodegenExec(_: BroadcastNestedLoopJoinExec) => true
+ }.size === 1
+ assert(hasJoinInCodegen == codegenEnabled)
+ checkAnswer(leftOuterJoinDF,
+ Seq(Row(0, null), Row(1, 0), Row(2, 0), Row(2, 1), Row(3, 0), Row(3, 1), Row(3, 2)))
+
+ // test right outer join
+ val rightOuterJoinDF = df1.join(df2, $"k1" < $"k2", "right_outer")
+ hasJoinInCodegen = rightOuterJoinDF.queryExecution.executedPlan.collect {
+ case WholeStageCodegenExec(_: BroadcastNestedLoopJoinExec) => true
+ }.size === 1
+ assert(hasJoinInCodegen == codegenEnabled)
+ checkAnswer(rightOuterJoinDF, Seq(Row(null, 0), Row(0, 1), Row(0, 2), Row(1, 2)))
+
+ // test a combination of left outer and right outer joins
+ val twoJoinsDF = df1.join(df2, $"k1" > $"k2" + 1, "right_outer")
+ .join(df3, $"k1" <= $"k3", "left_outer")
+ hasJoinInCodegen = twoJoinsDF.queryExecution.executedPlan.collect {
+ case WholeStageCodegenExec(BroadcastNestedLoopJoinExec(
+ _: BroadcastNestedLoopJoinExec, _, _, _, _)) => true
Review comment:
nit: seems indentation is off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31931: [SPARK-34706] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804313370
I am looking this, also cc @cloud-fan and @maropu for review if you have time, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804660163
**[Test build #136374 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136374/testReport)** for PR 31931 at commit [`8ee7536`](https://github.com/apache/spark/commit/8ee75369cb66abf85ecf6f7bde98cbdd3f1287b9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31931:
URL: https://github.com/apache/spark/pull/31931#discussion_r599312638
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
##########
@@ -458,6 +460,49 @@ case class BroadcastNestedLoopJoinExec(
""".stripMargin
}
+ private def codegenOuter(ctx: CodegenContext, input: Seq[ExprCode]): String = {
+ val (buildRowArray, buildRowArrayTerm) = prepareBroadcast(ctx)
+ val (buildRow, checkCondition, _) = getJoinCondition(ctx, input, streamed, broadcast)
+ val buildVars = genBuildSideVars(ctx, buildRow, broadcast)
+
+ val resultVars = buildSide match {
+ case BuildLeft => buildVars ++ input
+ case BuildRight => input ++ buildVars
+ }
+ val arrayIndex = ctx.freshName("arrayIndex")
+ val shouldOutputRow = ctx.freshName("shouldOutputRow")
+ val foundMatch = ctx.freshName("foundMatch")
+ val numOutput = metricTerm(ctx, "numOutputRows")
+
+ if (buildRowArray.isEmpty) {
+ s"""
+ |UnsafeRow $buildRow = null;
+ |$numOutput.add(1);
+ |${consume(ctx, resultVars)}
+ """.stripMargin
+ } else {
+ s"""
+ |boolean $foundMatch = false;
Review comment:
we can declare this variable inside the for loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804547784
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40957/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804284179
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] linzebing commented on a change in pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
linzebing commented on a change in pull request #31931:
URL: https://github.com/apache/spark/pull/31931#discussion_r599135275
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
##########
@@ -458,6 +460,41 @@ case class BroadcastNestedLoopJoinExec(
""".stripMargin
}
+ private def codegenOuter(ctx: CodegenContext, input: Seq[ExprCode]): String = {
+ val (_, buildRowArrayTerm) = prepareBroadcast(ctx)
+ val (buildRow, checkCondition, _) = getJoinCondition(ctx, input, streamed, broadcast)
+ val buildVars = genBuildSideVars(ctx, buildRow, broadcast)
+
+ val resultVars = buildSide match {
+ case BuildLeft => buildVars ++ input
+ case BuildRight => input ++ buildVars
+ }
+ val arrayIndex = ctx.freshName("arrayIndex")
+ val shouldOutputRow = ctx.freshName("shouldOutputRow")
+ val foundMatch = ctx.freshName("foundMatch")
+ val numOutput = metricTerm(ctx, "numOutputRows")
+
+ s"""
+ |boolean $foundMatch = false;
+ |for (int $arrayIndex = 0; $arrayIndex < $buildRowArrayTerm.length; $arrayIndex++) {
Review comment:
Yes, you are right. Let me address this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31931: [SPARK-34706] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804312973
Thanks @linzebing for working on this. Can you add `[SQL]` to the PR title as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804674015
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31931: [SPARK-34706] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804284179
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804454409
**[Test build #136367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136367/testReport)** for PR 31931 at commit [`08e47d2`](https://github.com/apache/spark/commit/08e47d2fc538838892bfabad3a1a93d85ec5228b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804548658
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40957/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31931:
URL: https://github.com/apache/spark/pull/31931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804672805
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136374/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] linzebing commented on pull request #31931: [SPARK-34707][SQL] Code-gen broadcast nested loop join (left outer/right outer)
Posted by GitBox <gi...@apache.org>.
linzebing commented on pull request #31931:
URL: https://github.com/apache/spark/pull/31931#issuecomment-804448206
> One unit test in SQLMetricsSuite failed. Let me check.
Fixed test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org