[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2451: Support isWrapperFor and unwrap

[GitBox <gi...@apache.org>]

turboFei commented on code in PR #2451:
URL: https://github.com/apache/incubator-kyuubi/pull/2451#discussion_r857104391


##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -1585,8 +1585,7 @@ public void setTypeMap(Map<String, Class<?>> map) throws SQLException {
 
   @Override
   public boolean isWrapperFor(Class<?> iface) throws SQLException {
-    // TODO Auto-generated method stub
-    throw new SQLFeatureNotSupportedException("Method not supported");
+    return iface.isInstance(this);

Review Comment:
   what is the use case?
   
   The implementation in this pr just likes isInstance and asInstance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org