You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/22 03:18:18 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5507: arch: Align the implementation of stack related functions

xiaoxiang781216 commented on pull request #5507:
URL: https://github.com/apache/incubator-nuttx/pull/5507#issuecomment-1047386657


   > > > at least "Remove the alignment workaround in up_initial_state" patch seems wrong to me.
   > > 
   > > 
   > > I still can't understand why we need subtract here(the stack pointer should be always align on 16 bytes)? Could you give more explanation?
   > 
   > our context switch code doesn't subtract it as a function call would do. tweaking our context switch code might be an alternative.
   
   Yes, I think it's better than hack up_initial_state.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org