You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/03 18:18:35 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4055: mm: Move the real implementation of mm_sbrk to sbrk
xiaoxiang781216 opened a new pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055
## Summary
and remove mm_sbrk and kmm_sbrk since it's wrong to expose
sbrk to other heaps except the default userspace heap.
## Impact
No, code refactor
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4055: mm: Move the real implementation of mm_sbrk to sbrk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-873877943
> @xiaoxiang781216
>
> BTW, can you add sabre-6quad:knsh to test CONFIG_BUILD_KERNEL with QEMU?
But, sabre-6quad doesn't have any config enable CONFIG_BUILD_KERNEL. Did you boot sabre-6quad with kernel mode sucessfully before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4055: mm: Move the real implementation of mm_sbrk to sbrk
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-873883916
> > @xiaoxiang781216
> > BTW, can you add sabre-6quad:knsh to test CONFIG_BUILD_KERNEL with QEMU?
>
> But, sabre-6quad doesn't have any config enable CONFIG_BUILD_KERNEL. Did you boot sabre-6quad with kernel mode sucessfully before? It will be great to have a kernel config run with QEMU, so we can verify many kernel only feature without any real hardware.
@xiaoxiang781216
No, I've never tried CONFIG_BUILD_KERNEL before.
I think you are using dual Cortex-A7 in KERNEL mode as well, so I thought it would be easy to apply the feature to sabre-6quad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4055: mm: Move the real implementation of mm_sbrk to sbrk
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-873883916
> > @xiaoxiang781216
> > BTW, can you add sabre-6quad:knsh to test CONFIG_BUILD_KERNEL with QEMU?
>
> But, sabre-6quad doesn't have any config enable CONFIG_BUILD_KERNEL. Did you boot sabre-6quad with kernel mode sucessfully before? It will be great to have a kernel config run with QEMU, so we can verify many kernel only feature without any real hardware.
@xiaoxiang781216
No, I've never tried CONFIG_BUILD_KERNEL before.
I think you are using dual Cortex-A7 in KERNEL mode as well, so I thought it would be easy to apply the feature to sabre-6quad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4055: mm: Move the real implementation of mm_sbrk to sbrk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-873877943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4055: mm: Move the real implementation of mm_sbrk to sbrk
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-873679288
@xiaoxiang781216
BTW, can you add sabre-6quad:knsh to test CONFIG_BUILD_KERNEL with QEMU?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #4055: mm: Move the real implementation of mm_sbrk to sbrk
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4055: mm: Move the real implementation of mm_sbrk to sbrk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-874036195
No, we use dual Cortex-A7 in FLAT mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4055: mm: Move the real implementation of mm_sbrk to sbrk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-874036195
No, we use dual Cortex-A7 in FLAT mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org