You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Gerolf Seitz (JIRA)" <ji...@apache.org> on 2007/08/02 23:35:53 UTC

[jira] Created: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

upgrade YUI to 2.3.0 and use yuiloader facilities
-------------------------------------------------

                 Key: WICKET-811
                 URL: https://issues.apache.org/jira/browse/WICKET-811
             Project: Wicket
          Issue Type: Task
          Components: wicket-datetime
    Affects Versions: 1.3.0-beta2
            Reporter: Gerolf Seitz
             Fix For: 1.3.0-beta3


beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517629 ] 

Gerolf Seitz commented on WICKET-811:
-------------------------------------

got it, and i think we have a little problem here:
yahoo-min.js can only be loaded from the same webserver, if YAHOO_config is properly initialized BEFORE yuiloader-beta.js is loaded.
i used the following code for initilization:

YAHOO_config = {
	load: {
		base: 'resources/org.apache.wicket.extensions.yui.YuiLib/'
	}
}

since this code has to be loaded before yuiloader-beta.js, this would need to go in a separate file (i named it wicket-loader.js), which would be another dependency, right?

well, i'll let you take over from here, if you're ok with that, eelco

> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: sprite.png, yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerolf Seitz closed WICKET-811.
-------------------------------


> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: loader-fix.patch, sprite.png, yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerolf Seitz updated WICKET-811:
--------------------------------

    Attachment: loader-fix.patch

loader-fix.patchpatchfixes the bugs mentioned above

also includes the change from -min.js to .js yui artifacts

> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: loader-fix.patch, sprite.png, yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerolf Seitz updated WICKET-811:
--------------------------------

    Attachment: yui2.3.0-upgrade.patch

todo:
copy "sprite.png" to src/main/java/org/apache/wicket/datetime/extensions.yui.assets.skins.sam/sprite.png

please bear with me as it's pretty late over here and there were quite a few changes to apply.

btw: the yuiloader automatically loads *-min.js files, so i included these too (besides the normal *.js files, even if they are not needed now).

> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerolf Seitz updated WICKET-811:
--------------------------------

    Attachment: sprite.png

see previous comment for where to save this file

> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: sprite.png, yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517659 ] 

Eelco Hillenius commented on WICKET-811:
----------------------------------------

I added that configuration line (as an option) and sent an email to the YUI list (http://tech.groups.yahoo.com/group/ydn-javascript/message/16209) in case they have a good suggestion we overlooked.

> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: sprite.png, yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eelco Hillenius resolved WICKET-811.
------------------------------------

    Resolution: Fixed

> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: sprite.png, yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518255 ] 

faceman edited comment on WICKET-811 at 8/7/07 1:55 PM:
-------------------------------------------------------------

loader-fix.patch:
fixes the bugs mentioned above

also includes the change from -min.js to .js yui artifacts

      was (Author: faceman):
    loader-fix.patchpatchfixes the bugs mentioned above

also includes the change from -min.js to .js yui artifacts
  
> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: loader-fix.patch, sprite.png, yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eelco Hillenius resolved WICKET-811.
------------------------------------

    Resolution: Fixed

> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: loader-fix.patch, sprite.png, yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerolf Seitz reopened WICKET-811:
---------------------------------


reopened the issue due to several bugs regarding YUILoader:
:: the check for the Wicket-object in checkWicketDate is too weak, because Wicket already exists if wicket-event.js is loaded first.
:: using multiple datepickers results in multiple script-tag renderings of the same .js file because all loaders try to resolve dependencies at the same time
:: there is no need for creating several loaders in DatePicker.js, as one loader for all calendars should be sufficient

> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: sprite.png, yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517627 ] 

Gerolf Seitz commented on WICKET-811:
-------------------------------------

works great, with one minor issue: yahoo-min.js is still loaded from yui.yahooapis.com
i'll look into it

> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: sprite.png, yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-811) upgrade YUI to 2.3.0 and use yuiloader facilities

Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517600 ] 

Eelco Hillenius commented on WICKET-811:
----------------------------------------

I committed a slightly tweaked version of the patch. However, it currently doesn't work in Safari and Opera (didn't test IE), though it works with FireFox/ Camino. Don't know yet what's wrong.

> upgrade YUI to 2.3.0 and use yuiloader facilities
> -------------------------------------------------
>
>                 Key: WICKET-811
>                 URL: https://issues.apache.org/jira/browse/WICKET-811
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta2
>            Reporter: Gerolf Seitz
>             Fix For: 1.3.0-beta3
>
>         Attachments: sprite.png, yui2.3.0-upgrade.patch
>
>
> beside the replacement of the actual files, the yuiloader facilities should be used to resolve dependencies

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.