You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2021/04/25 17:35:12 UTC
[hadoop] branch trunk updated: HADOOP-17112. S3A committers can't
handle whitespace in paths. (#2953)
This is an automated email from the ASF dual-hosted git repository.
stevel pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new 88a550b HADOOP-17112. S3A committers can't handle whitespace in paths. (#2953)
88a550b is described below
commit 88a550bc3a73dbbbfb35e2ef29d9c34ad059d1a8
Author: Steve Loughran <st...@cloudera.com>
AuthorDate: Sun Apr 25 18:33:55 2021 +0100
HADOOP-17112. S3A committers can't handle whitespace in paths. (#2953)
Contributed by Krzysztof Adamski.
---
.../src/main/java/org/apache/hadoop/fs/s3a/commit/CommitOperations.java | 2 +-
.../java/org/apache/hadoop/fs/s3a/commit/ITestCommitOperations.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/CommitOperations.java b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/CommitOperations.java
index c09278f..cd8257f 100644
--- a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/CommitOperations.java
+++ b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/CommitOperations.java
@@ -485,7 +485,7 @@ public class CommitOperations implements IOStatisticsSource {
if (!localFile.isFile()) {
throw new FileNotFoundException("Not a file: " + localFile);
}
- String destURI = destPath.toString();
+ String destURI = destPath.toUri().toString();
String destKey = fs.pathToKey(destPath);
String uploadId = null;
diff --git a/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/ITestCommitOperations.java b/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/ITestCommitOperations.java
index 4d7f81d..ab2f9a2 100644
--- a/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/ITestCommitOperations.java
+++ b/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/ITestCommitOperations.java
@@ -673,7 +673,7 @@ public class ITestCommitOperations extends AbstractCommitITest {
Path subdir = new Path(destDir, "subdir");
// file 2
Path destFile2 = new Path(subdir, "file2");
- Path destFile3 = new Path(subdir, "file3");
+ Path destFile3 = new Path(subdir, "file3 with space");
List<Path> destinations = Lists.newArrayList(destFile1, destFile2,
destFile3);
List<SinglePendingCommit> commits = new ArrayList<>(3);
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org