[jira] [Commented] (PIG-2935) Catch NoSuchMethodError when StoreFuncInterface's new cleanupOnSuccess method isn't implemented.

["Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465006#comment-13465006 ] 

Dmitriy V. Ryaboy commented on PIG-2935:
----------------------------------------

Alan, that won't work -- the error thrown is not NoSuchMethod, but AbstractMethodError (the abstract method is declared in the new interface, so the method exists, but has no implementation). These are both children of IncompatibleClassChangeError , which would capture the case of somehow using the new PigServer but the old StoreFuncInterface, though that's probably overkill (I don't know how one would get into such a bind).
                
> Catch NoSuchMethodError when StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
> ------------------------------------------------------------------------------------------------
>
>                 Key: PIG-2935
>                 URL: https://issues.apache.org/jira/browse/PIG-2935
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.11
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>            Priority: Critical
>             Fix For: 0.11
>
>         Attachments: PIG-2935.patch
>
>
> We should catch a NoSuchMethodError here so that old implementations of StoreFuncInterface still work.  This will still be incompatible for people who re-compile their store functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira