You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Syed S. Albiz (JIRA)" <ji...@apache.org> on 2011/07/12 21:35:59 UTC
[jira] [Created] (HIVE-2281) Regression introduced from HIVE-2155
Regression introduced from HIVE-2155
------------------------------------
Key: HIVE-2281
URL: https://issues.apache.org/jira/browse/HIVE-2281
Project: Hive
Issue Type: Bug
Reporter: Syed S. Albiz
Assignee: Syed S. Albiz
EXPLAIN SELECT key, count(1) FROM src; throws a null pointer exception due to the operator stack not being checked prior to use for constructing the error message, due to the change introduced in HIVE-2155 to improve error message context tokens.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2281) Regression introduced from HIVE-2155
Posted by "Syed S. Albiz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Syed S. Albiz updated HIVE-2281:
--------------------------------
Attachment: HIVE-2281.1.patch
Add defensive checks before using the operator stack and make sure to restore it to expected state after proceeding
> Regression introduced from HIVE-2155
> ------------------------------------
>
> Key: HIVE-2281
> URL: https://issues.apache.org/jira/browse/HIVE-2281
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2281.1.patch
>
>
> EXPLAIN SELECT key, count(1) FROM src; throws a null pointer exception due to the operator stack not being checked prior to use for constructing the error message, due to the change introduced in HIVE-2155 to improve error message context tokens.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2281) Regression introduced from HIVE-2155
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064795#comment-13064795 ]
Hudson commented on HIVE-2281:
------------------------------
Integrated in Hive-trunk-h0.21 #824 (See [https://builds.apache.org/job/Hive-trunk-h0.21/824/])
HIVE-2281. Regression introduced from HIVE-2155 (Syed S. Albiz via Ning Zhang)
nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146100
Files :
* /hive/trunk/ql/src/test/results/clientnegative/nonkey_groupby.q.out
* /hive/trunk/ql/src/test/queries/clientnegative/nonkey_groupby.q
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
> Regression introduced from HIVE-2155
> ------------------------------------
>
> Key: HIVE-2281
> URL: https://issues.apache.org/jira/browse/HIVE-2281
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Fix For: 0.8.0
>
> Attachments: HIVE-2281.1.patch
>
>
> EXPLAIN SELECT key, count(1) FROM src; throws a null pointer exception due to the operator stack not being checked prior to use for constructing the error message, due to the change introduced in HIVE-2155 to improve error message context tokens.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2281) Regression introduced from HIVE-2155
Posted by "Syed S. Albiz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Syed S. Albiz updated HIVE-2281:
--------------------------------
Status: Patch Available (was: Open)
> Regression introduced from HIVE-2155
> ------------------------------------
>
> Key: HIVE-2281
> URL: https://issues.apache.org/jira/browse/HIVE-2281
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2281.1.patch
>
>
> EXPLAIN SELECT key, count(1) FROM src; throws a null pointer exception due to the operator stack not being checked prior to use for constructing the error message, due to the change introduced in HIVE-2155 to improve error message context tokens.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2281) Regression introduced from HIVE-2155
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064094#comment-13064094 ]
Ning Zhang commented on HIVE-2281:
----------------------------------
+1. Will commit if tests pass.
> Regression introduced from HIVE-2155
> ------------------------------------
>
> Key: HIVE-2281
> URL: https://issues.apache.org/jira/browse/HIVE-2281
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2281.1.patch
>
>
> EXPLAIN SELECT key, count(1) FROM src; throws a null pointer exception due to the operator stack not being checked prior to use for constructing the error message, due to the change introduced in HIVE-2155 to improve error message context tokens.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2281) Regression introduced from HIVE-2155
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ning Zhang updated HIVE-2281:
-----------------------------
Resolution: Fixed
Fix Version/s: 0.8.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed. Thanks Syed!
> Regression introduced from HIVE-2155
> ------------------------------------
>
> Key: HIVE-2281
> URL: https://issues.apache.org/jira/browse/HIVE-2281
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Fix For: 0.8.0
>
> Attachments: HIVE-2281.1.patch
>
>
> EXPLAIN SELECT key, count(1) FROM src; throws a null pointer exception due to the operator stack not being checked prior to use for constructing the error message, due to the change introduced in HIVE-2155 to improve error message context tokens.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2281) Regression introduced from HIVE-2155
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064093#comment-13064093 ]
jiraposter@reviews.apache.org commented on HIVE-2281:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1094/
-----------------------------------------------------------
Review request for hive and Ning Zhang.
Summary
-------
Add defensive checks on operator stack when constructing the error
message for invalid aggregate expressions (Expression not in GROUP
BY...)
This addresses bug HIVE-2281.
https://issues.apache.org/jira/browse/HIVE-2281
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java dfadb9f
ql/src/test/queries/clientnegative/nonkey_groupby.q PRE-CREATION
ql/src/test/results/clientnegative/nonkey_groupby.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1094/diff
Testing
-------
Added new unit test (nonkey_groupby.q) to NegativeCliDriver suite,
made sure no breakage to existing tests covering this message:
groupby_key.q,notable_alias3.q (TestNegativeCliDriver)
nonkey_groupby.q,unknown_column6.q (TestNegativeParseDriver)
Thanks,
Syed
> Regression introduced from HIVE-2155
> ------------------------------------
>
> Key: HIVE-2281
> URL: https://issues.apache.org/jira/browse/HIVE-2281
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2281.1.patch
>
>
> EXPLAIN SELECT key, count(1) FROM src; throws a null pointer exception due to the operator stack not being checked prior to use for constructing the error message, due to the change introduced in HIVE-2155 to improve error message context tokens.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira