[GitHub] patricker opened a new pull request #3255: NIFI-5940 Cluster Node Offload Hangs if any RPG on flow is Disabled

[GitBox <gi...@apache.org>]

patricker opened a new pull request #3255: NIFI-5940 Cluster Node Offload Hangs if any RPG on flow is Disabled
URL: https://github.com/apache/nifi/pull/3255
 
 
   If any Remote Process Group on the flow is disabled when a user starts a node Offload, then offload fails.
   
   This is because the Offload process tries to turn off all Remote Process Group's, even if they are already disabled; and this causes an unexpected exception to be thrown.
   
   There are no test cases for OffLoad (there is the 'Problematic unit test' written in Groovy, but it's very problematic).
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
   - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services