You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/07 05:53:43 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #5086: Merge PreparedQueryPrepareEngine and SimpleQueryPrepareEngine into PrepareEngine

terrymanu opened a new pull request #5086: Merge PreparedQueryPrepareEngine and SimpleQueryPrepareEngine into PrepareEngine
URL: https://github.com/apache/incubator-shardingsphere/pull/5086
 
 
   For #3691
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5086: Merge PreparedQueryPrepareEngine and SimpleQueryPrepareEngine into PrepareEngine

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5086: Merge PreparedQueryPrepareEngine and SimpleQueryPrepareEngine into PrepareEngine
URL: https://github.com/apache/incubator-shardingsphere/pull/5086#issuecomment-610225442
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086?src=pr&el=h1) Report
   > Merging [#5086](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/0d024a4d55c92ec551228ee9560ae3bc2c0291fa&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `31.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5086      +/-   ##
   ============================================
   + Coverage     53.76%   53.77%   +0.01%     
     Complexity      395      395              
   ============================================
     Files          1147     1145       -2     
     Lines         20395    20385      -10     
     Branches       3700     3700              
   ============================================
   - Hits          10965    10962       -3     
   + Misses         8749     8742       -7     
     Partials        681      681              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...jdbc/jdbc/core/statement/MasterSlaveStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L01hc3RlclNsYXZlU3RhdGVtZW50LmphdmE=) | `9.09% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy93cmFwcGVyL1ByZXBhcmVkU3RhdGVtZW50RXhlY3V0b3JXcmFwcGVyLmphdmE=) | `2.38% <0.00%> (+0.10%)` | `0.00 <0.00> (ø)` | |
   | [...ication/jdbc/wrapper/StatementExecutorWrapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy93cmFwcGVyL1N0YXRlbWVudEV4ZWN1dG9yV3JhcHBlci5qYXZh) | `2.63% <0.00%> (+0.06%)` | `0.00 <0.00> (ø)` | |
   | [...ere/underlying/pluggble/prepare/PrepareEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1wbHVnZ2FibGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvcGx1Z2dibGUvcHJlcGFyZS9QcmVwYXJlRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...c/core/statement/MasterSlavePreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L01hc3RlclNsYXZlUHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `20.00% <25.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ardingjdbc/executor/AbstractStatementExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9leGVjdXRvci9BYnN0cmFjdFN0YXRlbWVudEV4ZWN1dG9yLmphdmE=) | `92.30% <100.00%> (-0.55%)` | `0.00 <0.00> (ø)` | |
   | [.../jdbc/core/statement/EncryptPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L0VuY3J5cHRQcmVwYXJlZFN0YXRlbWVudC5qYXZh) | `76.84% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...dingjdbc/jdbc/core/statement/EncryptStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L0VuY3J5cHRTdGF0ZW1lbnQuamF2YQ==) | `52.11% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...jdbc/core/statement/ShardingPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nUHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `72.03% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ingjdbc/jdbc/core/statement/ShardingStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3RhdGVtZW50LmphdmE=) | `53.46% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086?src=pr&el=footer). Last update [0d024a4...9167dba](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5086?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #5086: Merge PreparedQueryPrepareEngine and SimpleQueryPrepareEngine into PrepareEngine

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #5086: Merge PreparedQueryPrepareEngine and SimpleQueryPrepareEngine into PrepareEngine
URL: https://github.com/apache/incubator-shardingsphere/pull/5086
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #5086: Merge PreparedQueryPrepareEngine and SimpleQueryPrepareEngine into PrepareEngine

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5086: Merge PreparedQueryPrepareEngine and SimpleQueryPrepareEngine into PrepareEngine
URL: https://github.com/apache/incubator-shardingsphere/pull/5086#issuecomment-610227536
 
 
   ## Pull Request Test Coverage Report for [Build 10853](https://coveralls.io/builds/29901639)
   
   * **6** of **19**   **(31.58%)**  changed or added relevant lines in **10** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.01%**) to **57.179%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlaveStatement.java](https://coveralls.io/builds/29901639/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlaveStatement.java#L86) | 0 | 1 | 0.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlavePreparedStatement.java](https://coveralls.io/builds/29901639/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlavePreparedStatement.java#L90) | 1 | 4 | 25.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29901639/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L81) | 0 | 3 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/29901639/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L78) | 0 | 3 | 0.0%
   | [shardingsphere-underlying/shardingsphere-pluggable/src/main/java/org/apache/shardingsphere/underlying/pluggble/prepare/PrepareEngine.java](https://coveralls.io/builds/29901639/source?filename=shardingsphere-underlying%2Fshardingsphere-pluggable%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fpluggble%2Fprepare%2FPrepareEngine.java#L65) | 0 | 3 | 0.0%
   <!-- | **Total:** | **6** | **19** | **31.58%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29901639/badge)](https://coveralls.io/builds/29901639) |
   | :-- | --: |
   | Change from base [Build 10851](https://coveralls.io/builds/29882247): |  0.01% |
   | Covered Lines: | 11656 |
   | Relevant Lines: | 20385 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services