[GitHub] [superset] justinpark commented on a diff in pull request #24698: fix: Select onChange is being fired without explicit selection

["justinpark (via GitHub)" <gi...@apache.org>]

justinpark commented on code in PR #24698:
URL: https://github.com/apache/superset/pull/24698#discussion_r1269858864


##########
superset-frontend/src/components/Select/utils.tsx:
##########
@@ -218,7 +218,7 @@ export const mapOptions = (values: SelectOptionsType) =>
   values.map(opt => ({
     children: opt.label,
     key: opt.value,
-    value: opt.value,
     label: opt.label,
     disabled: opt.disabled,
+    ...opt,

Review Comment:
   Do you intend `options` can override the children over `opt.label`? 
   
   You can also remove the above exact matching(label, disabled) with this spreading.
   
   ```suggestion
       ...opt,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org