You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shant Hovsepian (Code Review)" <ge...@cloudera.org> on 2020/11/12 07:01:43 UTC
[Impala-ASF-CR] IMPALA-10320: Specify expression selectivity for BoolLiteral.
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16714
Change subject: IMPALA-10320: Specify expression selectivity for BoolLiteral.
......................................................................
IMPALA-10320: Specify expression selectivity for BoolLiteral.
Setting the selectivity of true and false literals to 1 and 0
respectively.
Also setting a NullLiteral's selectivity to 0.
Testing:
- New tests in ExprCardinalityTest
Change-Id: I999942c96cd685f22d8634509d9f488f2a1f82b8
---
M fe/src/main/java/org/apache/impala/analysis/BoolLiteral.java
M fe/src/main/java/org/apache/impala/analysis/NullLiteral.java
M fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java
3 files changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/16714/1
--
To view, visit http://gerrit.cloudera.org:8080/16714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I999942c96cd685f22d8634509d9f488f2a1f82b8
Gerrit-Change-Number: 16714
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
[Impala-ASF-CR] IMPALA-10320: Specify expression selectivity for BoolLiteral.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16714 )
Change subject: IMPALA-10320: Specify expression selectivity for BoolLiteral.
......................................................................
Patch Set 1: Code-Review+2
This seems like a no brainer, thank you!
--
To view, visit http://gerrit.cloudera.org:8080/16714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I999942c96cd685f22d8634509d9f488f2a1f82b8
Gerrit-Change-Number: 16714
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Nov 2020 03:46:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10320: Specify expression selectivity for BoolLiteral.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16714 )
Change subject: IMPALA-10320: Specify expression selectivity for BoolLiteral.
......................................................................
IMPALA-10320: Specify expression selectivity for BoolLiteral.
Setting the selectivity of true and false literals to 1 and 0
respectively.
Also setting a NullLiteral's selectivity to 0.
Testing:
- New tests in ExprCardinalityTest
Change-Id: I999942c96cd685f22d8634509d9f488f2a1f82b8
Reviewed-on: http://gerrit.cloudera.org:8080/16714
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/BoolLiteral.java
M fe/src/main/java/org/apache/impala/analysis/NullLiteral.java
M fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java
3 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I999942c96cd685f22d8634509d9f488f2a1f82b8
Gerrit-Change-Number: 16714
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10320: Specify expression selectivity for BoolLiteral.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16714 )
Change subject: IMPALA-10320: Specify expression selectivity for BoolLiteral.
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6647/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I999942c96cd685f22d8634509d9f488f2a1f82b8
Gerrit-Change-Number: 16714
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Nov 2020 07:03:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10320: Specify expression selectivity for BoolLiteral.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16714 )
Change subject: IMPALA-10320: Specify expression selectivity for BoolLiteral.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7637/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I999942c96cd685f22d8634509d9f488f2a1f82b8
Gerrit-Change-Number: 16714
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Nov 2020 07:23:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10320: Specify expression selectivity for BoolLiteral.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16714 )
Change subject: IMPALA-10320: Specify expression selectivity for BoolLiteral.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I999942c96cd685f22d8634509d9f488f2a1f82b8
Gerrit-Change-Number: 16714
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Nov 2020 12:30:59 +0000
Gerrit-HasComments: No