You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2017/07/21 15:12:46 UTC
Review Request 61036: Ambari upgrade should update unique constraints
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61036/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-21549
https://issues.apache.org/jira/browse/AMBARI-21549
Repository: ambari
Description
-------
When upgrading Ambari from 2.2.2 to 2.5 it was discovered that if a unique constraint is modified between Ambari versions, then we do not update the unique constraint.
For example:
*Ambari 2.2.2*
https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql#L661
{code}
ALTER TABLE users ADD CONSTRAINT UNQ_users_0 UNIQUE (user_name, ldap_user);
{code}
*Ambari-2.4.0*
https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
{code}
CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type))
{code}
Whenever after upgrading from Ambari 2.2.2 to Ambari 2.5.0, the unique constraint is not updated.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 03136984ba
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 38d60e9a4a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 6cda590d37
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java cd7ae459f7
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java 947ba2e30c
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 2590d1c995
Diff: https://reviews.apache.org/r/61036/diff/1/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
Re: Review Request 61036: Ambari upgrade should update unique
constraints
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61036/#review181178
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On July 21, 2017, 11:12 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61036/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 11:12 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21549
> https://issues.apache.org/jira/browse/AMBARI-21549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When upgrading Ambari from 2.2.2 to 2.5 it was discovered that if a unique constraint is modified between Ambari versions, then we do not update the unique constraint.
>
> For example:
> *Ambari 2.2.2*
> https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql#L661
> {code}
> ALTER TABLE users ADD CONSTRAINT UNQ_users_0 UNIQUE (user_name, ldap_user);
> {code}
>
> *Ambari-2.4.0*
> https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
> {code}
> CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type))
> {code}
>
> Whenever after upgrading from Ambari 2.2.2 to Ambari 2.5.0, the unique constraint is not updated.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 03136984ba
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 38d60e9a4a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 6cda590d37
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java cd7ae459f7
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java 947ba2e30c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 2590d1c995
>
>
> Diff: https://reviews.apache.org/r/61036/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 61036: Ambari upgrade should update unique
constraints
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61036/#review181242
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On July 21, 2017, 3:12 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61036/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 3:12 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21549
> https://issues.apache.org/jira/browse/AMBARI-21549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When upgrading Ambari from 2.2.2 to 2.5 it was discovered that if a unique constraint is modified between Ambari versions, then we do not update the unique constraint.
>
> For example:
> *Ambari 2.2.2*
> https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql#L661
> {code}
> ALTER TABLE users ADD CONSTRAINT UNQ_users_0 UNIQUE (user_name, ldap_user);
> {code}
>
> *Ambari-2.4.0*
> https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
> {code}
> CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type))
> {code}
>
> Whenever after upgrading from Ambari 2.2.2 to Ambari 2.5.0, the unique constraint is not updated.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 03136984ba
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 38d60e9a4a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 6cda590d37
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java cd7ae459f7
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java 947ba2e30c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 2590d1c995
>
>
> Diff: https://reviews.apache.org/r/61036/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 61036: Ambari upgrade should update unique
constraints
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61036/#review181208
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On July 21, 2017, 11:12 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61036/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 11:12 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21549
> https://issues.apache.org/jira/browse/AMBARI-21549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When upgrading Ambari from 2.2.2 to 2.5 it was discovered that if a unique constraint is modified between Ambari versions, then we do not update the unique constraint.
>
> For example:
> *Ambari 2.2.2*
> https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql#L661
> {code}
> ALTER TABLE users ADD CONSTRAINT UNQ_users_0 UNIQUE (user_name, ldap_user);
> {code}
>
> *Ambari-2.4.0*
> https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
> {code}
> CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type))
> {code}
>
> Whenever after upgrading from Ambari 2.2.2 to Ambari 2.5.0, the unique constraint is not updated.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 03136984ba
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 38d60e9a4a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java 6cda590d37
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java cd7ae459f7
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java 947ba2e30c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 2590d1c995
>
>
> Diff: https://reviews.apache.org/r/61036/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>