[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #195: [FLINK-26901] Introduce config options document for table store

[GitBox <gi...@apache.org>]

JingsongLi commented on code in PR #195:
URL: https://github.com/apache/flink-table-store/pull/195#discussion_r913367319


##########
docs/content/docs/deployment/configuration.md:
##########
@@ -0,0 +1,49 @@
+---
+title: "Configuration"
+weight: 1
+type: docs
+aliases:
+- /deployment/configuration.html
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Configuration
+
+Flink Table Store provides the configuration of LogStore and FileStore for hybrid storage to build dynamic tables.

Review Comment:
   I think we can remove this line



##########
docs/content/docs/deployment/configuration.md:
##########
@@ -0,0 +1,49 @@
+---
+title: "Configuration"
+weight: 1
+type: docs
+aliases:
+- /deployment/configuration.html
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Configuration
+
+Flink Table Store provides the configuration of LogStore and FileStore for hybrid storage to build dynamic tables.
+You can specify the below config options in ‘with’ for the Managed Table to configure the LogStore and FileStore. 
+
+# Common Setup Options
+
+**Table Store Factory**

Review Comment:
   We will introduce 4 options:
   - `CoreOptions`: Core options for table store.
   - `CatalogOptions`: Options for table store catalog.
   - `FlinkConnectorOptions`: Flink connector options for table store.
   - `KafkaLogOptions`: Kafka log options provided after configuring `log.system` for `kafka`.



##########
docs/content/docs/deployment/_index.md:
##########
@@ -0,0 +1,27 @@
+---
+title: Deployment

Review Comment:
   Just `Configuration`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org