You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/19 08:05:47 UTC
[GitHub] [shardingsphere] dongzl opened a new pull request #8689: Add sql parser SQLServer delete query hint statement.
dongzl opened a new pull request #8689:
URL: https://github.com/apache/shardingsphere/pull/8689
For #6478 .
Changes proposed in this pull request:
- Add sql test case from SQLServer delete query hint statement.
- Add sql parser SQLServer delete query hint statement.
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #8689: Add sql parser SQLServer delete query hint statement.
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #8689:
URL: https://github.com/apache/shardingsphere/pull/8689
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8689: Add sql parser SQLServer delete query hint statement.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8689:
URL: https://github.com/apache/shardingsphere/pull/8689#issuecomment-748446492
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=h1) Report
> Merging [#8689](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=desc) (2f27441) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a35c5e786a615510adfa40ca7fa5b90ef2d0edd4?el=desc) (a35c5e7) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8689 +/- ##
============================================
- Coverage 71.09% 71.07% -0.02%
Complexity 622 622
============================================
Files 1572 1572
Lines 25136 25136
Branches 4404 4404
============================================
- Hits 17870 17865 -5
- Misses 6081 6086 +5
Partials 1185 1185
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ere/scaling/core/utils/RdbmsConfigurationUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8689/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9SZGJtc0NvbmZpZ3VyYXRpb25VdGlsLmphdmE=) | `40.00% <0.00%> (-40.00%)` | `0.00% <0.00%> (ø%)` | |
| [...re/execute/executor/dumper/AbstractJDBCDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/8689/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2R1bXBlci9BYnN0cmFjdEpEQkNEdW1wZXIuamF2YQ==) | `85.71% <0.00%> (-4.77%)` | `0.00% <0.00%> (ø%)` | |
| [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/8689/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `58.18% <0.00%> (-1.82%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=footer). Last update [a35c5e7...2f27441](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8689: Add sql parser SQLServer delete query hint statement.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8689:
URL: https://github.com/apache/shardingsphere/pull/8689#issuecomment-748446492
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=h1) Report
> Merging [#8689](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=desc) (2f27441) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a35c5e786a615510adfa40ca7fa5b90ef2d0edd4?el=desc) (a35c5e7) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8689 +/- ##
============================================
- Coverage 71.09% 71.07% -0.02%
Complexity 622 622
============================================
Files 1572 1572
Lines 25136 25136
Branches 4404 4404
============================================
- Hits 17870 17865 -5
- Misses 6081 6086 +5
Partials 1185 1185
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ere/scaling/core/utils/RdbmsConfigurationUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8689/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9SZGJtc0NvbmZpZ3VyYXRpb25VdGlsLmphdmE=) | `40.00% <0.00%> (-40.00%)` | `0.00% <0.00%> (ø%)` | |
| [...re/execute/executor/dumper/AbstractJDBCDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/8689/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2R1bXBlci9BYnN0cmFjdEpEQkNEdW1wZXIuamF2YQ==) | `85.71% <0.00%> (-4.77%)` | `0.00% <0.00%> (ø%)` | |
| [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/8689/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `58.18% <0.00%> (-1.82%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=footer). Last update [a35c5e7...2f27441](https://codecov.io/gh/apache/shardingsphere/pull/8689?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org