[jira] [Closed] (THRIFT-2210) lib/java TSimpleJSONProtocol can emit invalid JSON

["Jake Farrell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell closed THRIFT-2210.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.9.2
         Assignee: Alex Levenson

Thanks for the patch Alex, committed
                
> lib/java TSimpleJSONProtocol can emit invalid JSON
> --------------------------------------------------
>
>                 Key: THRIFT-2210
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2210
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Alex Levenson
>            Assignee: Alex Levenson
>             Fix For: 0.9.2
>
>         Attachments: THRIFT-2210-v1.patch
>
>
> TSimpleJSONProtocol can emit JSON with maps whose keys are not string (which is not allowed is the JSON spec).
> This happens if the key in a map is anything other than a String (int, enum, etc)
> For example, it can emit JSON like this: 
> {noformat}
> {"myMap":{5:"myValue"}}
> {noformat}
> which should be:
> {noformat}
> {"myMap":{"5":"myValue"}}
> {noformat}
> I have a path that fixes this, I'll upload it shortly (still trying to get my dev environment to run the tests).
> Also AFAICT there is no unit test for TSimpleJSONProtocol -- I'll try and add one to the patch.
> Thanks!
> Alex

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira