[jira] [Commented] (BEAM-1810) Spark runner combineGlobally uses Kryo serialization

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941858#comment-15941858 ] 

ASF GitHub Bot commented on BEAM-1810:
--------------------------------------

GitHub user aviemzur opened a pull request:

    https://github.com/apache/beam/pull/2328

    [BEAM-1810] Avoid RDD#isEmpty in Spark runner TransformTranslator#combineGlobally

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aviemzur/beam combine-globally-kryo-serialization-exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2328
    
----
commit 7bc632fbcab1d5f53f5ce52e739769ead8cc0d19
Author: Aviem Zur <av...@gmail.com>
Date:   2017-03-25T18:49:06Z

    [BEAM-1810] Avoid RDD#isEmpty in Spark runner TransformTranslator#combineGlobally

----


> Spark runner combineGlobally uses Kryo serialization
> ----------------------------------------------------
>
>                 Key: BEAM-1810
>                 URL: https://issues.apache.org/jira/browse/BEAM-1810
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Aviem Zur
>            Assignee: Aviem Zur
>
> {{TransformTranslator#combineGlobally}} uses Kryo serialization to serialize data. This should never happen.
> This is due to Spark's implementation of {{RDD.isEmpty}} which takes the first element to check if they are elements in the {{RDD}}, it is then serialized with Spark's configured serializer (In our case, Kryo).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)