You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/02 09:36:15 UTC
[GitHub] [spark] wangyum opened a new pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
wangyum opened a new pull request #32744:
URL: https://github.com/apache/spark/pull/32744
### What changes were proposed in this pull request?
This PR removes `canPlanAsBroadcastHashJoin` check in `EliminateOuterJoin.
### Why are the changes needed?
We can always removes outer join if it only has DISTINCT on streamed side.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-852892857
**[Test build #139215 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139215/testReport)** for PR 32744 at commit [`41926a2`](https://github.com/apache/spark/commit/41926a2a35cc7ff4783e7ada9a442e7631710a6d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-852925483
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43741/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #32744:
URL: https://github.com/apache/spark/pull/32744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-852892857
**[Test build #139215 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139215/testReport)** for PR 32744 at commit [`41926a2`](https://github.com/apache/spark/commit/41926a2a35cc7ff4783e7ada9a442e7631710a6d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-853064291
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139215/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-852943751
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43738/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-852896758
**[Test build #139218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139218/testReport)** for PR 32744 at commit [`7c23a88`](https://github.com/apache/spark/commit/7c23a8831e6c4e6d2be765094fadb4927a0fc1dc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-852929476
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43741/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-852896758
**[Test build #139218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139218/testReport)** for PR 32744 at commit [`7c23a88`](https://github.com/apache/spark/commit/7c23a8831e6c4e6d2be765094fadb4927a0fc1dc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-853064291
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139215/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-853061120
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139218/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32744:
URL: https://github.com/apache/spark/pull/32744#discussion_r643799888
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
##########
@@ -172,20 +172,16 @@ object EliminateOuterJoin extends Rule[LogicalPlan] with PredicateHelper with Jo
if (j.joinType == newJoinType) f else Filter(condition, j.copy(joinType = newJoinType))
case a @ Aggregate(_, _, join @ Join(left, _, LeftOuter, _, _))
- if a.isDistinct && a.references.subsetOf(AttributeSet(left.output)) &&
- !canPlanAsBroadcastHashJoin(join, conf) =>
+ if a.isDistinct && a.references.subsetOf(AttributeSet(left.output)) =>
Review comment:
nit: since we support `select a, a ...`, how about we rename `isDistinct` to `groupOnly`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-853059478
**[Test build #139218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139218/testReport)** for PR 32744 at commit [`7c23a88`](https://github.com/apache/spark/commit/7c23a8831e6c4e6d2be765094fadb4927a0fc1dc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-853061120
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139218/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-852923211
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43738/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #32744:
URL: https://github.com/apache/spark/pull/32744#discussion_r643801460
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
##########
@@ -172,20 +172,16 @@ object EliminateOuterJoin extends Rule[LogicalPlan] with PredicateHelper with Jo
if (j.joinType == newJoinType) f else Filter(condition, j.copy(joinType = newJoinType))
case a @ Aggregate(_, _, join @ Join(left, _, LeftOuter, _, _))
- if a.isDistinct && a.references.subsetOf(AttributeSet(left.output)) &&
- !canPlanAsBroadcastHashJoin(join, conf) =>
+ if a.isDistinct && a.references.subsetOf(AttributeSet(left.output)) =>
Review comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-852965671
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43738/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-852965671
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43738/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-853062307
**[Test build #139215 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139215/testReport)** for PR 32744 at commit [`41926a2`](https://github.com/apache/spark/commit/41926a2a35cc7ff4783e7ada9a442e7631710a6d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-852929476
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43741/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32744: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32744:
URL: https://github.com/apache/spark/pull/32744#issuecomment-853065060
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org