You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ojb-dev@db.apache.org by ar...@apache.org on 2005/10/27 20:09:55 UTC

cvs commit: db-ojb/src/java/org/apache/ojb/odmg TransactionExt.java

arminw      2005/10/27 11:09:55

  Modified:    src/java/org/apache/ojb/odmg Tag: OJB_1_0_RELEASE
                        TransactionExt.java
  Log:
  remove redundant method, combination of setImplicitLocking(false) and setOrdering(false) will have the same effect
  
  Revision  Changes    Path
  No                   revision
  No                   revision
  1.4.2.7   +32 -32    db-ojb/src/java/org/apache/ojb/odmg/TransactionExt.java
  
  Index: TransactionExt.java
  ===================================================================
  RCS file: /home/cvs/db-ojb/src/java/org/apache/ojb/odmg/TransactionExt.java,v
  retrieving revision 1.4.2.6
  retrieving revision 1.4.2.7
  diff -u -r1.4.2.6 -r1.4.2.7
  --- TransactionExt.java	9 Sep 2005 00:36:18 -0000	1.4.2.6
  +++ TransactionExt.java	27 Oct 2005 18:09:55 -0000	1.4.2.7
  @@ -90,7 +90,7 @@
        * reference field while this transaction is in use.
        *
        * @param target The class to change cascading delete behavior of the references.
  -     * @param referenceField The field name of the 1:1, 1:n or 1:n reference.
  +     * @param referenceField The field name of the 1:1, 1:n or m:n reference.
        * @param doCascade If <em>true</em> cascading delete is enabled, <em>false</em> disabled.
        */
       public void setCascadingDelete(Class target, String referenceField, boolean doCascade);
  @@ -126,36 +126,36 @@
        */
       public void setOrdering(boolean ordering);
   
  -    /**
  -     * Returns whether or not the persistent method calls determine
  -     * the persistent object order on commit.
  -     *
  -     * @see #setNoteUserOrder(boolean)
  -     */
  -    public boolean isNoteUserOrder();
  -
  -    /**
  -     * If <em>true</em> the order of persisting method calls like
  -     * <br/> - {@link org.odmg.Transaction#lock(Object, int)}).
  -     * <br/> - {@link org.odmg.Database#deletePersistent(Object)}).
  -     * <br/> - {@link org.odmg.Database#makePersistent(Object)})
  -     * determine the order of objects before commit.
  -     * <br/>
  -     * If <em>false</em> the ordering was determined by OJB's internal
  -     * method calls and user calls.
  -     * <br/>
  -     * However it's possible to set this value as a global property
  -     * for all transactions using {@link ImplementationExt#setNoteUserOrder(boolean)}.
  -     * <p/>
  -     * <strong>NOTE:</strong> If OJB's ordering algorithm (see
  -     * {@link #setOrdering(boolean)}) is enabled, the
  -     * order of objects may change on commit.
  -     *
  -     * @param noteUserOrder If <em>true</em> the order of persisting
  -     * method calls determine the order of objects.
  -     * @see ImplementationExt#setNoteUserOrder(boolean) 
  -     */
  -    public void setNoteUserOrder(boolean noteUserOrder);
  +//    /**
  +//     * Returns whether or not the persistent method calls determine
  +//     * the persistent object order on commit.
  +//     *
  +//     * @see #setNoteUserOrder(boolean)
  +//     */
  +//    public boolean isNoteUserOrder();
  +//
  +//    /**
  +//     * If <em>true</em> the order of persisting method calls like
  +//     * <br/> - {@link org.odmg.Transaction#lock(Object, int)}).
  +//     * <br/> - {@link org.odmg.Database#deletePersistent(Object)}).
  +//     * <br/> - {@link org.odmg.Database#makePersistent(Object)})
  +//     * determine the order of objects before commit.
  +//     * <br/>
  +//     * If <em>false</em> the ordering was determined by OJB's internal
  +//     * method calls and user calls.
  +//     * <br/>
  +//     * However it's possible to set this value as a global property
  +//     * for all transactions using {@link ImplementationExt#setNoteUserOrder(boolean)}.
  +//     * <p/>
  +//     * <strong>NOTE:</strong> If OJB's ordering algorithm (see
  +//     * {@link #setOrdering(boolean)}) is enabled, the
  +//     * order of objects may change on commit.
  +//     *
  +//     * @param noteUserOrder If <em>true</em> the order of persisting
  +//     * method calls determine the order of objects.
  +//     * @see ImplementationExt#setNoteUserOrder(boolean)
  +//     */
  +//    public void setNoteUserOrder(boolean noteUserOrder);
   
       /**
        * Checks if the object with the given {@link org.apache.ojb.broker.Identity}
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Re: cvs commit: db-ojb/src/java/org/apache/ojb/odmg TransactionExt.java

Posted by Armin Waibel <ar...@apache.org>.
Hi Ilkka,

I'm really sorry. I ignored this class in the heat of the moment.

regards,
Armin

Ilkka Priha wrote:
>  <arminw <at> apache.org> writes:
> 
> 
>>arminw      2005/10/27 11:09:55
>>
>>  Modified:    src/java/org/apache/ojb/odmg Tag: OJB_1_0_RELEASE
>>                        TransactionExt.java
>>  Log:
>>  remove redundant method, combination of setImplicitLocking(false) and
> 
> setOrdering(false) will have
> 
>>the same effect
>>
>>  Revision  Changes    Path
>>  No                   revision
>>  No                   revision
>>  1.4.2.7   +32 -32    db-ojb/src/java/org/apache/ojb/odmg/TransactionExt.java
>>
>>  Index: TransactionExt.java
>>  ===================================================================
> 
> 
> 
> Hi,
> 
> One test case still uses this method...
> 
> -- Ilkka
> 
> 
> Index: CircularTest.java
> ===================================================================
> RCS file: /home/cvspublic/db-ojb/src/test/org/apache/ojb/odmg/CircularTest.java,v
> retrieving revision 1.1.2.6
> diff -u -r1.1.2.6 CircularTest.java
> --- CircularTest.java	22 Aug 2005 15:34:50 -0000	1.1.2.6
> +++ CircularTest.java	29 Oct 2005 06:06:59 -0000
> @@ -814,7 +814,7 @@
>          */
>          tx.setOrdering(true);
>          tx.setImplicitLocking(true);
> -        tx.setNoteUserOrder(true);
> +        // tx.setNoteUserOrder(true);
>  
>          database.makePersistent(aaaa);
>          database.makePersistent(aaa);
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Re: cvs commit: db-ojb/src/java/org/apache/ojb/odmg TransactionExt.java

Posted by Ilkka Priha <ip...@norther.org>.
 <arminw <at> apache.org> writes:

> 
> arminw      2005/10/27 11:09:55
> 
>   Modified:    src/java/org/apache/ojb/odmg Tag: OJB_1_0_RELEASE
>                         TransactionExt.java
>   Log:
>   remove redundant method, combination of setImplicitLocking(false) and
setOrdering(false) will have
> the same effect
> 
>   Revision  Changes    Path
>   No                   revision
>   No                   revision
>   1.4.2.7   +32 -32    db-ojb/src/java/org/apache/ojb/odmg/TransactionExt.java
> 
>   Index: TransactionExt.java
>   ===================================================================


Hi,

One test case still uses this method...

-- Ilkka


Index: CircularTest.java
===================================================================
RCS file: /home/cvspublic/db-ojb/src/test/org/apache/ojb/odmg/CircularTest.java,v
retrieving revision 1.1.2.6
diff -u -r1.1.2.6 CircularTest.java
--- CircularTest.java	22 Aug 2005 15:34:50 -0000	1.1.2.6
+++ CircularTest.java	29 Oct 2005 06:06:59 -0000
@@ -814,7 +814,7 @@
         */
         tx.setOrdering(true);
         tx.setImplicitLocking(true);
-        tx.setNoteUserOrder(true);
+        // tx.setNoteUserOrder(true);
 
         database.makePersistent(aaaa);
         database.makePersistent(aaa);



---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org