[GitHub] [netbeans] neilcsmith-net commented on pull request #5379: Fixed erroneous direct form of comparison ("==") for these object typ…

["neilcsmith-net (via GitHub)" <gi...@apache.org>]

neilcsmith-net commented on PR #5379:
URL: https://github.com/apache/netbeans/pull/5379#issuecomment-1408194999

   > The main logic of code is correct, but sometimes may dont work if JVM place created new objects without reusage existing equals objects. Its depending on JVM version and JVM vendor.
   
   And whether they can be bothered to comply with the Java Language Spec?!  String literals are interned.
   
   I don't see an issue in principle with the change, but for each file here we either don't actually have a bug that needs fixing (most likely), or we find an issue where the behaviour does change, in which case we need to verify it's not reliant on the "wrong" behaviour.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists