[GitHub] [superset] nytai commented on a change in pull request #12873: refactor: TemplateParamsEditor.jsx converted from class to functional component

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #12873:
URL: https://github.com/apache/superset/pull/12873#discussion_r568247103



##########
File path: superset-frontend/src/SqlLab/components/TemplateParamsEditor.jsx
##########
@@ -42,23 +42,15 @@ const StyledConfigEditor = styled(ConfigEditor)`
   }
 `;
 
-export default class TemplateParamsEditor extends React.Component {
-  constructor(props) {
-    super(props);
-    const codeText = props.code || '{}';
-    this.state = {
-      codeText,
-      parsedJSON: null,
-      isValid: true,
-    };
-    this.onChange = this.onChange.bind(this);
-  }
-
-  componentDidMount() {
-    this.onChange(this.state.codeText);
-  }
+export const TemplateParamsEditor = props => {

Review comment:
       @etr2460 just an FYI, this doesn't apply to react components. React is able to add the component name to stack traces based on the variable name. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org