(asterixdb) branch master updated: [NO ISSUE][EXT] Match Iceberg type errors on the column name

[al...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 1057e3f85d [NO ISSUE][EXT] Match Iceberg type errors on the column name
1057e3f85d is described below

commit 1057e3f85d97c334c0893d10901b617a614ed638
Author: Ali Alsuliman <al...@gmail.com>
AuthorDate: Fri Oct 2 11:46:58 2026 -0700

    [NO ISSUE][EXT] Match Iceberg type errors on the column name
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details: Iceberg 1.12 renders GeometryType with its CRS, as
    'geometry(OGC:CRS84)' rather than 'geometry', so the two geospatial
    rejection tests that matched on the type name fail on master. Assert
    on the column name, which is ours, and leave the type's rendering to
    Iceberg; the error code is still checked.
    
    Generated-by: Claude Opus 5.5 <no...@anthropic.com>
    Change-Id: I96edec68f68bc1c417eefdf0a9ba8d4c1aeac8f5
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21978
    Tested-by: Ali Alsuliman <al...@gmail.com>
    Reviewed-by: Michael Blow <mb...@apache.org>
    Reviewed-by: Murtadha Hubail <mh...@apache.org>
---
 .../external/input/record/reader/iceberg/IcebergVariantSupportTest.java | 2 +-
 .../asterix/external/parser/IcebergParquetDataParserVariantTest.java    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/iceberg/IcebergVariantSupportTest.java b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/iceberg/IcebergVariantSupportTest.java
index 62a7de21a3..d0541088a3 100644
--- a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/iceberg/IcebergVariantSupportTest.java
+++ b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/iceberg/IcebergVariantSupportTest.java
@@ -82,7 +82,7 @@ public class IcebergVariantSupportTest {
         Schema geo =
                 new Schema(required(1, "id", Types.IntegerType.get()), optional(2, "shape", Types.GeometryType.crs84()),
                         optional(3, "st", Types.StructType.of(optional(4, "area", Types.GeographyType.crs84()))));
-        Map<String, String> columns = Map.of("shape", "geometry' for column 'shape", "st", "for column 'st.area'");
+        Map<String, String> columns = Map.of("shape", "for column 'shape'", "st", "for column 'st.area'");
         for (boolean variantEnabled : new boolean[] { true, false }) {
             columns.forEach((selected, expected) -> {
                 try {
diff --git a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/IcebergParquetDataParserVariantTest.java b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/IcebergParquetDataParserVariantTest.java
index 6729c01be9..c622d49e24 100644
--- a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/IcebergParquetDataParserVariantTest.java
+++ b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/IcebergParquetDataParserVariantTest.java
@@ -87,7 +87,7 @@ public class IcebergParquetDataParserVariantTest {
             Assert.fail("expected GEOMETRY to be rejected");
         } catch (HyracksDataException e) {
             Assert.assertEquals(ErrorCode.UNSUPPORTED_ICEBERG_TYPE.intValue(), e.getErrorCode());
-            Assert.assertTrue(e.getMessage(), e.getMessage().contains("geometry' for column 'shape'"));
+            Assert.assertTrue(e.getMessage(), e.getMessage().contains("for column 'shape'"));
         }
     }