You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/10 04:20:22 UTC
Review Request 12396: Replace ID/timestamp popovers with copy-to-clipboard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-282
https://issues.apache.org/jira/browse/MESOS-282
Repository: mesos
Description
-------
Replace ID/timestamp popovers with copy-to-clipboard
Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
[1] http://zeroclipboard.github.io/ZeroClipboard/
Diffs
-----
src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/12396/diff/
Testing
-------
Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
File Attachments
----------------
Copy ID tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
Copied ID tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
Copy timestamp tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
Copied timestamp tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
Thanks,
Ross Allen
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 10, 2013, 8:24 p.m., Ben Mahler wrote:
> > src/webui/master/static/app.js, line 26
> > <https://reviews.apache.org/r/12396/diff/1/?file=319551#file319551line26>
> >
> > I think the lack of ellipses might be misleading (since we're truncating the IDs, there should be some indication of that).
Seeing the '...' repeated down a long list of resource IDs seemed like overkill, but I agree that this might be misleading. I will see if another character is more appropriate to indicate truncation, otherwise I will revert this chunk.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review22968
-----------------------------------------------------------
On July 10, 2013, 2:20 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 2:20 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 10, 2013, 8:24 p.m., Ben Mahler wrote:
> > src/webui/master/static/app.js, line 127
> > <https://reviews.apache.org/r/12396/diff/1/?file=319551#file319551line127>
> >
> > why $scope instead of scope?
Changed to 'elScope' without the dollar sign.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review22968
-----------------------------------------------------------
On July 12, 2013, 9:38 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 9:38 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ben Mahler <be...@gmail.com>.
> On July 10, 2013, 8:24 p.m., Ben Mahler wrote:
> > src/webui/master/static/framework.html, line 91
> > <https://reviews.apache.org/r/12396/diff/1/?file=319552#file319552line91>
> >
> > Thanks!!
> >
> > Can you also add a link on the slave hostname that jumps up to the slave page?
>
> Ross Allen wrote:
> The hostname doesn't necessarily define the slave though, right? Should this instead be the slave ID?
You're correct, I think visually the hostname is useful, users will want to know the physical machine on which the task is running.
If we wanted to make this a link, we could keep this as hostname but have the underlying link use the slaveID. Would that be confusing?
Alternatively, if it doesn't crowd things, we could add a truncated ID beside the hostname that acts as the link instead.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review22968
-----------------------------------------------------------
On July 12, 2013, 10:26 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:26 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 10, 2013, 8:24 p.m., Ben Mahler wrote:
> > src/webui/master/static/app.js, line 26
> > <https://reviews.apache.org/r/12396/diff/1/?file=319551#file319551line26>
> >
> > I think the lack of ellipses might be misleading (since we're truncating the IDs, there should be some indication of that).
>
> Ross Allen wrote:
> Seeing the '...' repeated down a long list of resource IDs seemed like overkill, but I agree that this might be misleading. I will see if another character is more appropriate to indicate truncation, otherwise I will revert this chunk.
I added the ellipses back since there didn't seem to be a good replacement.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review22968
-----------------------------------------------------------
On July 12, 2013, 10:26 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:26 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ben Mahler <be...@gmail.com>.
> On July 10, 2013, 8:24 p.m., Ben Mahler wrote:
> > src/webui/master/static/framework.html, line 91
> > <https://reviews.apache.org/r/12396/diff/1/?file=319552#file319552line91>
> >
> > Thanks!!
> >
> > Can you also add a link on the slave hostname that jumps up to the slave page?
>
> Ross Allen wrote:
> The hostname doesn't necessarily define the slave though, right? Should this instead be the slave ID?
>
> Ben Mahler wrote:
> You're correct, I think visually the hostname is useful, users will want to know the physical machine on which the task is running.
>
> If we wanted to make this a link, we could keep this as hostname but have the underlying link use the slaveID. Would that be confusing?
> Alternatively, if it doesn't crowd things, we could add a truncated ID beside the hostname that acts as the link instead.
>
> Ross Allen wrote:
> The hostname has previously linked to different URLs depending on which page you're viewing. I'd like to kill that functionality because it's confusing. The slave ID is the canonical URL for a slave, e.g. /slaves/201307151154-234946570-5050-28704-9, and so it would be good to always link slave IDs instead of hostnames.
>
> Any extra info that's helpful for debugging a task can live on the Task's page rather than in this giant table.
Ah yes, that was definitely inconsistent. Thanks for clarifying!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review22968
-----------------------------------------------------------
On July 12, 2013, 10:26 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:26 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 10, 2013, 8:24 p.m., Ben Mahler wrote:
> > src/webui/master/static/framework.html, line 91
> > <https://reviews.apache.org/r/12396/diff/1/?file=319552#file319552line91>
> >
> > Thanks!!
> >
> > Can you also add a link on the slave hostname that jumps up to the slave page?
>
> Ross Allen wrote:
> The hostname doesn't necessarily define the slave though, right? Should this instead be the slave ID?
>
> Ben Mahler wrote:
> You're correct, I think visually the hostname is useful, users will want to know the physical machine on which the task is running.
>
> If we wanted to make this a link, we could keep this as hostname but have the underlying link use the slaveID. Would that be confusing?
> Alternatively, if it doesn't crowd things, we could add a truncated ID beside the hostname that acts as the link instead.
The hostname has previously linked to different URLs depending on which page you're viewing. I'd like to kill that functionality because it's confusing. The slave ID is the canonical URL for a slave, e.g. /slaves/201307151154-234946570-5050-28704-9, and so it would be good to always link slave IDs instead of hostnames.
Any extra info that's helpful for debugging a task can live on the Task's page rather than in this giant table.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review22968
-----------------------------------------------------------
On July 12, 2013, 10:26 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:26 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 10, 2013, 8:24 p.m., Ben Mahler wrote:
> > src/webui/master/static/framework.html, line 91
> > <https://reviews.apache.org/r/12396/diff/1/?file=319552#file319552line91>
> >
> > Thanks!!
> >
> > Can you also add a link on the slave hostname that jumps up to the slave page?
The hostname doesn't necessarily define the slave though, right? Should this instead be the slave ID?
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review22968
-----------------------------------------------------------
On July 12, 2013, 10:26 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:26 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review22968
-----------------------------------------------------------
This is really cool Ross!! I had played around with ZeroClipboard awhile back to add copying of the paths in the browse.html page (users want to copy the paths at the top of the page). Can you add a copy button for that (in a separate review if you like).
Also, looks like you're missing the relevant changes to src/Makefile.am?
src/webui/master/static/app.js
<https://reviews.apache.org/r/12396/#comment46752>
I think the lack of ellipses might be misleading (since we're truncating the IDs, there should be some indication of that).
src/webui/master/static/app.js
<https://reviews.apache.org/r/12396/#comment46755>
Can you add a comment for this new directive?
src/webui/master/static/app.js
<https://reviews.apache.org/r/12396/#comment46753>
Can you add your name?
e.g.
TODO(ssorallen), TODO(rallen), TODO(ross)
src/webui/master/static/app.js
<https://reviews.apache.org/r/12396/#comment46756>
why $scope instead of scope?
src/webui/master/static/app.js
<https://reviews.apache.org/r/12396/#comment46758>
What's this doing? Can you add a comment? Ditto below.
src/webui/master/static/app.js
<https://reviews.apache.org/r/12396/#comment46754>
ditto
src/webui/master/static/app.js
<https://reviews.apache.org/r/12396/#comment46757>
ditto
src/webui/master/static/app.js
<https://reviews.apache.org/r/12396/#comment46759>
Great comment!
src/webui/master/static/framework.html
<https://reviews.apache.org/r/12396/#comment46760>
Thanks!!
Can you also add a link on the slave hostname that jumps up to the slave page?
- Ben Mahler
On July 10, 2013, 2:20 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 2:20 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review23109
-----------------------------------------------------------
- Ross Allen
On July 12, 2013, 10:26 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:26 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 15, 2013, 11:30 p.m., Ben Mahler wrote:
> > src/webui/master/static/app.js, line 26
> > <https://reviews.apache.org/r/12396/diff/4/?file=321098#file321098line26>
> >
> > Any preference for '...' over '…'?
>
> Ross Allen wrote:
> I meant to revert that to a true ellipsis, not three periods. I will re-revert it to an ellipsis.
All set. Can you take one more look and commit if it looks good?
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review23190
-----------------------------------------------------------
On July 16, 2013, 11:41 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 16, 2013, 11:41 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 15, 2013, 11:30 p.m., Ben Mahler wrote:
> > src/webui/master/static/app.js, line 20
> > <https://reviews.apache.org/r/12396/diff/4/?file=321098#file321098line20>
> >
> > Is 'obj' the standard path for binaries?
I used 'obj' because of the HTML5 <object> tag, which is used to embed things like Flash files.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review23190
-----------------------------------------------------------
On July 12, 2013, 10:26 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:26 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 15, 2013, 11:30 p.m., Ben Mahler wrote:
> > src/webui/master/static/app.js, line 26
> > <https://reviews.apache.org/r/12396/diff/4/?file=321098#file321098line26>
> >
> > Any preference for '...' over '…'?
I meant to revert that to a true ellipsis, not three periods. I will re-revert it to an ellipsis.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review23190
-----------------------------------------------------------
On July 12, 2013, 10:26 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:26 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review23190
-----------------------------------------------------------
Ship it!
src/webui/master/static/app.js
<https://reviews.apache.org/r/12396/#comment47050>
Is 'obj' the standard path for binaries?
src/webui/master/static/app.js
<https://reviews.apache.org/r/12396/#comment47049>
Any preference for '...' over '…'?
src/webui/master/static/app.js
<https://reviews.apache.org/r/12396/#comment47051>
Great comments here and in this directive!
- Ben Mahler
On July 12, 2013, 10:26 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:26 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ben Mahler <be...@gmail.com>.
> On July 18, 2013, 6:19 p.m., Ben Mahler wrote:
> >
Hey Ross, I'm having trouble applying this patch:
error: patch failed: src/webui/master/static/mesos.css:43
error: src/webui/master/static/mesos.css: patch does not apply
error: missing binary patch data for 'src/webui/master/static/obj/zeroclipboard-1.1.7.swf'
error: binary patch does not apply to 'src/webui/master/static/obj/zeroclipboard-1.1.7.swf'
error: src/webui/master/static/obj/zeroclipboard-1.1.7.swf: patch does not apply
1. I will grab the zeroclipboard binary (reviewboard appears to eat the binary portion of the diff).
2. As for mesos.css, can you rebase on master and update this diff? Are there reviews this relies on?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review23415
-----------------------------------------------------------
On July 16, 2013, 11:41 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 16, 2013, 11:41 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/#review23415
-----------------------------------------------------------
Ship it!
- Ben Mahler
On July 16, 2013, 11:41 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12396/
> -----------------------------------------------------------
>
> (Updated July 16, 2013, 11:41 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-282
> https://issues.apache.org/jira/browse/MESOS-282
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace ID/timestamp popovers with copy-to-clipboard
>
> Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
>
> This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
>
> Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
>
> [1] http://zeroclipboard.github.io/ZeroClipboard/
>
>
> Diffs
> -----
>
> src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
> src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
> src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12396/diff/
>
>
> Testing
> -------
>
> Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
>
> Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
>
>
> File Attachments
> ----------------
>
> Copy ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
> Copied ID tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
> Copy timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
> Copied timestamp tooltip
> https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/
-----------------------------------------------------------
(Updated July 16, 2013, 11:41 p.m.)
Review request for mesos.
Changes
-------
Revert unintentional conversion from ellipsis to three periods.
Bugs: MESOS-282
https://issues.apache.org/jira/browse/MESOS-282
Repository: mesos
Description
-------
Replace ID/timestamp popovers with copy-to-clipboard
Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
[1] http://zeroclipboard.github.io/ZeroClipboard/
Diffs (updated)
-----
src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/12396/diff/
Testing
-------
Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
File Attachments
----------------
Copy ID tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
Copied ID tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
Copy timestamp tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
Copied timestamp tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
Thanks,
Ross Allen
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/
-----------------------------------------------------------
(Updated July 12, 2013, 10:26 p.m.)
Review request for mesos.
Changes
-------
Add a comment explaining the 'clipboard' directive.
Bugs: MESOS-282
https://issues.apache.org/jira/browse/MESOS-282
Repository: mesos
Description
-------
Replace ID/timestamp popovers with copy-to-clipboard
Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
[1] http://zeroclipboard.github.io/ZeroClipboard/
Diffs (updated)
-----
src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/12396/diff/
Testing
-------
Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
File Attachments
----------------
Copy ID tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
Copied ID tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
Copy timestamp tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
Copied timestamp tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
Thanks,
Ross Allen
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/
-----------------------------------------------------------
(Updated July 12, 2013, 10:18 p.m.)
Review request for mesos.
Changes
-------
Add ZeroClipboard to Makefile.am.
Bugs: MESOS-282
https://issues.apache.org/jira/browse/MESOS-282
Repository: mesos
Description
-------
Replace ID/timestamp popovers with copy-to-clipboard
Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
[1] http://zeroclipboard.github.io/ZeroClipboard/
Diffs (updated)
-----
src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4
src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/12396/diff/
Testing
-------
Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
File Attachments
----------------
Copy ID tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
Copied ID tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
Copy timestamp tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
Copied timestamp tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
Thanks,
Ross Allen
Re: Review Request 12396: Replace ID/timestamp popovers with
copy-to-clipboard
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12396/
-----------------------------------------------------------
(Updated July 12, 2013, 9:38 p.m.)
Review request for mesos.
Bugs: MESOS-282
https://issues.apache.org/jira/browse/MESOS-282
Repository: mesos
Description
-------
Replace ID/timestamp popovers with copy-to-clipboard
Rather than drop IDs and timestamps into popovers, provide buttons that appear on hover that copy full IDs and timestamps to the clipboard.
This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash bridge to access the client's clipboard. The buttons do not appear if the client does not support Flash.
Addresses one point of MESOS-282: "-Change the truncated IDs to show on hover, rather than looking like links and requiring a click"
[1] http://zeroclipboard.github.io/ZeroClipboard/
Diffs (updated)
-----
src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8
src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION
src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/12396/diff/
Testing
-------
Copied/pasted IDs and timestamps wherever they were added in Chrome and in Firefox.
Rendered pages in Firefox with no Flash to confirm buttons do not display and no exceptions are raised.
File Attachments
----------------
Copy ID tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png
Copied ID tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png
Copy timestamp tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png
Copied timestamp tooltip
https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png
Thanks,
Ross Allen