[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #6348: [ISSUE #6346] Support asynchronously notify brokers when their roles has been changed

["RongtongJin (via GitHub)" <gi...@apache.org>]

RongtongJin commented on code in PR #6348:
URL: https://github.com/apache/rocketmq/pull/6348#discussion_r1135373672


##########
controller/src/main/java/org/apache/rocketmq/controller/ControllerManager.java:
##########
@@ -93,6 +100,8 @@ protected <T> RunnableFuture<T> newTaskFor(final Runnable runnable, final T valu
                 return new FutureTaskExt<T>(runnable, value);
             }
         };
+        this.notifyService = new NotifyService();
+        this.notifyService.initialize();

Review Comment:
    How about move  `this.notifyService.initialize();`  to ControllerManager initialize method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org