You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/20 09:45:02 UTC
[GitHub] [iotdb] CloudWise-Lukemiao opened a new pull request #4926: grafana plugin.md and RestService.md added to avoid oom prompt
CloudWise-Lukemiao opened a new pull request #4926:
URL: https://github.com/apache/iotdb/pull/4926
grafana plugin.md and RestService.md added to avoid oom prompt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4926: [IOTDB-2313][REST API Doc] how to avoid GC overhead
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4926:
URL: https://github.com/apache/iotdb/pull/4926#discussion_r788661745
##########
File path: docs/UserGuide/API/RestService.md
##########
@@ -96,6 +109,8 @@ Response parameters:
**Examples:**
+Tip: to avoid oom problems, select * from root.xx.** is not recommended.
Review comment:
```suggestion
Tip: Statements like `select * from root.xx.**` are not recommended because those statements may cause OOM.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4926: [IOTDB-2313][REST API Doc] how to avoid GC overhead
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4926:
URL: https://github.com/apache/iotdb/pull/4926#discussion_r788660762
##########
File path: docs/UserGuide/API/RestService.md
##########
@@ -22,13 +22,26 @@
## RESTful Services
IoTDB's RESTful services can be used for query, write, and management operations, using the OpenAPI standard to define interfaces and generate frameworks.
+###Enable restful services
Review comment:
```suggestion
### Enable RESTful Services
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4926: [IOTDB-2313][REST API Doc] how to avoid GC overhead
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4926:
URL: https://github.com/apache/iotdb/pull/4926#discussion_r788659812
##########
File path: docs/UserGuide/Ecosystem Integration/Grafana Plugin.md
##########
@@ -213,6 +213,8 @@ Here are some examples of valid CONTROL content:
* `group by ([0, 20), 2ms, 3ms), level=1`
+Tip: to avoid oom problems, select * from root is not recommended xx.** This statement is used in the grafana plugin.
Review comment:
```suggestion
Tip: Statements link `select * from root.xx.**` are not recommended because those statements may cause OOM.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4926: [IOTDB-2313][REST API Doc] how to avoid GC overhead
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4926:
URL: https://github.com/apache/iotdb/pull/4926#discussion_r788659812
##########
File path: docs/UserGuide/Ecosystem Integration/Grafana Plugin.md
##########
@@ -213,6 +213,8 @@ Here are some examples of valid CONTROL content:
* `group by ([0, 20), 2ms, 3ms), level=1`
+Tip: to avoid oom problems, select * from root is not recommended xx.** This statement is used in the grafana plugin.
Review comment:
```suggestion
Tip: Statements like `select * from root.xx.**` are not recommended because those statements may cause OOM.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #4926: [IOTDB-2313][REST API Doc] how to avoid GC overhead
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4926:
URL: https://github.com/apache/iotdb/pull/4926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org