You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Ramon Buckland (JIRA)" <ji...@apache.org> on 2009/01/09 10:23:59 UTC

[jira] Created: (CAMEL-1241) Add camel-commons-vfs component

Add camel-commons-vfs component
-------------------------------

                 Key: CAMEL-1241
                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
             Project: Apache Camel
          Issue Type: New Feature
    Affects Versions: 2.0.0
            Reporter: Ramon Buckland
            Assignee: Ramon Buckland
             Fix For: 2.0.0


Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.

The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by Claus Ibsen <cl...@gmail.com>.
On Fri, Jan 23, 2009 at 7:51 AM, Ramon Buckland
<ra...@gmail.com> wrote:
> Just had a thought.
>
> I will put the Generic* into camel-core.. and taylor each patch from there ?
> How does that sound ?
+1 that is fine as well
Its new files into core and thus wont affect anything else.

>
> by the way. Having all of those test cases for the FTP was fantastic. It
> makes me confident in the change as 80% of the tests failed, then minor
> fixes and I had it all working again. So good work to all the test makers.
Well it have taken quite some time to add all these tests. But yeah
its important that we have so many for the file/ftp components.


>
> On Fri, Jan 23, 2009 at 17:33, Ramon Buckland <ra...@gmail.com>wrote:
>
>> > Ramon, what do you say?
>>
>> Sounds Good.
>>
>> I will start with (1) very shortly (about to hop on ferry for home).
>>
>> r.
>>
>



-- 
Claus Ibsen
Apache Camel Committer

Open Source Integration: http://fusesource.com
Blog: http://davsclaus.blogspot.com/

Re: [jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by Ramon Buckland <ra...@gmail.com>.
Just had a thought.

I will put the Generic* into camel-core.. and taylor each patch from there ?
How does that sound ?

by the way. Having all of those test cases for the FTP was fantastic. It
makes me confident in the change as 80% of the tests failed, then minor
fixes and I had it all working again. So good work to all the test makers.

On Fri, Jan 23, 2009 at 17:33, Ramon Buckland <ra...@gmail.com>wrote:

> > Ramon, what do you say?
>
> Sounds Good.
>
> I will start with (1) very shortly (about to hop on ferry for home).
>
> r.
>

Re: [jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by Ramon Buckland <ra...@gmail.com>.
> Ramon, what do you say?

Sounds Good.

I will start with (1) very shortly (about to hop on ferry for home).

r.

Re: [jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by Claus Ibsen <cl...@gmail.com>.
Hi Ramon

Yeah its a big refactor. Looks good.

I do think we should consider java generics (the <T> stuff) for the
Generic* interfaces,
but that is something we can get done later.

Looks great and impressive that all the unit tests still passes.

Since its a big refactor and the diff is huge we should avoid
commiting to FTP/File in the trunk right now.
To avoid the diff getting out of hands. Well this is for the Camel committers!

To get the stuff into the trunk I think we need multiple diffs to
avoid one huge.

So if you can provide diffs in multiple steps. A rough plan like this:

1) Generic* that are used by the FTP component
2) When #1 is commited to triunk and you code is aligned with trunk,
then move on to
3) Move Generic* from camel-ftp to camel-core
4) When #3 is commited to triunk and you code is aligned with trunk,
then move on to
5) You can start on commons-vfs component
6) Then we can take a look at the java generics stuff <T> and get that
done in the right way
7) Refactor File in camel-core to use the new generics
8) Add the new commons-vfs component when its ready and done
9) Add wiki doc for the new commons-vfs component

Ramon, what do you say?



On Fri, Jan 23, 2009 at 7:14 AM, Ramon Buckland
<ra...@gmail.com> wrote:
> Claus (and others)
>
> If you have time, can you please take a cursory glance at my refactoring. I
> think there are a few rough edges which I am hoping to sort out when I
> implement the commons-vfs from the Generic*
>
> The crux of the change so far is as follows.
>
> (a) refactor org.apache.camel.component.file.remote.Remote* so there is a
> base that can be extended.
>
> * All current FTP Remote code resides in
> org.apache.camel.component.file.remote
> * It's parent Abstract base, interface and superclasses are
> org.apache.camel.component.file.Generic*
> * FTP and SFTP are now concrete implementations (no sharing of protocol in
> same class); common code is pushed to Remote* classes.
>
> The next part will be to
>
> (b) Implement commons-vfs undeneath org.apache.camel.component.file.Generic*
> (c) move org.apache.camel.component.file.Generic* to camel-core.
> (d) Have camel-core:file implement / extend
> org.apache.camel.component.file.Generic*
>



-- 
Claus Ibsen
Apache Camel Committer

Open Source Integration: http://fusesource.com
Blog: http://davsclaus.blogspot.com/

Re: [jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by Ramon Buckland <ra...@gmail.com>.
Claus (and others)

If you have time, can you please take a cursory glance at my refactoring. I
think there are a few rough edges which I am hoping to sort out when I
implement the commons-vfs from the Generic*

The crux of the change so far is as follows.

(a) refactor org.apache.camel.component.file.remote.Remote* so there is a
base that can be extended.

* All current FTP Remote code resides in
org.apache.camel.component.file.remote
* It's parent Abstract base, interface and superclasses are
org.apache.camel.component.file.Generic*
* FTP and SFTP are now concrete implementations (no sharing of protocol in
same class); common code is pushed to Remote* classes.

The next part will be to

(b) Implement commons-vfs undeneath org.apache.camel.component.file.Generic*
(c) move org.apache.camel.component.file.Generic* to camel-core.
(d) Have camel-core:file implement / extend
org.apache.camel.component.file.Generic*

Re: [jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by Ramon Buckland <ra...@gmail.com>.
>
>     Attachment: CAMEL-1241_Refactor_S-FTP_to_use_GenericYYY.patch
>


This is patch part 2 for the commons-vfs.

My  next step is

(a) implement commons-vfs (camel-commons-vfs)
(b) Fix CAMEL-1290 (s)ftp problem. I suspect it is not a biggy.

before I do (a) and (b) .. I need a rest.

nighto all.

[jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramon Buckland updated CAMEL-1241:
----------------------------------

    Attachment: CAMEL-1241_part2_all_files.tgz

Yes.. patch hell :-) 

Attached is all relevant new files or changes tar'd up.

And below is the deletions needed

svn rm components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/RemoteFileFilter.java
svn rm components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/strategy/DeleteRemoteFileProcessStrategy.java
svn rm components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/strategy/RemoteFileRenameExclusiveReadLockStrategy.java
svn rm components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/strategy/RemoteFileExpressionRenamer.java
svn rm components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/strategy/RemoteFileProcessStrategyFactory.java
svn rm components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/strategy/RemoteFileRenamer.java
svn rm components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/strategy/RenameRemoteFileProcessStrategy.java
svn rm components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/strategy/NoOpRemoteFileProcessStrategy.java
svn rm components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/strategy/DefaultRemoteFileRenamer.java
svn rm components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/strategy/RemoteFileProcessStrategySupport.java
svn rm components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/AntPathMatcherRemoteFileFilter.java


> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_part2.zip, CAMEL-1241_part2_all_files.tgz, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48939#action_48939 ] 

Ramon Buckland commented on CAMEL-1241:
---------------------------------------

COMPLETE             1) Generic* that are used by the FTP component
COMPLETE             2) When #1 is commited to triunk and you code is aligned with trunk, then move on to
COMPLETE             3) Move Generic* from camel-ftp to camel-core
WAITING COMMIT  4) When #3 is commited to triunk and you code is aligned with trunk, then move on to
INPROGRESS        5) You can start on commons-vfs component
INPROGRESS        6) Then we can take a look at the java generics stuff <T> and get that done in the right way
Claus STARTED    7) Refactor File in camel-core to use the new generics            
                                   8) Add the new commons-vfs component when its ready and done
                                   9) Add wiki doc for the new commons-vfs component

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_Refactor_S-FTP_to_use_GenericYYY.patch, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramon Buckland updated CAMEL-1241:
----------------------------------

    Attachment: CAMEL-1241_Refactor_S-FTP_to_use_GenericYYY.patch

This patch implements the GenericFile* classes / ifaces across the original Remote* classes.

Specifically, the following occurs with this patch.

(a) minor modifications to the new Generic* classes in camel-core (to support RemoteFile style endpoints)
(b) added a method to DefaultEndpoint to obtain the "protocol" in the uri (so we can re-lookup our META-INF file to find default strategy)
(c) refactored all the FTP tests to use target/ftpserver/home as the ftp server root, instead of res/

This patch readies the camel-core / camel-ftp (file based) so we can now implement commons-vfs into the fray.

All Tests are working as of diff revision.

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_Refactor_S-FTP_to_use_GenericYYY.patch, commons-vfs-changes-part1.file-refactoring.diff
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48947#action_48947 ] 

Claus Ibsen commented on CAMEL-1241:
------------------------------------

@Ramon

Patch hell for *camel-ftp*.
When you do delete/rename and all sort of stuff it gets messy.

Can you send the src files in a .zip as plain .java files? Only for *camel-ftp*

The camel-core is okay, only the AntPathMatcherGenericFileFilter is missing. Could you send it as well?

Sorry but svn patches gets messy when there are to much add/delete/rename going on.
And I guess the patch file should be ordered as well, I have a kinda deadlock where files patches look for a new class that does not exists since its being renamed and patched later in the file.

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_part2.zip, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48920#action_48920 ] 

Claus Ibsen commented on CAMEL-1241:
------------------------------------

Thanks for the patch.

I renamed the sorter to be GenericXXX as well so they all are starting with Generic. Then its easier to spot.
And also fixed the checkstyle issues. Please dont auto wrap the code. It gets ugly. 

We should add generics to these interfaces, later. (the <T> stuff.)
Its easier to do when we refactor the FTP component to use these base classes.



> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, commons-vfs-changes-part1.file-refactoring.diff
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48613#action_48613 ] 

Ramon Buckland commented on CAMEL-1241:
---------------------------------------

I have been investigating how this change will impact / change the recent refactoring work for camel-file and camel-ftp.

There is a set of interfaces and some implementation largely named Remote* .. for example RemoteFileOperation.

This work will refactor some of these classes, making interfaces and sorting out some other interfaces.

I propose the following.

Pull-up a more generic set of interface and base classes, called Generic*.
-   These Generic iface/classes will be 90%-95% of the current Remote.. so largely a renaming.
- What is "Remote" specific, such as Hostname, will come to a lower "remote" implementation

commons-vfs will hang off the Generic and the existing camel-file can also hang off this generic set of classes.

Any comments ?

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48618#action_48618 ] 

Claus Ibsen commented on CAMEL-1241:
------------------------------------

+1

Yeah when we poll the interfaces from camel-ftp into camel-core they need a rename to be generic, so GenericFileOperation will do.

I just wanted to be sure that commons-vfs can integrate with this approach using the interfaces from camel-ftp allowing us to have much more shared code for the different file based transports
- java.io.File
- regular FTP
- SFTP
- and now commons-vfs




> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramon Buckland updated CAMEL-1241:
----------------------------------

    Attachment: commons-vfs-changes-part1.file-refactoring.diff

Attached is the refactoring to "extract out" the "generic File stuff" from the RemoteFile* implementation.

All the tests are working as they were with this refactoring.

Now I will create a commons-vfs implementation underneath the Generic*

Note, I am uploading this now so that other can see what I am currently doing, get an idea for it.

Hopefully I will have commons-vfs completed by tomorrow, at which time I will supply the new patch that is EVERYTHING including this attached one.

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: commons-vfs-changes-part1.file-refactoring.diff
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48943#action_48943 ] 

Ramon Buckland commented on CAMEL-1241:
---------------------------------------

In this patch release (CAMEL-1241_part2.zip)  is as follows 

* Included now is the patch fixing CAMEL-1290
* Patch files

============== The patch Files ===============
1.  For camel-core  (/trunk$ svn diff camel-core)
    File: CAMEL-1241_part2_camel-core.patch

=== For 2, use either ===
    Claus, you mentioned patching in through IDEA and I know eclipse roots projects at the pom.xml so I figured the patch is needed
    at that level (2b). Both are supplied. but have identical changes (of course)

2a. For camel-ftp   Generated at the project root.
    (/trunk$ svn diff components/camel-ftp)
    File: CAMEL-1241_part2_camel-ftp.patch
OR

2b. For camel-ftp   Generated at components/camel-ftp
    (/trunk/components$ svn diff camel-ftp)
    File: CAMEL-1241_part2_camel-ftp_relative_dir.patch


> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_part2.zip, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-1241.
--------------------------------

    Resolution: Won't Fix
      Assignee:     (was: Ramon Buckland)

commons-vfs is a dead project

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>             Fix For: Future
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_part2.zip, CAMEL-1241_part2_all_files.tgz, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work logged: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#action_36803 ]

Ramon Buckland logged work on CAMEL-1241:
-----------------------------------------

                Author: Ramon Buckland
            Created on: 25/Jan/09 05:10 PM
            Start Date: 25/Jan/09 05:09 PM
    Worklog Time Spent: 1 day, 2 hours 
      Work Description: lot's of work resolving the complexities of the generics.

Issue Time Tracking
-------------------

            Time Spent: 1 day, 2 hours
    Remaining Estimate: 0 minutes

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_Refactor_S-FTP_to_use_GenericYYY.patch, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on CAMEL-1241 started by Ramon Buckland.

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramon Buckland updated CAMEL-1241:
----------------------------------

    Attachment: CAMEL-1241_part2.zip

Fixed the getUriEndpointProtocol (removed from DefaultEndpoint) 
and changed to GenericFileEndpoint.getScheme()

Broke patch into two 
   camel-core
   camel-ftp   (absolute or relative directory patch supplied)

Both need to be applied



> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_part2.zip, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-1241:
-------------------------------

    Fix Version/s:     (was: 2.0.0)
                   2.1.0

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.1.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_part2.zip, CAMEL-1241_part2_all_files.tgz, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48619#action_48619 ] 

Ramon Buckland commented on CAMEL-1241:
---------------------------------------

Yes, it appears with the minor changes that the new 2.0 changes can be adapted without much hassle for more file goodness.

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=54820#action_54820 ] 

Claus Ibsen commented on CAMEL-1241:
------------------------------------

I do not think Ramon is working on this anymore.

Anyone feel free to take over and implement a camel-vfs component

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.2.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_part2.zip, CAMEL-1241_part2_all_files.tgz, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramon Buckland updated CAMEL-1241:
----------------------------------

    Attachment:     (was: CAMEL-1241_Refactor_S-FTP_to_use_GenericYYY-v2.patch)

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramon Buckland updated CAMEL-1241:
----------------------------------

    Attachment: CAMEL-1241.part_1_port_Generic_to_camel-core.diff


As per Claus' suggestion. This is part 1  of the list below .. 

So if you can provide diffs in multiple steps. A rough plan like this:

{quote}
1) Generic* that are used by the FTP component
2) When #1 is commited to triunk and you code is aligned with trunk,
then move on to
3) Move Generic* from camel-ftp to camel-core
4) When #3 is commited to triunk and you code is aligned with trunk,
then move on to
5) You can start on commons-vfs component
6) Then we can take a look at the java generics stuff <T> and get that
done in the right way
7) Refactor File in camel-core to use the new generics
8) Add the new commons-vfs component when its ready and done
9) Add wiki doc for the new commons-vfs component
{quote}


> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, commons-vfs-changes-part1.file-refactoring.diff
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramon Buckland updated CAMEL-1241:
----------------------------------

    Attachment: CAMEL-1241_Refactor_S-FTP_to_use_GenericYYY-v2.patch

Fixed the patch (I had local uber pom.xml changes for future work not yet required) .. removed these.

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_Refactor_S-FTP_to_use_GenericYYY-v2.patch, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48929#action_48929 ] 

Ramon Buckland commented on CAMEL-1241:
---------------------------------------

Thanks Claus, I will integrate your changes on my trunk now and get it all working.

In my local working tree, I will be making sure that the FULL suit of tests for Camel pass before I push through the patch; as you say, File is used in a lot of places already. (as I also have seen).

Yes, you are right the SFTP API is a little different. I did start on pushing common "code" up one level below a remote implementation. But I'll revise again shortly.

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, commons-vfs-changes-part1.file-refactoring.diff
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48928#action_48928 ] 

Claus Ibsen commented on CAMEL-1241:
------------------------------------

Ramon I have done some modifications to the camel-core in trunk.

I stated on #7 to get a due diligence test of the GenericXXX classes. I created a NewFileXXX that is the regular file integrating using the GenericXXX classes.
I basically got it working with both the consumer and the producer but have only tested it using two new unit tests. At present time I want it to not interfer with the regular File component as its used heavily in entire Camel for unit testing. So the NewFileXX must be rock solid before we let it replace the old one.

There a some TODOs in the code for stuff to consider and check upon. I do think the GenericFileOperations might could change to pass in the GenericFile instead of the T type I have now. But more work on that will tell.

Also from the FTP point of with, as I have added generics to it, I would like to see especially the SFTPConsumer if it can use it. I kinda remember it had a sucky API representing the remote FTP file.




> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, commons-vfs-changes-part1.file-refactoring.diff
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48948#action_48948 ] 

Claus Ibsen commented on CAMEL-1241:
------------------------------------

Oh btw IDEA can do the relative/base stuff. There is a strip trailing directories you can adjust.

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_part2.zip, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48931#action_48931 ] 

Ramon Buckland commented on CAMEL-1241:
---------------------------------------

I am about another hour or two from having the ftp/sftp using the new GenericXX components. From there I will add in the commons-vfs. Expect a patch soon.

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, commons-vfs-changes-part1.file-refactoring.diff
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Ramon Buckland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramon Buckland updated CAMEL-1241:
----------------------------------

    Attachment:     (was: CAMEL-1241_Refactor_S-FTP_to_use_GenericYYY.patch)

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48620#action_48620 ] 

Claus Ibsen commented on CAMEL-1241:
------------------------------------

@Ramon

That is fantastic. Makes me smile the rest of the day :)

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Chris Love (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=54776#action_54776 ] 

Chris Love commented on CAMEL-1241:
-----------------------------------

What work has been done on the vfs component?  Any source for cifs writes or reads?

Thanks in advance

> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.2.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, CAMEL-1241_part2.zip, CAMEL-1241_part2_all_files.tgz, commons-vfs-changes-part1.file-refactoring.diff
>
>          Time Spent: 1 day, 2 hours
>  Remaining Estimate: 0 minutes
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1241) Add camel-commons-vfs component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48930#action_48930 ] 

Claus Ibsen commented on CAMEL-1241:
------------------------------------

I updated it yet again with a minor fix to add newfile as a componet scheme so its possible to test it by replacing "file://" with "newfile://".

The reason is so file and newfile can reside side by side until its rock solid and can replace file.

Ramon do you have any changes to the file component? If not I would like to get that sorted out. I would advice that you focus on the new commons-vfs component that you originally wanted to add. Or you can start refactoring the FTP/SFTP component to use GenericXXX.

What do you say?




> Add camel-commons-vfs component
> -------------------------------
>
>                 Key: CAMEL-1241
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1241
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1241.part_1_port_Generic_to_camel-core.diff, commons-vfs-changes-part1.file-refactoring.diff
>
>
> Add a new component camel-commons-vfs which utilises the commons-vfs library providing access to zip,jar,tgz,cifs,ftp and many other wonderful "file" type resources.
> The component will go into camel 2.0 as the new camel-file and camel-ftp components have been re-written to support a better model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.