You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mjsax <gi...@git.apache.org> on 2016/01/13 18:13:43 UTC
[GitHub] flink pull request: [FLINK-2586] Unstable Storm Compatibility Test...
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1502
[FLINK-2586] Unstable Storm Compatibility Tests
- added BLOCKING flag to FlinkLocalCluster
- added NullTerminatingSpout and SpoutOutputCollectorObserver plus tests
- reworked test accordingly
- set BLOCKING flag for ITCases
- make infinite spouts finite using NullTerminatingSpout
- removed sleep time to get stable
- fixed bug in BoltSplitITCase and SpoutSplitITCase
- exception in VerifyAndEnrichBolt is swallowed and test would not fail (replaced by errorFlag)
- reduced sleep-time in BoltSplitITCase and SpoutSplitITCase to reduce testing time
- fixed WrapperSetupHelperTest
- reworked to origianl version with more than two inputs
(was limite to two inputs because more the two inputs per bolt was not supported in between, which is now fixed)
minor code cleanup (removed unused imports, indenting, etc.)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink flink-2586-unstable-storm-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1502.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1502
----
commit ee830a62ae77e808b442e28acdd2a71b04758362
Author: mjsax <mj...@apache.org>
Date: 2016-01-13T16:47:32Z
[FLINK-2586] Unstable Storm Compatibility Tests
- added BLOCKING flag to FlinkLocalCluster
- added NullTerminatingSpout and SpoutOutputCollectorObserver plus tests
- reworked test accordingly
- set BLOCKING flag for ITCases
- make infinite spouts finite using NullTerminatingSpout
- removed sleep time to get stable
- fixed bug in BoltSplitITCase and SpoutSplitITCase
- exception in VerifyAndEnrichBolt is swallowed and test would not fail (replaced by errorFlag)
- reduced sleep-time in BoltSplitITCase and SpoutSplitITCase to reduce testing time
- fixed WrapperSetupHelperTest
- reworked to origianl version with more than two inputs
(was limite to two inputs because more the two inputs per bolt was not supported in between, which is now fixed)
minor code cleanup (removed unused imports, indenting, etc.)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2586] Unstable Storm Compatibility Test...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1502#issuecomment-172873995
@tillrohrmann I was not aware of that. Thanks for letting me know. Will do so in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2586] Unstable Storm Compatibility Test...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1502#issuecomment-172871995
@mjsax, most likely it happened by accident but it's good practice to separate the git commit subject from the body by inserting a line break. That way, git can show you a nice one line git history `git log --oneline` without seeing the body of the commit message. Also some other tools format the git log nicely if one follows this rule.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2586] Unstable Storm Compatibility Test...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1502#issuecomment-171777377
Thank you for addressing this.
Looks good to me, +1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2586] Unstable Storm Compatibility Test...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1502
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2586] Unstable Storm Compatibility Test...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1502#issuecomment-171778290
Thanks. Will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---