You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Stephan Ewen <se...@apache.org> on 2014/08/13 21:44:08 UTC
Remove example jars that cannot run self-contained
I suggest to remove all example jars that cannot run without parameters -
while keeping the example source code, of course.
The purpose of the jar files is that the users can try out the examples
directly. That only works if the examples come with pre-packages test data
and do not require a complicated set of parameters. (Thanks Fabian for
bringing most of the examples into that state)
Works out-of-the-box:
- WordCount
- KMeans
- ConnectedConponents
- WebLogAnalysis
- TriangleEnumeration
- Linear Regression
- PageRank
Does not work out-of-the-box:
- All scala examples (not set up parameter free)
- Relational queries (missing test data)
Those could be synced with the others for the next minor release.
Re: Remove example jars that cannot run self-contained
Posted by Robert Metzger <rm...@apache.org>.
I committed Stephan's change into the "release-0.6" and "master" branch:
https://github.com/apache/incubator-flink/commit/18bcfdf0f502b42ba58a7e04043a852ce02a6554#diff-d41d8cd98f00b204e9800998ecf8427e
.
On Wed, Aug 13, 2014 at 9:53 PM, Till Rohrmann <tr...@apache.org> wrote:
> I agree with Stephan. Sometimes it is even necessary to look into the
> source code to figure out what the parameter is used for or what the
> required format of the data is.
>
> So +1 for self-contained examples
> On Aug 13, 2014 9:44 PM, "Stephan Ewen" <se...@apache.org> wrote:
>
> > I suggest to remove all example jars that cannot run without parameters -
> > while keeping the example source code, of course.
> >
> > The purpose of the jar files is that the users can try out the examples
> > directly. That only works if the examples come with pre-packages test
> data
> > and do not require a complicated set of parameters. (Thanks Fabian for
> > bringing most of the examples into that state)
> >
> >
> > Works out-of-the-box:
> >
> > - WordCount
> > - KMeans
> > - ConnectedConponents
> > - WebLogAnalysis
> > - TriangleEnumeration
> > - Linear Regression
> > - PageRank
> >
> >
> > Does not work out-of-the-box:
> >
> > - All scala examples (not set up parameter free)
> > - Relational queries (missing test data)
> >
> >
> > Those could be synced with the others for the next minor release.
> >
>
Re: Remove example jars that cannot run self-contained
Posted by Till Rohrmann <tr...@apache.org>.
I agree with Stephan. Sometimes it is even necessary to look into the
source code to figure out what the parameter is used for or what the
required format of the data is.
So +1 for self-contained examples
On Aug 13, 2014 9:44 PM, "Stephan Ewen" <se...@apache.org> wrote:
> I suggest to remove all example jars that cannot run without parameters -
> while keeping the example source code, of course.
>
> The purpose of the jar files is that the users can try out the examples
> directly. That only works if the examples come with pre-packages test data
> and do not require a complicated set of parameters. (Thanks Fabian for
> bringing most of the examples into that state)
>
>
> Works out-of-the-box:
>
> - WordCount
> - KMeans
> - ConnectedConponents
> - WebLogAnalysis
> - TriangleEnumeration
> - Linear Regression
> - PageRank
>
>
> Does not work out-of-the-box:
>
> - All scala examples (not set up parameter free)
> - Relational queries (missing test data)
>
>
> Those could be synced with the others for the next minor release.
>