[GitHub] [beam] jrmccluskey commented on a change in pull request #15815: [BEAM-13130] Remove persistent references to stateKeyReaders

[GitBox <gi...@apache.org>]

jrmccluskey commented on a change in pull request #15815:
URL: https://github.com/apache/beam/pull/15815#discussion_r737617649



##########
File path: sdks/go/pkg/beam/core/runtime/harness/statemgr.go
##########
@@ -107,10 +105,6 @@ func (s *ScopedStateReader) Close() error {
 	s.mu.Lock()
 	s.closed = true
 	s.mgr = nil
-	for _, r := range s.opened {
-		r.Close() // force close all opened readers

Review comment:
       The open streams get closed in postInvoke() in the ParDo code and we could add some extra handling to the fail() method to clear out the side input streams too (e.g. check if the side input list is non-nil and call Reset() for them if not.) It's also worth nothing that there currently isn't a deferred usage for the ScopedStateReader's Close() function that I can find. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org