You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ris-tlp (via GitHub)" <gi...@apache.org> on 2025/10/25 10:46:54 UTC

[PR] Fab provider SQLA1 -> SQLA2: Mypy fix core_api/routes/public/pools.py [airflow]

ris-tlp opened a new pull request, #57235:
URL: https://github.com/apache/airflow/pull/57235

   Fixes 2 MyPy errors shown below in `api_fastapi/core_api/routes/public/pools.py`.
   Part of #56735 .
   
   CursorResult casts for the rowcount MyPy error were done according to the recommended approach in the [SQLAlchemy 2.0 changelog](https://docs.sqlalchemy.org/en/20/changelog/changelog_20.html#change-0651b868cdc88d28c57469affceaf05f) and mentioned in an issue [here](https://github.com/sqlalchemy/sqlalchemy/issues/12913). If cast() is not the preferred approach for fixing these errors, I can add `type:ignore[attr-defined]` instead. 
   
   <img width="1203" height="258" alt="image" src="https://github.com/user-attachments/assets/8a5336fa-518d-4f20-aa5a-8706459fb46f" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fab provider SQLA1 -> SQLA2: Mypy fix core_api/routes/public/pools.py [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #57235:
URL: https://github.com/apache/airflow/pull/57235


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org