[GitHub] [incubator-doris] morningman commented on a diff in pull request #9408: [Bug][Vectorized] Fix insert bimmap column with nullable column

[GitBox <gi...@apache.org>]

morningman commented on code in PR #9408:
URL: https://github.com/apache/incubator-doris/pull/9408#discussion_r866696033


##########
be/src/vec/sink/vtablet_sink.h:
##########
@@ -102,6 +102,10 @@ class VOlapTableSink : public OlapTableSink {
     Status _validate_data(RuntimeState* state, vectorized::Block* block, Bitmap* filter_bitmap,
                           int* filtered_rows, bool* stop_processing);
 
+    // some output column of output expr may have different nullable property with dest slot desc
+    // so here need to do the convert operation6

Review Comment:
   ```suggestion
       // so here need to do the convert operation
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org