You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2019/03/08 09:42:02 UTC
Re: Review Request 65847: Fixed allocator test `QuotaAbsentFramework`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65847/#review213550
-----------------------------------------------------------
Bad review!
Reviews applied: [65847, 65845, 65844, 65821, 65820, 65819, 66045, 66044, 66043]
Error:
2019-03-08 09:42:01 URL:https://reviews.apache.org/r/65819/diff/raw/ [10503/10503] -> "65819.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:1574
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply
- Mesos Reviewbot
On Feb. 28, 2018, 9 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65847/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 9 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Michael Park.
>
>
> Bugs: MESOS-8456
> https://issues.apache.org/jira/browse/MESOS-8456
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `QuotaAbsentFramework` assumes the coarse grained nature
> of second stage resource allocation. This is no longer
> true given #65821. This patch fixes the test by asserting
> the allocation in terms of quantity.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4
>
>
> Diff: https://reviews.apache.org/r/65847/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>