You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by wa...@apache.org on 2022/06/07 05:06:59 UTC
[incubator-devlake] branch main updated: fix: fix lint check failed
This is an automated email from the ASF dual-hosted git repository.
warren pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/main by this push:
new cb8dd6f4 fix: fix lint check failed
cb8dd6f4 is described below
commit cb8dd6f424a553ea96f8e0202d0d106cc8390197
Author: Nddtfjiang <jz...@qq.com>
AuthorDate: Tue Jun 7 03:02:15 2022 +0000
fix: fix lint check failed
ineffectual assignment to err (ineffassign)
SA4009: argument subtasks is overwritten before first use (staticcheck)
SA4009(related information): assignment to subtasks (staticcheck)
Nddtfjiang <zh...@merico.dev>
---
plugins/ae/ae.go | 2 +-
plugins/dbt/dbt.go | 2 +-
plugins/feishu/feishu.go | 2 +-
plugins/github/github.go | 2 +-
plugins/gitlab/gitlab.go | 4 ++--
plugins/jenkins/jenkins.go | 2 +-
plugins/jira/jira.go | 2 +-
plugins/refdiff/refdiff.go | 2 +-
plugins/tapd/tapd.go | 4 ++--
runner/directrun.go | 9 +++++----
10 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/plugins/ae/ae.go b/plugins/ae/ae.go
index f55262c5..e2bad02f 100644
--- a/plugins/ae/ae.go
+++ b/plugins/ae/ae.go
@@ -108,7 +108,7 @@ func main() {
projectId := aeCmd.Flags().IntP("project-id", "p", 0, "ae project id")
_ = aeCmd.MarkFlagRequired("project-id")
aeCmd.Run = func(cmd *cobra.Command, args []string) {
- runner.DirectRun(cmd, args, PluginEntry, []string{}, map[string]interface{}{
+ runner.DirectRun(cmd, args, PluginEntry, map[string]interface{}{
"projectId": *projectId,
})
}
diff --git a/plugins/dbt/dbt.go b/plugins/dbt/dbt.go
index b0a4be40..c3ce3d3e 100644
--- a/plugins/dbt/dbt.go
+++ b/plugins/dbt/dbt.go
@@ -97,7 +97,7 @@ func main() {
for k, v := range projectVars {
projectVarsConvert[k] = v
}
- runner.DirectRun(cmd, args, PluginEntry, []string{}, map[string]interface{}{
+ runner.DirectRun(cmd, args, PluginEntry, map[string]interface{}{
"projectPath": *projectPath,
"projectName": *projectName,
"projectTarget": *projectTarget,
diff --git a/plugins/feishu/feishu.go b/plugins/feishu/feishu.go
index 3b1635d1..b5a5828f 100644
--- a/plugins/feishu/feishu.go
+++ b/plugins/feishu/feishu.go
@@ -90,7 +90,7 @@ func main() {
numOfDaysToCollect := feishuCmd.Flags().IntP("numOfDaysToCollect", "n", 8, "feishu collect days")
_ = feishuCmd.MarkFlagRequired("numOfDaysToCollect")
feishuCmd.Run = func(cmd *cobra.Command, args []string) {
- runner.DirectRun(cmd, args, PluginEntry, []string{}, map[string]interface{}{
+ runner.DirectRun(cmd, args, PluginEntry, map[string]interface{}{
"numOfDaysToCollect": *numOfDaysToCollect,
})
}
diff --git a/plugins/github/github.go b/plugins/github/github.go
index e0806c6f..765a4d28 100644
--- a/plugins/github/github.go
+++ b/plugins/github/github.go
@@ -144,7 +144,7 @@ func main() {
_ = githubCmd.MarkFlagRequired("repo")
githubCmd.Run = func(cmd *cobra.Command, args []string) {
- runner.DirectRun(cmd, args, PluginEntry, []string{}, map[string]interface{}{
+ runner.DirectRun(cmd, args, PluginEntry, map[string]interface{}{
"owner": *owner,
"repo": *repo,
})
diff --git a/plugins/gitlab/gitlab.go b/plugins/gitlab/gitlab.go
index e9a9f77d..3f9ecc15 100644
--- a/plugins/gitlab/gitlab.go
+++ b/plugins/gitlab/gitlab.go
@@ -40,7 +40,7 @@ func main() {
panic(err)
}
wsList := make([]*models.TapdWorkspace, 0)
- err = db.Find(&wsList, "parent_id = ?", 59169984).Error
+ err = db.First(&wsList, "parent_id = ?", 59169984).Error
if err != nil {
panic(err)
}
@@ -53,7 +53,7 @@ func main() {
38496185,
}
for _, v := range projectList {
- runner.DirectRun(gitlabCmd, args, PluginEntry, []string{}, map[string]interface{}{
+ runner.DirectRun(gitlabCmd, args, PluginEntry, map[string]interface{}{
"projectId": v,
})
}
diff --git a/plugins/jenkins/jenkins.go b/plugins/jenkins/jenkins.go
index b1e2d6a8..4edc89df 100644
--- a/plugins/jenkins/jenkins.go
+++ b/plugins/jenkins/jenkins.go
@@ -102,7 +102,7 @@ var PluginEntry Jenkins //nolint
func main() {
jenkinsCmd := &cobra.Command{Use: "jenkins"}
jenkinsCmd.Run = func(cmd *cobra.Command, args []string) {
- runner.DirectRun(cmd, args, PluginEntry, []string{}, map[string]interface{}{})
+ runner.DirectRun(cmd, args, PluginEntry, map[string]interface{}{})
}
runner.RunCmd(jenkinsCmd)
}
diff --git a/plugins/jira/jira.go b/plugins/jira/jira.go
index 37313972..1e0d23fb 100644
--- a/plugins/jira/jira.go
+++ b/plugins/jira/jira.go
@@ -193,7 +193,7 @@ func main() {
_ = cmd.MarkFlagRequired("connection")
_ = cmd.MarkFlagRequired("board")
cmd.Run = func(c *cobra.Command, args []string) {
- runner.DirectRun(c, args, PluginEntry, []string{}, map[string]interface{}{
+ runner.DirectRun(c, args, PluginEntry, map[string]interface{}{
"connectionId": *connectionId,
"boardId": *boardId,
})
diff --git a/plugins/refdiff/refdiff.go b/plugins/refdiff/refdiff.go
index b2a2ef44..881feab1 100644
--- a/plugins/refdiff/refdiff.go
+++ b/plugins/refdiff/refdiff.go
@@ -88,7 +88,7 @@ func main() {
_ = refdiffCmd.MarkFlagRequired("old-ref")
refdiffCmd.Run = func(cmd *cobra.Command, args []string) {
- runner.DirectRun(cmd, args, PluginEntry, []string{}, map[string]interface{}{
+ runner.DirectRun(cmd, args, PluginEntry, map[string]interface{}{
"repoId": repoId,
"pairs": []map[string]string{
{
diff --git a/plugins/tapd/tapd.go b/plugins/tapd/tapd.go
index c74d278d..7f81e092 100644
--- a/plugins/tapd/tapd.go
+++ b/plugins/tapd/tapd.go
@@ -217,13 +217,13 @@ func main() {
panic(err)
}
wsList := make([]*models.TapdWorkspace, 0)
- err = db.Find(&wsList, "parent_id = ?", 59169984).Error
+ err = db.First(&wsList, "parent_id = ?", 59169984).Error //nolint TODO: fix the unused err
if err != nil {
panic(err)
}
for _, v := range wsList {
*workspaceId = v.ID
- runner.DirectRun(c, args, PluginEntry, []string{}, map[string]interface{}{
+ runner.DirectRun(c, args, PluginEntry, map[string]interface{}{
"connectionId": *connectionId,
"workspaceId": *workspaceId,
"companyId": *companyId,
diff --git a/runner/directrun.go b/runner/directrun.go
index e2343cd4..86d4609c 100644
--- a/runner/directrun.go
+++ b/runner/directrun.go
@@ -19,14 +19,15 @@ package runner
import (
"context"
+ "os"
+ "os/signal"
+ "syscall"
+
"github.com/apache/incubator-devlake/config"
"github.com/apache/incubator-devlake/logger"
"github.com/apache/incubator-devlake/migration"
"github.com/apache/incubator-devlake/plugins/core"
"github.com/spf13/cobra"
- "os"
- "os/signal"
- "syscall"
)
func RunCmd(cmd *cobra.Command) {
@@ -42,7 +43,7 @@ func RunCmd(cmd *cobra.Command) {
// args: command line arguments
// pluginTask: specific built-in plugin, for example: feishu, jira...
// options: plugin config
-func DirectRun(cmd *cobra.Command, args []string, pluginTask core.PluginTask, subtasks []string, options map[string]interface{}) {
+func DirectRun(cmd *cobra.Command, args []string, pluginTask core.PluginTask, options map[string]interface{}) {
tasks, err := cmd.Flags().GetStringSlice("subtasks")
if err != nil {
panic(err)