You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/09/17 16:45:47 UTC

[GitHub] benmccrea edited a comment on issue #1400: [DO NOT MERGE] - Fix BQ27Z561 and LP5523 I2C repeated-stop operations

benmccrea edited a comment on issue #1400: [DO NOT MERGE] - Fix BQ27Z561 and LP5523 I2C repeated-stop operations
URL: https://github.com/apache/mynewt-core/pull/1400#issuecomment-422086869
 
 
   @ccollins476ad I looked further into this and I think my changes in this PR are just a workaround for a bug in `hal_i2c_master_write`. In the case where `last_op` is 0 and an error takes place, `EVENTS_STOPPED=0` doesn't ever happen, and I think that results in the bus being left without a stop condition. 
   
   I'll try this out and let you know if it seems to fix the hang in the same way. Any comments on this approach?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services