You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/08/15 12:01:22 UTC
Review Request 61654: Added a stream ID to resource provider manager
connections.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61654/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jie Yu.
Repository: mesos
Description
-------
To be able to resolve problems with resource providers that erroneously
try to 'SUBSCRIBE' multiple times a unique stream ID is associated with
a connected resource provider. Resource providers are expected to send
this stream ID with every call that isn't a 'SUBSCRIBE' call.
Diffs
-----
src/resource_provider/manager.cpp 44e1576d4462295d404429d51682134306047462
Diff: https://reviews.apache.org/r/61654/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 61654: Added a stream ID to resource provider
manager connections.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61654/#review182941
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61275, 61654]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 15, 2017, 12:06 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61654/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 12:06 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-7469
> https://issues.apache.org/jira/browse/MESOS-7469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To be able to resolve problems with resource providers that erroneously
> try to 'SUBSCRIBE' multiple times a unique stream ID is associated with
> a connected resource provider. Resource providers are expected to send
> this stream ID with every call that isn't a 'SUBSCRIBE' call.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 44e1576d4462295d404429d51682134306047462
>
>
> Diff: https://reviews.apache.org/r/61654/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 61654: Added a stream ID to resource provider
manager connections.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61654/#review183087
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 15, 2017, 12:06 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61654/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 12:06 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-7469
> https://issues.apache.org/jira/browse/MESOS-7469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To be able to resolve problems with resource providers that erroneously
> try to 'SUBSCRIBE' multiple times a unique stream ID is associated with
> a connected resource provider. Resource providers are expected to send
> this stream ID with every call that isn't a 'SUBSCRIBE' call.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 44e1576d4462295d404429d51682134306047462
>
>
> Diff: https://reviews.apache.org/r/61654/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 61654: Added a stream ID to resource provider
manager connections.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61654/
-----------------------------------------------------------
(Updated Aug. 15, 2017, 2:06 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Bugs: MESOS-7469
https://issues.apache.org/jira/browse/MESOS-7469
Repository: mesos
Description
-------
To be able to resolve problems with resource providers that erroneously
try to 'SUBSCRIBE' multiple times a unique stream ID is associated with
a connected resource provider. Resource providers are expected to send
this stream ID with every call that isn't a 'SUBSCRIBE' call.
Diffs
-----
src/resource_provider/manager.cpp 44e1576d4462295d404429d51682134306047462
Diff: https://reviews.apache.org/r/61654/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht