You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2024/05/15 18:51:15 UTC
[PR] fix: Ensure nanoarrow.hpp compiles on gcc 4.8 [arrow-nanoarrow]
paleolimbot opened a new pull request, #472:
URL: https://github.com/apache/arrow-nanoarrow/pull/472
Apparently gcc4.8 takes issue with the use of braces in some places and does not provide `is_trivially_copyable()` or `std::size()` 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure nanoarrow.hpp compiles on gcc 4.8 [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #472:
URL: https://github.com/apache/arrow-nanoarrow/pull/472#discussion_r1602150506
##########
src/nanoarrow/nanoarrow.hpp:
##########
@@ -905,7 +906,7 @@ inline bool operator==(ArrowStringView l, ArrowStringView r) {
}
/// \brief User literal operator allowing ArrowStringView construction like "str"_sv
-inline ArrowStringView operator""_v(const char* data, std::size_t size_bytes) {
+inline ArrowStringView operator"" _v(const char* data, std::size_t size_bytes) {
Review Comment:
Me too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure nanoarrow.hpp compiles on gcc 4.8 [arrow-nanoarrow]
Posted by "bkietz (via GitHub)" <gi...@apache.org>.
bkietz commented on code in PR #472:
URL: https://github.com/apache/arrow-nanoarrow/pull/472#discussion_r1602133325
##########
src/nanoarrow/nanoarrow.hpp:
##########
@@ -905,7 +906,7 @@ inline bool operator==(ArrowStringView l, ArrowStringView r) {
}
/// \brief User literal operator allowing ArrowStringView construction like "str"_sv
-inline ArrowStringView operator""_v(const char* data, std::size_t size_bytes) {
+inline ArrowStringView operator"" _v(const char* data, std::size_t size_bytes) {
Review Comment:
I'm surprised clang-format doesn't mangle this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure nanoarrow.hpp compiles on gcc 4.8 [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #472:
URL: https://github.com/apache/arrow-nanoarrow/pull/472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org