[GitHub] [bookkeeper] hsaputra commented on a change in pull request #2636: ISSUE-2640: BP-43: Gradle: Build bookkeeper-server with gradle and run unit tests

[GitBox <gi...@apache.org>]

hsaputra commented on a change in pull request #2636:
URL: https://github.com/apache/bookkeeper/pull/2636#discussion_r597288374



##########
File path: bookkeeper-stats-providers/prometheus-metrics-provider/src/test/java/org/apache/bookkeeper/stats/prometheus/TestPrometheusMetricsProvider.java
##########
@@ -70,9 +69,13 @@ public void testStartNoHttpWhenBkHttpEnabled() {
         PropertiesConfiguration config = new PropertiesConfiguration();
         config.setProperty(PrometheusMetricsProvider.PROMETHEUS_STATS_HTTP_ENABLE, true);
         config.setProperty("httpServerEnabled", true);
-        @Cleanup("stop") PrometheusMetricsProvider provider = new PrometheusMetricsProvider();
-        provider.start(config);
-        assertNull(provider.server);
+        PrometheusMetricsProvider provider = new PrometheusMetricsProvider();

Review comment:
       @fpj - wondering if we could follow up for Gradle plugin configurations in a follow up PR?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org