You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "makssent (via GitHub)" <gi...@apache.org> on 2025/01/14 17:34:17 UTC
[PR] Implement Firebird XA transaction support [shardingsphere]
makssent opened a new pull request, #34359:
URL: https://github.com/apache/shardingsphere/pull/34359
Changes proposed in this pull request:
- Added FirebirdXADataSourceDefinition
- Added FirebirdXAConnectionWrapper
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement Firebird XA transaction support [shardingsphere]
Posted by "makssent (via GitHub)" <gi...@apache.org>.
makssent closed pull request #34359: Implement Firebird XA transaction support
URL: https://github.com/apache/shardingsphere/pull/34359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement Firebird XA transaction support [shardingsphere]
Posted by "makssent (via GitHub)" <gi...@apache.org>.
makssent commented on PR #34359:
URL: https://github.com/apache/shardingsphere/pull/34359#issuecomment-2590692792
```Java
/* TODO: Fix the error with getting XAResource
assertThat(actual.getXAResource(), */
```
An issue was discovered in the current code when trying to retrieve the XAResource object via the actual.getXAResource() call. The problem is related to the fact that during the creation of the FBXAConnection object, the connection reference (connection) is not properly stored in the mc variable (which is supposed to hold a weak reference to the FBConnection).
I described the problem to provide an understanding of the solution, in case I return to fix it, or perhaps some enthusiastic person will take it on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org