You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/24 09:28:00 UTC
[jira] [Commented] (CB-13093) Infinite looping when stressing
navigation
[ https://issues.apache.org/jira/browse/CB-13093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098137#comment-16098137 ]
ASF GitHub Bot commented on CB-13093:
-------------------------------------
GitHub user luissilvaos opened a pull request:
https://github.com/apache/cordova-ios/pull/328
CB-13093: (iOS) Infinite looping when stressing navigation
### Platforms affected
iOS
### What does this PR do?
Fix the navigations that starts with the STATE_WAITING_FOR_LOAD_START by calling the self webview:didFailLoadWithError method instead of delegating it.
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/luissilvaos/cordova-ios CB-13093
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #328
----
commit 138e58649a9b698d6a2fb2454497981d7b937669
Author: Luis Silva <lu...@outsystems.com>
Date: 2017-07-24T09:14:51Z
CB-13093: (iOS) Infinite looping when stressing navigation
----
> Infinite looping when stressing navigation
> ------------------------------------------
>
> Key: CB-13093
> URL: https://issues.apache.org/jira/browse/CB-13093
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Reporter: Luis Silva
> Assignee: Shazron Abdullah
>
> An infinite loop is caused by the shouldStartLoadWithRequest method of CDVUIWebViewDelegate when a navigation starts with the STATE_WAITING_FOR_LOAD_START and the ErrorUrl page is defined.
> I already have a fix for this issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org