[jira] [Commented] (YARN-252) Unmanaged AMs should not have to set the AM's ContainerLaunchContext

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531245#comment-13531245 ] 

Bikas Saha commented on YARN-252:
---------------------------------

bq. I'm not sure where you are suggesting such a check is needed. Which class/method do you mean?
I meant over here. I think in addition to the assert a code comment pointing to your above comments on ACL's would also be useful here.
{code}
+      if (app.getRMAppAttempt(applicationAttemptId).getSubmissionContext().getAMContainerSpec() == null) {
+        response.setApplicationACLs(new HashMap<ApplicationAccessType, String>());
+      } else {
+        response.setApplicationACLs(app.getRMAppAttempt(applicationAttemptId)
+            .getSubmissionContext().getAMContainerSpec().getApplicationACLs());
{code}

Regarding your comments on ACL's I agree that container spec should not be set and perhaps we should move ACL's to application submission context instead of container spec. Or in addition to container spec in case its needed in container spec for other scenarios. We can make sure this is covered in YARN-255. Would you please register your ideas in a comment on YARN-255.

bq. I'm talking about the ApplicationSubmissionContext#setAMContainerSpec call, which folks writing YARN apps call in their client.
I didnt think that someone else would need to write an unmanagedAM launcher client. So this would be the only client. Do you have any scenarios in mind where another client would be needed?

                
> Unmanaged AMs should not have to set the AM's ContainerLaunchContext
> --------------------------------------------------------------------
>
>                 Key: YARN-252
>                 URL: https://issues.apache.org/jira/browse/YARN-252
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>    Affects Versions: 2.0.2-alpha
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: YARN-252.patch, YARN-252.patch
>
>
> Not calling ApplicationSubmissionContext#setAMContainerSpec causes a NPE, even though the container is not used (since the AM doesn't run in a managed YARN container).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira