[GitHub] [airflow] ashb commented on a change in pull request #5289: [AIRFLOW-4517] allow for airflow config to influence flask configuration

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5289: [AIRFLOW-4517] allow for airflow config to influence flask configuration
URL: https://github.com/apache/airflow/pull/5289#discussion_r292389455
 
 

 ##########
 File path: tests/cli/test_cli.py
 ##########
 @@ -188,6 +188,20 @@ def test_cli_rbac_webserver_debug(self):
         p.terminate()
         p.wait()
 
+    def test_cli_webserver_flask_debug(self):
+        env = os.environ.copy()
+        env['AIRFLOW__WEBSERVER__RBAC'] = 'True'
+        env['AIRFLOW__FLASK_WEB__PREFERRED_URL_SCHEME'] = 'https'
+        p = psutil.Popen(["airflow", "webserver", "-d"], env=env)
 
 Review comment:
   This test doesn't really assert that we've configured the webserver right. Better would be to use mocking

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services