You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/20 23:27:30 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
dongjoon-hyun opened a new pull request #28594:
URL: https://github.com/apache/spark/pull/28594
### What changes were proposed in this pull request?
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663280946
@ifilonenko and @shaneknapp . Are you sure that is caused by this PR?
> This has been a side-effect of this change.
IIRC, at that time, this PR is tested correctly and I verified that R test are executed there.
- https://github.com/apache/spark/pull/28594#issuecomment-631824311
I guess another PR after this commit may cause the missing R testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631804786
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27550/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dbtsai commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631825289
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631816084
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27551/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shaneknapp commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
shaneknapp commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663263741
> Sure, I totally see the need for an `--exclude-tag`, but the default or current behavior of the integration tests now skips over the SparkR test:[example](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/30887/console). This has been a side-effect of this change.
the specific bits to look at are towards the end of the build... right above `KubernetesSuite`, we build the spark-r image, and the new behavior introduced by this PR then skips the actual integration test against that image within `KubernetesSuite`.
> By default (=if you don't use --exclude-tags r), the test coverage is unchanged in the community so far.
@dongjoon-hyun this is the exact command used by the SparkPullRequestBuilder-K8s job to launch the integration tests. we are not using `--exclude-tags`.
```
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh \
$JAVA_MVN_FLAG --spark-tgz ${WORKSPACE}/spark-*.tgz
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ifilonenko commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
ifilonenko commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-662613310
Is there a reason we are skipping this test? We are doing:
```
./dev/make-distribution.sh --name ${DATE}-${REVISION} --r --pip --tgz -DzincPort=${ZINC_PORT} \
-Phadoop-2.7 -Pkubernetes -Pkinesis-asl -Phive -Phive-thriftserver
retcode=$?
```
so we are already building the distribution with R support. What do we gain from skipping this test? I would have preferred to keep this test tbh, (so as to have greater coverage).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663593043
Thanks. I understand, @ifilonenko . :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631851933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shaneknapp commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
shaneknapp commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663626838
@dongjoon-hyun thanks for the breakdown!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28594:
URL: https://github.com/apache/spark/pull/28594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663280946
@ifilonenko and @shaneknapp . Are you sure that is caused by this PR?
IIRC, at that time, this PR is tested correctly and I verified that R test are executed there.
- https://github.com/apache/spark/pull/28594#issuecomment-631824311
I guess another PR after this commit may cause the missing R testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631804775
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27550/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631836881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663288073
I found another evidence from AmpLab Jenkins farm log. The failed test case is `R test`.
- https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/lastUnsuccessfulBuild/console
```
Started 6 days 0 hr ago
Took 1 hr 18 min on research-jenkins-worker-09
```
```
PR #28708: [SPARK-20629][CORE][K8S] Co...
```
```
KubernetesSuite:
- Run SparkPi with no resources
- Run SparkPi with a very long application name.
- Use SparkLauncher.NO_RESOURCE
- Run SparkPi with a master URL without a scheme.
- Run SparkPi with an argument.
- Run SparkPi with custom labels, annotations, and environment variables.
- All pods have the same service account by default
- Run extraJVMOptions check on driver
- Run SparkRemoteFileTest using a remote data file
- Run SparkPi with env and mount secrets.
- Run PySpark on simple pi.py example
- Run PySpark with Python3 to test a pyfiles example
- Run PySpark with memory customization
- Run in client mode.
- Start pod creation from template
- PVs with local storage
- Launcher client dependencies
- Test basic decommissioning
- Run SparkR on simple dataframe.R example *** FAILED ***
The code passed to eventually never returned normally. Attempted 190 times over 3.0009884667333337 minutes. Last failure message: false was not true. (KubernetesSuite.scala:386)
Run completed in 14 minutes, 46 seconds.
Total number of tests run: 19
Suites: completed 2, aborted 0
Tests: succeeded 18, failed 1, canceled 0, ignored 0, pending 0
*** 1 TEST FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-662839954
By default (=if you don't use `--exclude-tags r`), the test coverage is unchanged in the community so far.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631804956
**[Test build #122908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122908/testReport)** for PR 28594 at commit [`0a37e82`](https://github.com/apache/spark/commit/0a37e821a097b0cb842e8cbc23a788afe1929ac5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631804784
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663288073
I found another evidence from AmpLab Jenkins farm log. The failed test case is `R test`.
- https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/lastUnsuccessfulBuild/console
```
Started 6 days 0 hr ago
Took 1 hr 18 min on research-jenkins-worker-09
```
```
PR #28708: [SPARK-20629][CORE][K8S] Co...
```
```
KubernetesSuite:
- Run SparkPi with no resources
- Run SparkPi with a very long application name.
- Use SparkLauncher.NO_RESOURCE
- Run SparkPi with a master URL without a scheme.
- Run SparkPi with an argument.
- Run SparkPi with custom labels, annotations, and environment variables.
- All pods have the same service account by default
- Run extraJVMOptions check on driver
- Run SparkRemoteFileTest using a remote data file
- Run SparkPi with env and mount secrets.
- Run PySpark on simple pi.py example
- Run PySpark with Python3 to test a pyfiles example
- Run PySpark with memory customization
- Run in client mode.
- Start pod creation from template
- PVs with local storage
- Launcher client dependencies
- Test basic decommissioning
- Run SparkR on simple dataframe.R example *** FAILED ***
The code passed to eventually never returned normally. Attempted 190 times over 3.0009884667333337 minutes. Last failure message: false was not true. (KubernetesSuite.scala:386)
Run completed in 14 minutes, 46 seconds.
Total number of tests run: 19
Suites: completed 2, aborted 0
Tests: succeeded 18, failed 1, canceled 0, ignored 0, pending 0
*** 1 TEST FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shaneknapp commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
shaneknapp commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-662614662
> Is there a reason we are skipping this test? We are doing:
>
> ```
> ./dev/make-distribution.sh --name ${DATE}-${REVISION} --r --pip --tgz -DzincPort=${ZINC_PORT} \
> -Phadoop-2.7 -Pkubernetes -Pkinesis-asl -Phive -Phive-thriftserver
> retcode=$?
> ```
>
> in Jenkins, so we are already building the distribution with R support. What do we gain from skipping this test? I would have preferred to keep this test tbh, (so as to have greater coverage).
i agree... more testing is better imo, especially since we have all the framework in place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663593043
Yep. I understand, @ifilonenko . :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631804784
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631851365
**[Test build #122908 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122908/testReport)** for PR 28594 at commit [`0a37e82`](https://github.com/apache/spark/commit/0a37e821a097b0cb842e8cbc23a788afe1929ac5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663285766
Also, please see the following commit log one week ago. It has `Run SparkR on simple dataframe.R example`
- https://github.com/apache/spark/commit/fb519251237892ad474592d19bf4f193e2a9e2b6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631824311
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27551/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-662839954
By default (=if you don't use `--exclude-tags r`), the test coverage is the same in the community.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663281368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663289180
Since this PR was merged on May 20 and I provided multiple recent evidences of the R testing like the above, @ifilonenko 's claim is wrong.
> This has been a side-effect of this change.
I'll stop my investigation here. Please take a look at more recent commits to solve your problems. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631824322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663281368
Anyway, let me take a look what is going on there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631851933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631804956
**[Test build #122908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122908/testReport)** for PR 28594 at commit [`0a37e82`](https://github.com/apache/spark/commit/0a37e821a097b0cb842e8cbc23a788afe1929ac5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ifilonenko commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
ifilonenko commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663139815
Sure, I totally see the need for an `--exclude-tag`, but the default or current behavior of the integration tests now skips over the SparkR test:[example](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/30887/console). This has been a side-effect of this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ifilonenko edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
ifilonenko edited a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-662613310
Is there a reason we are skipping this test? We are doing:
```
./dev/make-distribution.sh --name ${DATE}-${REVISION} --r --pip --tgz -DzincPort=${ZINC_PORT} \
-Phadoop-2.7 -Pkubernetes -Pkinesis-asl -Phive -Phive-thriftserver
retcode=$?
```
in Jenkins, so we are already building the distribution with R support. What do we gain from skipping this test? I would have preferred to keep this test tbh, (so as to have greater coverage).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663284883
BTW, I also have a personal Jenkins K8s machine on `master` branch and the following is the result last week (2020-07-16T12:14:18-07:00). Of course, I confirmed that `2020-07-20T22:25:51-07:00` test result is missing `Run SparkR on simple dataframe.R example` test. In short, I suspect that something happens on `master` branch between July 16 and July 20.
```
KubernetesSuite:
- Run SparkPi with no resources
- Run SparkPi with a very long application name.
- Use SparkLauncher.NO_RESOURCE
- Run SparkPi with a master URL without a scheme.
- Run SparkPi with an argument.
- Run SparkPi with custom labels, annotations, and environment variables.
- All pods have the same service account by default
- Run extraJVMOptions check on driver
- Run SparkRemoteFileTest using a remote data file
- Run SparkPi with env and mount secrets.
- Run PySpark on simple pi.py example
- Run PySpark with Python3 to test a pyfiles example
- Run PySpark with memory customization
- Run in client mode.
- Start pod creation from template
- PVs with local storage
- Launcher client dependencies
- Test basic decommissioning
- Run SparkR on simple dataframe.R example
Run completed in 9 minutes, 11 seconds.
Total number of tests run: 19
Suites: completed 2, aborted 0
Tests: succeeded 19, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Spark Project Parent POM 3.1.0-SNAPSHOT:
[INFO]
[INFO] Spark Project Parent POM ........................... SUCCESS [ 3.535 s]
[INFO] Spark Project Tags ................................. SUCCESS [ 9.053 s]
[INFO] Spark Project Local DB ............................. SUCCESS [ 5.057 s]
[INFO] Spark Project Networking ........................... SUCCESS [ 6.522 s]
[INFO] Spark Project Shuffle Streaming Service ............ SUCCESS [ 4.582 s]
[INFO] Spark Project Unsafe ............................... SUCCESS [ 10.181 s]
[INFO] Spark Project Launcher ............................. SUCCESS [ 4.874 s]
[INFO] Spark Project Core ................................. SUCCESS [02:05 min]
[INFO] Spark Project Kubernetes Integration Tests ......... SUCCESS [12:29 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:20 min
[INFO] Finished at: 2020-07-16T12:14:18-07:00
[INFO] ------------------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663288073
I found another evidence from our Apache Spark AmpLab Jenkins farm log. The failed test case is `R test`.
- https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/lastUnsuccessfulBuild/console
```
Started 6 days 0 hr ago
Took 1 hr 18 min on research-jenkins-worker-09
```
```
PR #28708: [SPARK-20629][CORE][K8S] Co...
```
```
KubernetesSuite:
- Run SparkPi with no resources
- Run SparkPi with a very long application name.
- Use SparkLauncher.NO_RESOURCE
- Run SparkPi with a master URL without a scheme.
- Run SparkPi with an argument.
- Run SparkPi with custom labels, annotations, and environment variables.
- All pods have the same service account by default
- Run extraJVMOptions check on driver
- Run SparkRemoteFileTest using a remote data file
- Run SparkPi with env and mount secrets.
- Run PySpark on simple pi.py example
- Run PySpark with Python3 to test a pyfiles example
- Run PySpark with memory customization
- Run in client mode.
- Start pod creation from template
- PVs with local storage
- Launcher client dependencies
- Test basic decommissioning
- Run SparkR on simple dataframe.R example *** FAILED ***
The code passed to eventually never returned normally. Attempted 190 times over 3.0009884667333337 minutes. Last failure message: false was not true. (KubernetesSuite.scala:386)
Run completed in 14 minutes, 46 seconds.
Total number of tests run: 19
Suites: completed 2, aborted 0
Tests: succeeded 18, failed 1, canceled 0, ignored 0, pending 0
*** 1 TEST FAILED ***
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663289180
Since this PR was merged on May 20 and I provided the evidence of the R testing like the above, @ifilonenko 's claim is wrong. I'll stop my investigation here. Please take a look more recent commits to solve your problems. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ifilonenko commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
ifilonenko commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663591000
> Of course, I confirmed that 2020-07-20T22:25:51-07:00 test result is missing Run SparkR on simple dataframe.R example test. In short, I suspect that something happens on master branch between July 16 and July 20
I was sure you did :) but it seemed that this was the only code path that touched the R tests, recently and the inclusion of the RTestTag() threw me off. Thanks so much for the thorough investigation! I’ll review elsewhere, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663284883
BTW, I also have a personal Jenkins Job on `master` branch and the following is the result last week (2020-07-16T12:14:18-07:00). Of course, I confirmed that `2020-07-20T22:25:51-07:00` test result is missing `Run SparkR on simple dataframe.R example` test. In short, I suspect that something happens on `master` branch between July 16 and July 20.
```
KubernetesSuite:
- Run SparkPi with no resources
- Run SparkPi with a very long application name.
- Use SparkLauncher.NO_RESOURCE
- Run SparkPi with a master URL without a scheme.
- Run SparkPi with an argument.
- Run SparkPi with custom labels, annotations, and environment variables.
- All pods have the same service account by default
- Run extraJVMOptions check on driver
- Run SparkRemoteFileTest using a remote data file
- Run SparkPi with env and mount secrets.
- Run PySpark on simple pi.py example
- Run PySpark with Python3 to test a pyfiles example
- Run PySpark with memory customization
- Run in client mode.
- Start pod creation from template
- PVs with local storage
- Launcher client dependencies
- Test basic decommissioning
- Run SparkR on simple dataframe.R example
Run completed in 9 minutes, 11 seconds.
Total number of tests run: 19
Suites: completed 2, aborted 0
Tests: succeeded 19, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Spark Project Parent POM 3.1.0-SNAPSHOT:
[INFO]
[INFO] Spark Project Parent POM ........................... SUCCESS [ 3.535 s]
[INFO] Spark Project Tags ................................. SUCCESS [ 9.053 s]
[INFO] Spark Project Local DB ............................. SUCCESS [ 5.057 s]
[INFO] Spark Project Networking ........................... SUCCESS [ 6.522 s]
[INFO] Spark Project Shuffle Streaming Service ............ SUCCESS [ 4.582 s]
[INFO] Spark Project Unsafe ............................... SUCCESS [ 10.181 s]
[INFO] Spark Project Launcher ............................. SUCCESS [ 4.874 s]
[INFO] Spark Project Core ................................. SUCCESS [02:05 min]
[INFO] Spark Project Kubernetes Integration Tests ......... SUCCESS [12:29 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:20 min
[INFO] Finished at: 2020-07-16T12:14:18-07:00
[INFO] ------------------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631791158
**[Test build #122907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122907/testReport)** for PR 28594 at commit [`a26fb26`](https://github.com/apache/spark/commit/a26fb26afdeed73fbaaaf91281680e4ac2c41817).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631803216
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27550/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631817059
Hi, @dbtsai .
Could you review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631836881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631791158
**[Test build #122907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122907/testReport)** for PR 28594 at commit [`a26fb26`](https://github.com/apache/spark/commit/a26fb26afdeed73fbaaaf91281680e4ac2c41817).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-662839474
Hi, @ifilonenko and @shaneknapp .
This is designed to run K8s test more selectively like the other test tags (e.g. `ExtendedYarnTest`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631836233
**[Test build #122907 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122907/testReport)** for PR 28594 at commit [`a26fb26`](https://github.com/apache/spark/commit/a26fb26afdeed73fbaaaf91281680e4ac2c41817).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663289180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663289180
Since this PR was merged on May 20 and I provided multiple evidences of the R testing like the above, @ifilonenko 's claim is wrong.
> This has been a side-effect of this change.
I'll stop my investigation here. Please take a look at more recent commits to solve your problems. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-631824322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org