You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Rob Decker (JIRA)" <in...@incubator.apache.org> on 2005/04/04 19:39:16 UTC

[jira] Created: (MYFACES-163) commandLink actions ignored inside tree2

commandLink actions ignored inside tree2
----------------------------------------

         Key: MYFACES-163
         URL: http://issues.apache.org/jira/browse/MYFACES-163
     Project: MyFaces
        Type: Bug
    Versions: 1.0.9 beta    
 Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
    Reporter: Rob Decker


When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-163) commandLink actions ignored inside tree2

Posted by "sean schofield (JIRA)" <in...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-163?page=comments#action_62270 ]
     
sean schofield commented on MYFACES-163:
----------------------------------------

Ok that sounds like something we can go on.  I will check into what is happening with showRootNode=false (which I haven't been using very much so far.)  Thanks for reporting back.

> commandLink actions ignored inside tree2
> ----------------------------------------
>
>          Key: MYFACES-163
>          URL: http://issues.apache.org/jira/browse/MYFACES-163
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
>     Reporter: Rob Decker
>     Assignee: sean schofield

>
> When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-163) commandLink actions ignored inside tree2

Posted by "Rob Decker (JIRA)" <in...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-163?page=comments#action_62203 ]
     
Rob Decker commented on MYFACES-163:
------------------------------------

I tried it in the simple-examples/tree2 and it worked fine. It still doesn't work for my code though. I subclassed HtmlTree. I'm not sure how that might affect events. I have no idea how to debug events that are supposed to be generated by other components. 

> commandLink actions ignored inside tree2
> ----------------------------------------
>
>          Key: MYFACES-163
>          URL: http://issues.apache.org/jira/browse/MYFACES-163
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
>     Reporter: Rob Decker
>     Assignee: sean schofield

>
> When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-163) commandLink actions ignored inside tree2

Posted by "Rob Decker (JIRA)" <my...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-163?page=comments#action_62315 ]
     
Rob Decker commented on MYFACES-163:
------------------------------------

I fixed this. It was in my subclass which I changed to:

protected void processChildNodes(FacesContext context, TreeNode parentNode, int processAction) {
		if (isNodeExpanded() || (getNodeId() == "0" && !getBoolean(this, JSFAttr.SHOW_ROOT_NODE, true))) 
			super.processChildNodes(context, parentNode, processAction);
	}

from:

protected void processChildNodes(FacesContext context, TreeNode parentNode, int processAction) {
		if (isNodeExpanded()) 
			super.processChildNodes(context, parentNode, processAction);
	}

> commandLink actions ignored inside tree2
> ----------------------------------------
>
>          Key: MYFACES-163
>          URL: http://issues.apache.org/jira/browse/MYFACES-163
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
>     Reporter: Rob Decker
>     Assignee: sean schofield

>
> When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-163) commandLink actions ignored inside tree2

Posted by "sean schofield (JIRA)" <in...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-163?page=comments#action_62148 ]
     
sean schofield commented on MYFACES-163:
----------------------------------------

Unable to reproduce.  I was able to generate a simple server-side example and verify that setNodeSelected was called when using the following actionListener:

actionListener="#{t.setNodeSelected}"

> commandLink actions ignored inside tree2
> ----------------------------------------
>
>          Key: MYFACES-163
>          URL: http://issues.apache.org/jira/browse/MYFACES-163
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
>     Reporter: Rob Decker
>     Assignee: sean schofield

>
> When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-163) commandLink actions ignored inside tree2

Posted by "sean schofield (JIRA)" <in...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-163?page=comments#action_62220 ]
     
sean schofield commented on MYFACES-163:
----------------------------------------

I would think the page translation error would be logged by your webaserver.  Regardless of that, what is your conclusion on this?  Are you saying that the order of the attributes affects whether or not the event is fired properly.  That doesn't make sense to me.  Can you tweak the tree2.jsp simple example to prove this?

> commandLink actions ignored inside tree2
> ----------------------------------------
>
>          Key: MYFACES-163
>          URL: http://issues.apache.org/jira/browse/MYFACES-163
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
>     Reporter: Rob Decker
>     Assignee: sean schofield

>
> When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-163) commandLink actions ignored inside tree2

Posted by "Rob Decker (JIRA)" <in...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-163?page=comments#action_62214 ]
     
Rob Decker commented on MYFACES-163:
------------------------------------

After painstakingly commenting out all just about every jsf tag on the page and reordering the tree tag attributes the listener was finally called. It must have been the order of the attributes in the tree tag because that's the only thing that ended up different about the page. I did this after reading sun's forums that events won't fire if unreported page translation errors occur. Perhaps page translation errors should always be logged. Exactly what I changed on the page the page that got it to start working is beyond me.

> commandLink actions ignored inside tree2
> ----------------------------------------
>
>          Key: MYFACES-163
>          URL: http://issues.apache.org/jira/browse/MYFACES-163
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
>     Reporter: Rob Decker
>     Assignee: sean schofield

>
> When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-163) commandLink actions ignored inside tree2

Posted by "Rob Decker (JIRA)" <in...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-163?page=comments#action_62290 ]
     
Rob Decker commented on MYFACES-163:
------------------------------------

You need to delete the compiled jsp. You can't just change add the attribute to an already compiled jsp and reproduce the problem. In tomcat you look in $TOMCAT_HOME/work/Standalone/localhost/mywebapp/.../mycompiled_jsp_page_with_a_mangled_name.class and delete the .class and .java file so you start with showRootNode="false" when it's compiled the first time the page is accessed.

> commandLink actions ignored inside tree2
> ----------------------------------------
>
>          Key: MYFACES-163
>          URL: http://issues.apache.org/jira/browse/MYFACES-163
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
>     Reporter: Rob Decker
>     Assignee: sean schofield

>
> When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-163) commandLink actions ignored inside tree2

Posted by "Rob Decker (JIRA)" <in...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-163?page=comments#action_62229 ]
     
Rob Decker commented on MYFACES-163:
------------------------------------

I figured out the cause of this bug, although not the fix. You need to start with a previously uncompiled jsp with a tree. If showRootNode="false" is set the events won't work. The reason commenting everything worked for me was that I commented out showRootNode="false". Once I did that, whatever is happening when showRootNode="true" occured in the jsp and after setting it back to false it stuck (jasper must do partial compiles). If I delete the compiled jsp .java/class files and start fresh with showRootNode="false" the events won't fire.

> commandLink actions ignored inside tree2
> ----------------------------------------
>
>          Key: MYFACES-163
>          URL: http://issues.apache.org/jira/browse/MYFACES-163
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
>     Reporter: Rob Decker
>     Assignee: sean schofield

>
> When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-163) commandLink actions ignored inside tree2

Posted by "sean schofield (JIRA)" <in...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-163?page=comments#action_62292 ]
     
sean schofield commented on MYFACES-163:
----------------------------------------

That's what i did the first time.  Did you try modifying tree2 as I suggested earlier today?  I would be suprised if you got a different result.  I'm not saying that showRootNode is working perfectly but I need a (simple) repeatable example case to help figure out what is going on.

> commandLink actions ignored inside tree2
> ----------------------------------------
>
>          Key: MYFACES-163
>          URL: http://issues.apache.org/jira/browse/MYFACES-163
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
>     Reporter: Rob Decker
>     Assignee: sean schofield

>
> When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (MYFACES-163) commandLink actions ignored inside tree2

Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-163?page=history ]
     
sean schofield resolved MYFACES-163:
------------------------------------

    Resolution: Won't Fix

Turns out this was a user errror in the subclass.  Still we will want to keep this in mind if we ever try to add the functionality that Rob is using in his subclass to the HtmlTree.

> commandLink actions ignored inside tree2
> ----------------------------------------
>
>          Key: MYFACES-163
>          URL: http://issues.apache.org/jira/browse/MYFACES-163
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
>     Reporter: Rob Decker
>     Assignee: sean schofield

>
> When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-163) commandLink actions ignored inside tree2

Posted by "sean schofield (JIRA)" <in...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-163?page=comments#action_62287 ]
     
sean schofield commented on MYFACES-163:
----------------------------------------

Still not able to reproduce (at least with actionListener attribute.)  I added showRootNode="false" to the simple tree2 example and node selection still worked fine (implying that the actionListener works fine.)

> commandLink actions ignored inside tree2
> ----------------------------------------
>
>          Key: MYFACES-163
>          URL: http://issues.apache.org/jira/browse/MYFACES-163
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>  Environment: tested on tomcat 5.0.30, windows2000 and redhat linux 9.
>     Reporter: Rob Decker
>     Assignee: sean schofield

>
> When a commandLink inside a tree2 has an action attr, actionListener attr, or f:actionListener tag they are never queued or broadcast and the associated methods never get called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira