You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/14 18:07:41 UTC
[GitHub] [airflow] alexott opened a new pull request #19585: Databricks: allow to specify PAT in Password field
alexott opened a new pull request #19585:
URL: https://github.com/apache/airflow/pull/19585
Currently, the PAT is specified in the extra section, where it's visible, so it's less secure. This PR allows to put PAT into Password field where it will be masked when editing the existing connection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19585: Databricks: allow to specify PAT in Password field
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19585:
URL: https://github.com/apache/airflow/pull/19585#issuecomment-968359783
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on pull request #19585: Databricks: allow to specify PAT in Password field
Posted by GitBox <gi...@apache.org>.
alexott commented on pull request #19585:
URL: https://github.com/apache/airflow/pull/19585#issuecomment-968359798
Thank you - just added that suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19585: Databricks: allow to specify PAT in Password field
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19585:
URL: https://github.com/apache/airflow/pull/19585#discussion_r748905597
##########
File path: docs/apache-airflow-providers-databricks/connections/databricks.rst
##########
@@ -57,14 +57,15 @@ Login (optional)
Password (optional)
* If authentication with *Databricks login credentials* is used then specify the ``password`` used to login to Databricks.
- * If *authentication with Azure Service Principal* is used then specify the secret of the Azure Service Principal
+ * If authentication with *Azure Service Principal* is used then specify the secret of the Azure Service Principal
+ * if authentication with *PAT* is used, then specify PAT (recommended)
Review comment:
```suggestion
* if authentication with *PAT* is used, then specify PAT and leave login empty (recommended)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19585: Databricks: allow to specify PAT in Password field
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19585:
URL: https://github.com/apache/airflow/pull/19585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org