You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Yuan Gao (JIRA)" <de...@myfaces.apache.org> on 2010/11/01 18:34:24 UTC
[jira] Created: (TRINIDAD-1949) SessionChangeManager failed to
apply changes with page incluldes
SessionChangeManager failed to apply changes with page incluldes
----------------------------------------------------------------
Key: TRINIDAD-1949
URL: https://issues.apache.org/jira/browse/TRINIDAD-1949
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Affects Versions: 1.2.12-core
Environment: Today when we apply a customization change in SessionChangeManager, we check if this request is a postback or not. If it is, then we will assume that it's state has been restored correctly, and we will skip. This works for normal views, but for views with a included sub page, like a region, we can't restore the state correctly, and since it's a postback, we will skip applying the customizations, so the end result is we will lose the customizations.
The current fix is to always return false in _isStateRestored(). In the long term, we might have better solutions like asking all page fragments to restore their states.
Reporter: Yuan Gao
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1949) SessionChangeManager failed to
apply changes with page incluldes
Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gabrielle Crawford updated TRINIDAD-1949:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0.4-core
1.2.15-core
Status: Resolved (was: Patch Available)
> SessionChangeManager failed to apply changes with page incluldes
> ----------------------------------------------------------------
>
> Key: TRINIDAD-1949
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1949
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.12-core
> Environment: Today when we apply a customization change in SessionChangeManager, we check if this request is a postback or not. If it is, then we will assume that it's state has been restored correctly, and we will skip. This works for normal views, but for views with a included sub page, like a region, we can't restore the state correctly, and since it's a postback, we will skip applying the customizations, so the end result is we will lose the customizations.
> The current fix is to always return false in _isStateRestored(). In the long term, we might have better solutions like asking all page fragments to restore their states.
> Reporter: Yuan Gao
> Fix For: 1.2.15-core , 2.0.0.4-core
>
> Attachments: postback-flag.patch.1.2.12.3, postback-flag.patch.1.2.x, postback-flag.patch.trunk
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1949) SessionChangeManager failed to
apply changes with page incluldes
Posted by "Yuan Gao (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yuan Gao updated TRINIDAD-1949:
-------------------------------
Status: Patch Available (was: Open)
> SessionChangeManager failed to apply changes with page incluldes
> ----------------------------------------------------------------
>
> Key: TRINIDAD-1949
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1949
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.12-core
> Environment: Today when we apply a customization change in SessionChangeManager, we check if this request is a postback or not. If it is, then we will assume that it's state has been restored correctly, and we will skip. This works for normal views, but for views with a included sub page, like a region, we can't restore the state correctly, and since it's a postback, we will skip applying the customizations, so the end result is we will lose the customizations.
> The current fix is to always return false in _isStateRestored(). In the long term, we might have better solutions like asking all page fragments to restore their states.
> Reporter: Yuan Gao
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.